Re: [PATCH] usb/gadget: fix gadgetfs aio support

[Mathieu Laurendeau <mathieu@laurendeau.net>]

I'll resend the patch. Sorry for the noise.

Le 08/07/2016 13:01, Sergei Shtylyov a écrit :
> Hello.
> 
> On 7/8/2016 9:15 AM, Mathieu Laurendeau wrote:
> 
>> Hi,
> 
>    Greetings should not be a part of the patch description.
> 
>> Since commit 7fe3976e0f3ab26f8ffd9430d3d2a19a70f2c8d2 ("gadget: switch
>> ep_io_operations to ->read_iter/->write_iter") io submissions fail with
>> ENODEV.
>>
>> Fixes: 7fe3976e0f3a ("gadget: switch ep_io_operations to
>> ->read_iter/->write_iter")
>> Signed-off-by: Mathieu Laurendeau <mat.lau@laposte.net>
>> ---
>>  drivers/usb/gadget/legacy/inode.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/gadget/legacy/inode.c b/drivers/usb/gadget/legacy/inode.c
>> index aa3707b..120a03a 100644
>> --- a/drivers/usb/gadget/legacy/inode.c
>> +++ b/drivers/usb/gadget/legacy/inode.c
>> @@ -542,7 +542,7 @@ static ssize_t ep_aio(struct kiocb *iocb,
>>       */
>>      spin_lock_irq(&epdata->dev->lock);
>>      value = -ENODEV;
>> -    if (unlikely(epdata->ep))
>> +    if (unlikely(epdata->ep) == NULL)
> 
>    This placement of the inner parens doesn't make sense, you should enclose the whole comparison.
> 
> [...]
> 
> MBR, Sergei
>