From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Andi Shyti <andi.shyti@samsung.com>, Mark Brown <broonie@kernel.org>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
Kukjin Kim <kgene@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org, Andi Shyti <andi@etezian.org>
Subject: Re: [PATCH 1/4] spi: s3c64xx: rename goto labels to meaningful names
Date: Fri, 08 Jul 2016 15:12:48 +0200 [thread overview]
Message-ID: <577FA6D0.2070403@samsung.com> (raw)
In-Reply-To: <577FA677.7090708@samsung.com>
On 07/08/2016 03:11 PM, Krzysztof Kozlowski wrote:
> On 07/08/2016 02:18 PM, Andi Shyti wrote:
>> In goto labels of the style of
>
> s/In/The/
>
>>
>> err4:
>> err3:
>> err2:
>> err1:
>>
>> is complex to insert in between new errors without renaming all
>
> s/is/are/ (or just rewrite it... "The style of such goto labels... is")
>
>> the goto statments. Replace the errX naming style to meaningful
>
> s/statments/satements/
Yeah, nice job (to me)... error in error correction. Of course
"statements"...
BR,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] spi: s3c64xx: rename goto labels to meaningful names
Date: Fri, 08 Jul 2016 15:12:48 +0200 [thread overview]
Message-ID: <577FA6D0.2070403@samsung.com> (raw)
In-Reply-To: <577FA677.7090708@samsung.com>
On 07/08/2016 03:11 PM, Krzysztof Kozlowski wrote:
> On 07/08/2016 02:18 PM, Andi Shyti wrote:
>> In goto labels of the style of
>
> s/In/The/
>
>>
>> err4:
>> err3:
>> err2:
>> err1:
>>
>> is complex to insert in between new errors without renaming all
>
> s/is/are/ (or just rewrite it... "The style of such goto labels... is")
>
>> the goto statments. Replace the errX naming style to meaningful
>
> s/statments/satements/
Yeah, nice job (to me)... error in error correction. Of course
"statements"...
BR,
Krzysztof
next prev parent reply other threads:[~2016-07-08 13:12 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 12:18 [PATCH 0/4] spi s3c64xx ioclk handling Andi Shyti
2016-07-08 12:18 ` Andi Shyti
2016-07-08 12:18 ` [PATCH 1/4] spi: s3c64xx: rename goto labels to meaningful names Andi Shyti
2016-07-08 12:18 ` Andi Shyti
[not found] ` <1467980304-14093-2-git-send-email-andi.shyti-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-07-08 13:11 ` Krzysztof Kozlowski
2016-07-08 13:11 ` Krzysztof Kozlowski
2016-07-08 13:11 ` Krzysztof Kozlowski
2016-07-08 13:12 ` Krzysztof Kozlowski [this message]
2016-07-08 13:12 ` Krzysztof Kozlowski
2016-07-08 12:18 ` [PATCH 2/4] bindings: spi-samsung: add exynos5433 spi compatible Andi Shyti
2016-07-08 12:18 ` Andi Shyti
[not found] ` <1467980304-14093-3-git-send-email-andi.shyti-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-07-08 12:51 ` Krzysztof Kozlowski
2016-07-08 12:51 ` Krzysztof Kozlowski
2016-07-08 12:51 ` Krzysztof Kozlowski
[not found] ` <577FA1CB.30805-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-07-08 12:56 ` Andi Shyti
2016-07-08 12:56 ` Andi Shyti
2016-07-08 12:56 ` Andi Shyti
2016-07-08 13:00 ` Krzysztof Kozlowski
2016-07-08 13:00 ` Krzysztof Kozlowski
2016-07-08 12:18 ` [PATCH 3/4] spi: s3c64xx: add nexynos5433 compatible for ioclk handling Andi Shyti
2016-07-08 12:18 ` Andi Shyti
2016-07-08 13:21 ` Krzysztof Kozlowski
2016-07-08 13:21 ` Krzysztof Kozlowski
2016-07-08 12:18 ` [PATCH 4/4] spi: s3c64xx: restore removed comments Andi Shyti
2016-07-08 12:18 ` Andi Shyti
[not found] ` <1467980304-14093-5-git-send-email-andi.shyti-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-07-08 12:52 ` Krzysztof Kozlowski
2016-07-08 12:52 ` Krzysztof Kozlowski
2016-07-08 12:52 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577FA6D0.2070403@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=andi.shyti@samsung.com \
--cc=andi@etezian.org \
--cc=broonie@kernel.org \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.