From: Xing Zheng <zhengxing@rock-chips.com>
To: Rob Herring <robh@kernel.org>
Cc: linux-rockchip@lists.infradead.org, dianders@chromium.org,
heiko@sntech.de, smbarber@google.com,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH v6] ASoC: rockchip: Add machine driver for RK3399 GRU Boards
Date: Mon, 11 Jul 2016 14:20:01 +0800 [thread overview]
Message-ID: <57833A91.7090109@rock-chips.com> (raw)
In-Reply-To: <20160620130812.GA24614@rob-hp-laptop>
Hi Mark,
In your opinion, is there anything needs to be optimized in this patch?
Thanks.
On 2016年06月20日 21:08, Rob Herring wrote:
> On Thu, Jun 16, 2016 at 08:40:58PM +0800, Xing Zheng wrote:
>> Because we need to support the multiple codecs (MAX98357A/RT5514/DA7219)
>> on the RK3399 GRU boards, this patch can help us to support these codecs.
>>
>> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
>> ---
>>
>> Changes in v6:
>> - remove enable/disable dapm pins, and to switch codecs via user space
>> - fix "Speaker" dapm route for max98357a
>> - add SND_JACK_LINEOUT flag for da7219 jack detection
>>
>> Changes in v5:
>> - fix the build warning for missing I2C/CLKDEV_LOOKUP dependency
>>
>> Changes in v4:
>> - the compatible name needs to be based on a single reference design,
>> and the name of the board is called "GRU"
>> - use one i2sX card "rockchip,cpu = <&i2s0>" instead of array that is
>> based on GRU
>> - rename DOC to rockchip,rk3399-gru-sound.txt
>> - rename compatible to rockchip,rk3399-gru-sound
>> - rename source code to rk3399_gru_sound.c
>>
>> Changes in v3:
>> - rename DOC to rockchip,rk3399-max98357a-rt5514-da7219.txt
>> - rename compatible to rockchip,rk3399-max98357a-rt5514-da7219
>> - rename source code to rk3399_max98357a_rt5514_da7219.c
>>
>> Changes in v2:
>> - use the FS 256 to set mclks of the max98357a and rt5514 danamically
>> - add more sample rate for da7219
>>
>> .../bindings/sound/rockchip,rk3399-gru-sound.txt | 15 +
> Acked-by: Rob Herring <robh@kernel.org>
>
>> sound/soc/rockchip/Kconfig | 11 +
>> sound/soc/rockchip/Makefile | 2 +
>> sound/soc/rockchip/rk3399_gru_sound.c | 322 ++++++++++++++++++++
>> 4 files changed, 350 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/sound/rockchip,rk3399-gru-sound.txt
>> create mode 100644 sound/soc/rockchip/rk3399_gru_sound.c
>
>
--
- Xing Zheng
WARNING: multiple messages have this Message-ID (diff)
From: zhengxing@rock-chips.com (Xing Zheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6] ASoC: rockchip: Add machine driver for RK3399 GRU Boards
Date: Mon, 11 Jul 2016 14:20:01 +0800 [thread overview]
Message-ID: <57833A91.7090109@rock-chips.com> (raw)
In-Reply-To: <20160620130812.GA24614@rob-hp-laptop>
Hi Mark,
In your opinion, is there anything needs to be optimized in this patch?
Thanks.
On 2016?06?20? 21:08, Rob Herring wrote:
> On Thu, Jun 16, 2016 at 08:40:58PM +0800, Xing Zheng wrote:
>> Because we need to support the multiple codecs (MAX98357A/RT5514/DA7219)
>> on the RK3399 GRU boards, this patch can help us to support these codecs.
>>
>> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
>> ---
>>
>> Changes in v6:
>> - remove enable/disable dapm pins, and to switch codecs via user space
>> - fix "Speaker" dapm route for max98357a
>> - add SND_JACK_LINEOUT flag for da7219 jack detection
>>
>> Changes in v5:
>> - fix the build warning for missing I2C/CLKDEV_LOOKUP dependency
>>
>> Changes in v4:
>> - the compatible name needs to be based on a single reference design,
>> and the name of the board is called "GRU"
>> - use one i2sX card "rockchip,cpu = <&i2s0>" instead of array that is
>> based on GRU
>> - rename DOC to rockchip,rk3399-gru-sound.txt
>> - rename compatible to rockchip,rk3399-gru-sound
>> - rename source code to rk3399_gru_sound.c
>>
>> Changes in v3:
>> - rename DOC to rockchip,rk3399-max98357a-rt5514-da7219.txt
>> - rename compatible to rockchip,rk3399-max98357a-rt5514-da7219
>> - rename source code to rk3399_max98357a_rt5514_da7219.c
>>
>> Changes in v2:
>> - use the FS 256 to set mclks of the max98357a and rt5514 danamically
>> - add more sample rate for da7219
>>
>> .../bindings/sound/rockchip,rk3399-gru-sound.txt | 15 +
> Acked-by: Rob Herring <robh@kernel.org>
>
>> sound/soc/rockchip/Kconfig | 11 +
>> sound/soc/rockchip/Makefile | 2 +
>> sound/soc/rockchip/rk3399_gru_sound.c | 322 ++++++++++++++++++++
>> 4 files changed, 350 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/sound/rockchip,rk3399-gru-sound.txt
>> create mode 100644 sound/soc/rockchip/rk3399_gru_sound.c
>
>
--
- Xing Zheng
next prev parent reply other threads:[~2016-07-11 6:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 12:40 [PATCH v6] ASoC: rockchip: Add machine driver for RK3399 GRU Boards Xing Zheng
2016-06-16 12:40 ` Xing Zheng
2016-06-16 12:40 ` Xing Zheng
2016-06-20 13:08 ` Rob Herring
2016-06-20 13:08 ` Rob Herring
2016-06-20 13:08 ` Rob Herring
2016-07-11 6:20 ` Xing Zheng [this message]
2016-07-11 6:20 ` Xing Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57833A91.7090109@rock-chips.com \
--to=zhengxing@rock-chips.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=smbarber@google.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.