* [PATCH 1/6] multipath-tools: delete attributes with DEFAULT_* values in hwtable.c
2016-07-08 23:58 [PATCH 0/6] Delete attributes with default values Xose Vazquez Perez
@ 2016-07-08 23:58 ` Xose Vazquez Perez
2016-07-22 9:40 ` Christophe Varoqui
2016-07-08 23:58 ` [PATCH 2/6] multipath-tools: delete prio_args attribute when it is equal to default value Xose Vazquez Perez
` (5 subsequent siblings)
6 siblings, 1 reply; 13+ messages in thread
From: Xose Vazquez Perez @ 2016-07-08 23:58 UTC (permalink / raw)
Cc: device-mapper development, Xose Vazquez Perez
48 .features = DEFAULT_FEATURES,
44 .hwhandler = DEFAULT_HWHANDLER,
28 .prio_name = DEFAULT_PRIO,
1 .minio = DEFAULT_MINIO,
1 .minio_rq = DEFAULT_MINIO_RQ,
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
libmultipath/hwtable.c | 122 -------------------------------------------------
1 file changed, 122 deletions(-)
diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index a89ea87..6d87cf4 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -28,13 +28,10 @@ static struct hwentry default_hw[] = {
{
.vendor = "COMPELNT",
.product = "Compellent Vol",
- .features = DEFAULT_FEATURES,
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = MULTIBUS,
.pgfailback = -FAILBACK_IMMEDIATE,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_QUEUE,
- .prio_name = DEFAULT_PRIO,
.prio_args = NULL,
},
/*
@@ -46,13 +43,10 @@ static struct hwentry default_hw[] = {
{
.vendor = "APPLE.*",
.product = "Xserve RAID",
- .features = DEFAULT_FEATURES,
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = MULTIBUS,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
- .prio_name = DEFAULT_PRIO,
.prio_args = NULL,
},
/*
@@ -61,13 +55,10 @@ static struct hwentry default_hw[] = {
{
.vendor = "3PARdata",
.product = "VV",
- .features = DEFAULT_FEATURES,
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = MULTIBUS,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
- .prio_name = DEFAULT_PRIO,
.prio_args = NULL,
},
{
@@ -86,13 +77,10 @@ static struct hwentry default_hw[] = {
{
.vendor = "HP",
.product = "A6189A",
- .features = DEFAULT_FEATURES,
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = MULTIBUS,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = 12,
- .prio_name = DEFAULT_PRIO,
.prio_args = NULL,
},
{
@@ -114,8 +102,6 @@ static struct hwentry default_hw[] = {
/* MSA 1000/1500 with new firmware */
.vendor = "(COMPAQ|HP)",
.product = "MSA VOLUME",
- .features = DEFAULT_FEATURES,
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
.rr_weight = RR_WEIGHT_NONE,
@@ -128,8 +114,6 @@ static struct hwentry default_hw[] = {
/* EVA 3000/5000 with new firmware, EVA 4000/6000/8000 */
.vendor = "(COMPAQ|HP)",
.product = "HSV1[01]1|HSV2[01]0|HSV3[046]0|HSV4[05]0",
- .features = DEFAULT_FEATURES,
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
.rr_weight = RR_WEIGHT_NONE,
@@ -142,22 +126,17 @@ static struct hwentry default_hw[] = {
/* HP MSA2000 family with old firmware */
.vendor = "HP",
.product = "MSA2[02]12fc|MSA2012i",
- .features = DEFAULT_FEATURES,
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = MULTIBUS,
.pgfailback = -FAILBACK_IMMEDIATE,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = 18,
.minio = 100,
- .prio_name = DEFAULT_PRIO,
.prio_args = NULL,
},
{
/* HP MSA2000 family with new firmware */
.vendor = "HP",
.product = "MSA2012sa|MSA23(12|24)(fc|i|sa)|MSA2000s VOLUME",
- .features = DEFAULT_FEATURES,
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
.rr_weight = RR_WEIGHT_NONE,
@@ -170,8 +149,6 @@ static struct hwentry default_hw[] = {
/* HP MSA 1040/2040 family */
.vendor = "HP",
.product = "MSA (1|2)040 SA(N|S)",
- .features = DEFAULT_FEATURES,
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
.rr_weight = RR_WEIGHT_NONE,
@@ -184,7 +161,6 @@ static struct hwentry default_hw[] = {
/* HP SVSP */
.vendor = "HP",
.product = "HSVX700",
- .features = DEFAULT_FEATURES,
.hwhandler = "1 alua",
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
@@ -198,21 +174,16 @@ static struct hwentry default_hw[] = {
/* HP Smart Array */
.vendor = "HP",
.product = "LOGICAL VOLUME.*",
- .features = DEFAULT_FEATURES,
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = MULTIBUS,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = 12,
- .prio_name = DEFAULT_PRIO,
.prio_args = NULL,
},
{
/* HP P2000 family */
.vendor = "HP",
.product = "P2000 G3 FC|P2000G3 FC/iSCSI|P2000 G3 SAS|P2000 G3 iSCSI",
- .features = DEFAULT_FEATURES,
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
.rr_weight = RR_WEIGHT_NONE,
@@ -227,13 +198,10 @@ static struct hwentry default_hw[] = {
{
.vendor = "DDN",
.product = "SAN DataDirector",
- .features = DEFAULT_FEATURES,
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = MULTIBUS,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
- .prio_name = DEFAULT_PRIO,
.prio_args = NULL,
},
/*
@@ -245,13 +213,10 @@ static struct hwentry default_hw[] = {
{
.vendor = "EMC",
.product = "SYMMETRIX",
- .features = DEFAULT_FEATURES,
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = MULTIBUS,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = 6,
- .prio_name = DEFAULT_PRIO,
.prio_args = NULL,
},
{
@@ -275,25 +240,19 @@ static struct hwentry default_hw[] = {
.vendor = "EMC",
.product = "Invista",
.bl_product = "LUNZ",
- .features = DEFAULT_FEATURES,
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = MULTIBUS,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = 5,
- .prio_name = DEFAULT_PRIO,
.prio_args = NULL,
},
{
.vendor = "XtremIO",
.product = "XtremApp",
- .features = DEFAULT_FEATURES,
- .hwhandler = DEFAULT_HWHANDLER,
.selector = "queue-length 0",
.pgpolicy = MULTIBUS,
.pgfailback = FAILBACK_UNDEF,
.fast_io_fail = 5,
- .prio_name = DEFAULT_PRIO,
.prio_args = NULL,
},
/*
@@ -302,20 +261,16 @@ static struct hwentry default_hw[] = {
{
.vendor = "FSC",
.product = "CentricStor",
- .features = DEFAULT_FEATURES,
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = GROUP_BY_SERIAL,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
- .prio_name = DEFAULT_PRIO,
.prio_args = NULL,
},
{
.vendor = "FUJITSU",
.product = "ETERNUS_DX(H|L|M|400|8000)",
.features = "1 queue_if_no_path",
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
.rr_weight = RR_WEIGHT_NONE,
@@ -332,20 +287,16 @@ static struct hwentry default_hw[] = {
{
.vendor = "(HITACHI|HP)",
.product = "OPEN-.*",
- .features = DEFAULT_FEATURES,
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = MULTIBUS,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
- .prio_name = DEFAULT_PRIO,
.prio_args = NULL,
},
{
.vendor = "HITACHI",
.product = "DF.*",
.features = "1 queue_if_no_path",
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
.rr_weight = RR_WEIGHT_NONE,
@@ -362,13 +313,10 @@ static struct hwentry default_hw[] = {
{
.vendor = "IBM",
.product = "ProFibre 4000R",
- .features = DEFAULT_FEATURES,
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = MULTIBUS,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
- .prio_name = DEFAULT_PRIO,
.prio_args = NULL,
},
{
@@ -421,7 +369,6 @@ static struct hwentry default_hw[] = {
.vendor = "IBM",
.product = "^1742",
.bl_product = "Universal Xport",
- .features = DEFAULT_FEATURES,
.hwhandler = "1 rdac",
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
@@ -450,7 +397,6 @@ static struct hwentry default_hw[] = {
.vendor = "IBM",
.product = "^1814",
.bl_product = "Universal Xport",
- .features = DEFAULT_FEATURES,
.hwhandler = "1 rdac",
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
@@ -465,7 +411,6 @@ static struct hwentry default_hw[] = {
.vendor = "IBM",
.product = "^1815",
.bl_product = "Universal Xport",
- .features = DEFAULT_FEATURES,
.hwhandler = "1 rdac",
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
@@ -480,7 +425,6 @@ static struct hwentry default_hw[] = {
.vendor = "IBM",
.product = "^1818",
.bl_product = "Universal Xport",
- .features = DEFAULT_FEATURES,
.hwhandler = "1 rdac",
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
@@ -495,7 +439,6 @@ static struct hwentry default_hw[] = {
.vendor = "IBM",
.product = "^3526",
.bl_product = "Universal Xport",
- .features = DEFAULT_FEATURES,
.hwhandler = "1 rdac",
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
@@ -509,13 +452,10 @@ static struct hwentry default_hw[] = {
/* IBM DS4200 / FAStT200 */
.vendor = "IBM",
.product = "^3542",
- .features = DEFAULT_FEATURES,
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = GROUP_BY_SERIAL,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
- .prio_name = DEFAULT_PRIO,
.prio_args = NULL,
},
{
@@ -523,12 +463,10 @@ static struct hwentry default_hw[] = {
.vendor = "IBM",
.product = "^2105800",
.features = "1 queue_if_no_path",
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = GROUP_BY_SERIAL,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
- .prio_name = DEFAULT_PRIO,
.prio_args = NULL,
},
{
@@ -536,12 +474,10 @@ static struct hwentry default_hw[] = {
.vendor = "IBM",
.product = "^2105F20",
.features = "1 queue_if_no_path",
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = GROUP_BY_SERIAL,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
- .prio_name = DEFAULT_PRIO,
.prio_args = NULL,
},
{
@@ -549,7 +485,6 @@ static struct hwentry default_hw[] = {
.vendor = "IBM",
.product = "^1750500",
.features = "1 queue_if_no_path",
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
.rr_weight = RR_WEIGHT_NONE,
@@ -562,12 +497,10 @@ static struct hwentry default_hw[] = {
.vendor = "IBM",
.product = "^2107900",
.features = "1 queue_if_no_path",
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = MULTIBUS,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
- .prio_name = DEFAULT_PRIO,
.prio_args = NULL,
},
{
@@ -575,7 +508,6 @@ static struct hwentry default_hw[] = {
.vendor = "IBM",
.product = "^2145",
.features = "1 queue_if_no_path",
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
.rr_weight = RR_WEIGHT_NONE,
@@ -590,12 +522,10 @@ static struct hwentry default_hw[] = {
.bl_product = "S/390.*",
.uid_attribute = "ID_UID",
.features = "1 queue_if_no_path",
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = MULTIBUS,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
- .prio_name = DEFAULT_PRIO,
.prio_args = NULL,
},
{
@@ -605,12 +535,10 @@ static struct hwentry default_hw[] = {
.bl_product = "S/390.*",
.uid_attribute = "ID_UID",
.features = "1 queue_if_no_path",
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = MULTIBUS,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
- .prio_name = DEFAULT_PRIO,
.prio_args = NULL,
},
{
@@ -630,8 +558,6 @@ static struct hwentry default_hw[] = {
/* IBM RSSM */
.vendor = "IBM",
.product = "1820N00",
- .features = DEFAULT_FEATURES,
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
.rr_weight = RR_WEIGHT_NONE,
@@ -645,13 +571,11 @@ static struct hwentry default_hw[] = {
.vendor = "IBM",
.product = "2810XIV",
.features = "1 queue_if_no_path",
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = MULTIBUS,
.pgfailback = 15,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
.minio = 15,
- .prio_name = DEFAULT_PRIO,
.prio_args = NULL,
},
/*
@@ -664,33 +588,26 @@ static struct hwentry default_hw[] = {
/* AIX VDASD */
.vendor = "AIX",
.product = "VDASD",
- .features = DEFAULT_FEATURES,
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = MULTIBUS,
.pgfailback = -FAILBACK_IMMEDIATE,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = (300 / DEFAULT_CHECKINT),
- .prio_name = DEFAULT_PRIO,
.prio_args = NULL,
},
{
/* IBM 3303 NVDISK */
.vendor = "IBM",
.product = "3303 NVDISK",
- .features = DEFAULT_FEATURES,
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = FAILOVER,
.pgfailback = -FAILBACK_IMMEDIATE,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = (300 / DEFAULT_CHECKINT),
- .prio_name = DEFAULT_PRIO,
.prio_args = NULL,
},
{
/* AIX NVDISK */
.vendor = "AIX",
.product = "NVDISK",
- .features = DEFAULT_FEATURES,
.hwhandler = "1 alua",
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
@@ -757,7 +674,6 @@ static struct hwentry default_hw[] = {
.vendor = "NETAPP",
.product = "LUN.*",
.features = "3 queue_if_no_path pg_init_retries 50",
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
.flush_on_last_del = FLUSH_ENABLED,
@@ -775,7 +691,6 @@ static struct hwentry default_hw[] = {
.vendor = "IBM",
.product = "Nseries.*",
.features = "1 queue_if_no_path",
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
.rr_weight = RR_WEIGHT_NONE,
@@ -794,13 +709,11 @@ static struct hwentry default_hw[] = {
.vendor = "NEXENTA",
.product = "COMSTAR",
.features = "1 queue_if_no_path",
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = GROUP_BY_SERIAL,
.pgfailback = -FAILBACK_IMMEDIATE,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = 30,
.minio = 128,
- .prio_name = DEFAULT_PRIO,
.prio_args = NULL,
},
/*
@@ -812,8 +725,6 @@ static struct hwentry default_hw[] = {
{
.vendor = "Pillar",
.product = "Axiom.*",
- .features = DEFAULT_FEATURES,
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
@@ -827,20 +738,16 @@ static struct hwentry default_hw[] = {
{
.vendor = "SGI",
.product = "TP9[13]00",
- .features = DEFAULT_FEATURES,
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = MULTIBUS,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
- .prio_name = DEFAULT_PRIO,
.prio_args = NULL,
},
{
.vendor = "SGI",
.product = "TP9[45]00",
.bl_product = "Universal Xport",
- .features = DEFAULT_FEATURES,
.hwhandler = "1 rdac",
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
@@ -871,7 +778,6 @@ static struct hwentry default_hw[] = {
/* M-Series */
.vendor = "NEC",
.product = "DISK ARRAY",
- .features = DEFAULT_FEATURES,
.hwhandler = "1 alua",
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
@@ -887,7 +793,6 @@ static struct hwentry default_hw[] = {
.vendor = "STK",
.product = "OPENstorage D280",
.bl_product = "Universal Xport",
- .features = DEFAULT_FEATURES,
.hwhandler = "1 rdac",
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
@@ -903,20 +808,16 @@ static struct hwentry default_hw[] = {
{
.vendor = "SUN",
.product = "(StorEdge 3510|T4)",
- .features = DEFAULT_FEATURES,
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = MULTIBUS,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
- .prio_name = DEFAULT_PRIO,
.prio_args = NULL,
},
{
.vendor = "SUN",
.product = "STK6580_6780",
.bl_product = "Universal Xport",
- .features = DEFAULT_FEATURES,
.hwhandler = "1 rdac",
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
@@ -929,13 +830,10 @@ static struct hwentry default_hw[] = {
{
.vendor = "EUROLOGC",
.product = "FC2502",
- .features = DEFAULT_FEATURES,
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
- .prio_name = DEFAULT_PRIO,
.prio_args = NULL,
},
/*
@@ -948,20 +846,17 @@ static struct hwentry default_hw[] = {
.vendor = "PIVOT3",
.product = "RAIGE VOLUME",
.features = "1 queue_if_no_path",
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = MULTIBUS,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
.minio = 100,
- .prio_name = DEFAULT_PRIO,
.prio_args = NULL,
},
{
.vendor = "SUN",
.product = "CSM200_R",
.bl_product = "Universal Xport",
- .features = DEFAULT_FEATURES,
.hwhandler = "1 rdac",
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
@@ -976,7 +871,6 @@ static struct hwentry default_hw[] = {
.vendor = "SUN",
.product = "LCSM100_[IEFS]",
.bl_product = "Universal Xport",
- .features = DEFAULT_FEATURES,
.hwhandler = "1 rdac",
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
@@ -991,14 +885,11 @@ static struct hwentry default_hw[] = {
.vendor = "SUN",
.product = "SUN_6180",
.bl_product = "Universal Xport",
- .features = DEFAULT_FEATURES,
.hwhandler = "1 rdac",
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_QUEUE,
- .minio = DEFAULT_MINIO,
- .minio_rq = DEFAULT_MINIO_RQ,
.checker_name = RDAC,
.prio_name = PRIO_RDAC,
},
@@ -1027,7 +918,6 @@ static struct hwentry default_hw[] = {
.vendor = "STK",
.product = "FLEXLINE 380",
.bl_product = "Universal Xport",
- .features = DEFAULT_FEATURES,
.hwhandler = "1 rdac",
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
@@ -1040,7 +930,6 @@ static struct hwentry default_hw[] = {
{
.vendor = "Intel",
.product = "Multi-Flex",
- .features = DEFAULT_FEATURES,
.hwhandler = "1 alua",
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
@@ -1052,7 +941,6 @@ static struct hwentry default_hw[] = {
{
.vendor = "(LIO-ORG|SUSE)",
.product = "RBD",
- .features = DEFAULT_FEATURES,
.hwhandler = "1 alua",
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
@@ -1065,8 +953,6 @@ static struct hwentry default_hw[] = {
{
.vendor = "DataCore",
.product = "SANmelody",
- .features = DEFAULT_FEATURES,
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
.rr_weight = RR_WEIGHT_NONE,
@@ -1077,8 +963,6 @@ static struct hwentry default_hw[] = {
{
.vendor = "DataCore",
.product = "Virtual Disk",
- .features = DEFAULT_FEATURES,
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
.rr_weight = RR_WEIGHT_NONE,
@@ -1089,13 +973,10 @@ static struct hwentry default_hw[] = {
{
.vendor = "PURE",
.product = "FlashArray",
- .features = DEFAULT_FEATURES,
- .hwhandler = DEFAULT_HWHANDLER,
.selector = "queue-length 0",
.pgpolicy = MULTIBUS,
.pgfailback = -FAILBACK_IMMEDIATE,
.fast_io_fail = 10,
- .prio_name = DEFAULT_PRIO,
.no_path_retry = 0,
.dev_loss = 60,
.prio_args = NULL,
@@ -1103,8 +984,6 @@ static struct hwentry default_hw[] = {
{
.vendor = "HUAWEI",
.product = "XSG1",
- .features = DEFAULT_FEATURES,
- .hwhandler = DEFAULT_HWHANDLER,
.pgpolicy = MULTIBUS,
.pgfailback = -FAILBACK_IMMEDIATE,
},
@@ -1132,7 +1011,6 @@ static struct hwentry default_hw[] = {
.prio_name = PRIO_ALUA,
.pgpolicy = GROUP_BY_PRIO,
.selector = "round-robin 0",
- .features = DEFAULT_FEATURES,
.pgfailback = 30,
.rr_weight = RR_WEIGHT_PRIO,
.no_path_retry = NO_PATH_RETRY_FAIL,
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 1/6] multipath-tools: delete attributes with DEFAULT_* values in hwtable.c
2016-07-08 23:58 ` [PATCH 1/6] multipath-tools: delete attributes with DEFAULT_* values in hwtable.c Xose Vazquez Perez
@ 2016-07-22 9:40 ` Christophe Varoqui
0 siblings, 0 replies; 13+ messages in thread
From: Christophe Varoqui @ 2016-07-22 9:40 UTC (permalink / raw)
To: Xose Vazquez Perez; +Cc: device-mapper development
[-- Attachment #1.1: Type: text/plain, Size: 31802 bytes --]
Merged.
On Sat, Jul 9, 2016 at 1:58 AM, Xose Vazquez Perez <xose.vazquez@gmail.com>
wrote:
> 48 .features = DEFAULT_FEATURES,
> 44 .hwhandler = DEFAULT_HWHANDLER,
> 28 .prio_name = DEFAULT_PRIO,
> 1 .minio = DEFAULT_MINIO,
> 1 .minio_rq = DEFAULT_MINIO_RQ,
>
> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> Cc: device-mapper development <dm-devel@redhat.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
> libmultipath/hwtable.c | 122
> -------------------------------------------------
> 1 file changed, 122 deletions(-)
>
> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> index a89ea87..6d87cf4 100644
> --- a/libmultipath/hwtable.c
> +++ b/libmultipath/hwtable.c
> @@ -28,13 +28,10 @@ static struct hwentry default_hw[] = {
> {
> .vendor = "COMPELNT",
> .product = "Compellent Vol",
> - .features = DEFAULT_FEATURES,
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = MULTIBUS,
> .pgfailback = -FAILBACK_IMMEDIATE,
> .rr_weight = RR_WEIGHT_NONE,
> .no_path_retry = NO_PATH_RETRY_QUEUE,
> - .prio_name = DEFAULT_PRIO,
> .prio_args = NULL,
> },
> /*
> @@ -46,13 +43,10 @@ static struct hwentry default_hw[] = {
> {
> .vendor = "APPLE.*",
> .product = "Xserve RAID",
> - .features = DEFAULT_FEATURES,
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = MULTIBUS,
> .pgfailback = FAILBACK_UNDEF,
> .rr_weight = RR_WEIGHT_NONE,
> .no_path_retry = NO_PATH_RETRY_UNDEF,
> - .prio_name = DEFAULT_PRIO,
> .prio_args = NULL,
> },
> /*
> @@ -61,13 +55,10 @@ static struct hwentry default_hw[] = {
> {
> .vendor = "3PARdata",
> .product = "VV",
> - .features = DEFAULT_FEATURES,
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = MULTIBUS,
> .pgfailback = FAILBACK_UNDEF,
> .rr_weight = RR_WEIGHT_NONE,
> .no_path_retry = NO_PATH_RETRY_UNDEF,
> - .prio_name = DEFAULT_PRIO,
> .prio_args = NULL,
> },
> {
> @@ -86,13 +77,10 @@ static struct hwentry default_hw[] = {
> {
> .vendor = "HP",
> .product = "A6189A",
> - .features = DEFAULT_FEATURES,
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = MULTIBUS,
> .pgfailback = FAILBACK_UNDEF,
> .rr_weight = RR_WEIGHT_NONE,
> .no_path_retry = 12,
> - .prio_name = DEFAULT_PRIO,
> .prio_args = NULL,
> },
> {
> @@ -114,8 +102,6 @@ static struct hwentry default_hw[] = {
> /* MSA 1000/1500 with new firmware */
> .vendor = "(COMPAQ|HP)",
> .product = "MSA VOLUME",
> - .features = DEFAULT_FEATURES,
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = GROUP_BY_PRIO,
> .pgfailback = -FAILBACK_IMMEDIATE,
> .rr_weight = RR_WEIGHT_NONE,
> @@ -128,8 +114,6 @@ static struct hwentry default_hw[] = {
> /* EVA 3000/5000 with new firmware, EVA 4000/6000/8000 */
> .vendor = "(COMPAQ|HP)",
> .product =
> "HSV1[01]1|HSV2[01]0|HSV3[046]0|HSV4[05]0",
> - .features = DEFAULT_FEATURES,
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = GROUP_BY_PRIO,
> .pgfailback = -FAILBACK_IMMEDIATE,
> .rr_weight = RR_WEIGHT_NONE,
> @@ -142,22 +126,17 @@ static struct hwentry default_hw[] = {
> /* HP MSA2000 family with old firmware */
> .vendor = "HP",
> .product = "MSA2[02]12fc|MSA2012i",
> - .features = DEFAULT_FEATURES,
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = MULTIBUS,
> .pgfailback = -FAILBACK_IMMEDIATE,
> .rr_weight = RR_WEIGHT_NONE,
> .no_path_retry = 18,
> .minio = 100,
> - .prio_name = DEFAULT_PRIO,
> .prio_args = NULL,
> },
> {
> /* HP MSA2000 family with new firmware */
> .vendor = "HP",
> .product = "MSA2012sa|MSA23(12|24)(fc|i|sa)|MSA2000s
> VOLUME",
> - .features = DEFAULT_FEATURES,
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = GROUP_BY_PRIO,
> .pgfailback = -FAILBACK_IMMEDIATE,
> .rr_weight = RR_WEIGHT_NONE,
> @@ -170,8 +149,6 @@ static struct hwentry default_hw[] = {
> /* HP MSA 1040/2040 family */
> .vendor = "HP",
> .product = "MSA (1|2)040 SA(N|S)",
> - .features = DEFAULT_FEATURES,
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = GROUP_BY_PRIO,
> .pgfailback = -FAILBACK_IMMEDIATE,
> .rr_weight = RR_WEIGHT_NONE,
> @@ -184,7 +161,6 @@ static struct hwentry default_hw[] = {
> /* HP SVSP */
> .vendor = "HP",
> .product = "HSVX700",
> - .features = DEFAULT_FEATURES,
> .hwhandler = "1 alua",
> .pgpolicy = GROUP_BY_PRIO,
> .pgfailback = -FAILBACK_IMMEDIATE,
> @@ -198,21 +174,16 @@ static struct hwentry default_hw[] = {
> /* HP Smart Array */
> .vendor = "HP",
> .product = "LOGICAL VOLUME.*",
> - .features = DEFAULT_FEATURES,
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = MULTIBUS,
> .pgfailback = FAILBACK_UNDEF,
> .rr_weight = RR_WEIGHT_NONE,
> .no_path_retry = 12,
> - .prio_name = DEFAULT_PRIO,
> .prio_args = NULL,
> },
> {
> /* HP P2000 family */
> .vendor = "HP",
> .product = "P2000 G3 FC|P2000G3 FC/iSCSI|P2000 G3
> SAS|P2000 G3 iSCSI",
> - .features = DEFAULT_FEATURES,
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = GROUP_BY_PRIO,
> .pgfailback = -FAILBACK_IMMEDIATE,
> .rr_weight = RR_WEIGHT_NONE,
> @@ -227,13 +198,10 @@ static struct hwentry default_hw[] = {
> {
> .vendor = "DDN",
> .product = "SAN DataDirector",
> - .features = DEFAULT_FEATURES,
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = MULTIBUS,
> .pgfailback = FAILBACK_UNDEF,
> .rr_weight = RR_WEIGHT_NONE,
> .no_path_retry = NO_PATH_RETRY_UNDEF,
> - .prio_name = DEFAULT_PRIO,
> .prio_args = NULL,
> },
> /*
> @@ -245,13 +213,10 @@ static struct hwentry default_hw[] = {
> {
> .vendor = "EMC",
> .product = "SYMMETRIX",
> - .features = DEFAULT_FEATURES,
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = MULTIBUS,
> .pgfailback = FAILBACK_UNDEF,
> .rr_weight = RR_WEIGHT_NONE,
> .no_path_retry = 6,
> - .prio_name = DEFAULT_PRIO,
> .prio_args = NULL,
> },
> {
> @@ -275,25 +240,19 @@ static struct hwentry default_hw[] = {
> .vendor = "EMC",
> .product = "Invista",
> .bl_product = "LUNZ",
> - .features = DEFAULT_FEATURES,
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = MULTIBUS,
> .pgfailback = FAILBACK_UNDEF,
> .rr_weight = RR_WEIGHT_NONE,
> .no_path_retry = 5,
> - .prio_name = DEFAULT_PRIO,
> .prio_args = NULL,
> },
> {
> .vendor = "XtremIO",
> .product = "XtremApp",
> - .features = DEFAULT_FEATURES,
> - .hwhandler = DEFAULT_HWHANDLER,
> .selector = "queue-length 0",
> .pgpolicy = MULTIBUS,
> .pgfailback = FAILBACK_UNDEF,
> .fast_io_fail = 5,
> - .prio_name = DEFAULT_PRIO,
> .prio_args = NULL,
> },
> /*
> @@ -302,20 +261,16 @@ static struct hwentry default_hw[] = {
> {
> .vendor = "FSC",
> .product = "CentricStor",
> - .features = DEFAULT_FEATURES,
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = GROUP_BY_SERIAL,
> .pgfailback = FAILBACK_UNDEF,
> .rr_weight = RR_WEIGHT_NONE,
> .no_path_retry = NO_PATH_RETRY_UNDEF,
> - .prio_name = DEFAULT_PRIO,
> .prio_args = NULL,
> },
> {
> .vendor = "FUJITSU",
> .product = "ETERNUS_DX(H|L|M|400|8000)",
> .features = "1 queue_if_no_path",
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = GROUP_BY_PRIO,
> .pgfailback = -FAILBACK_IMMEDIATE,
> .rr_weight = RR_WEIGHT_NONE,
> @@ -332,20 +287,16 @@ static struct hwentry default_hw[] = {
> {
> .vendor = "(HITACHI|HP)",
> .product = "OPEN-.*",
> - .features = DEFAULT_FEATURES,
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = MULTIBUS,
> .pgfailback = FAILBACK_UNDEF,
> .rr_weight = RR_WEIGHT_NONE,
> .no_path_retry = NO_PATH_RETRY_UNDEF,
> - .prio_name = DEFAULT_PRIO,
> .prio_args = NULL,
> },
> {
> .vendor = "HITACHI",
> .product = "DF.*",
> .features = "1 queue_if_no_path",
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = GROUP_BY_PRIO,
> .pgfailback = -FAILBACK_IMMEDIATE,
> .rr_weight = RR_WEIGHT_NONE,
> @@ -362,13 +313,10 @@ static struct hwentry default_hw[] = {
> {
> .vendor = "IBM",
> .product = "ProFibre 4000R",
> - .features = DEFAULT_FEATURES,
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = MULTIBUS,
> .pgfailback = FAILBACK_UNDEF,
> .rr_weight = RR_WEIGHT_NONE,
> .no_path_retry = NO_PATH_RETRY_UNDEF,
> - .prio_name = DEFAULT_PRIO,
> .prio_args = NULL,
> },
> {
> @@ -421,7 +369,6 @@ static struct hwentry default_hw[] = {
> .vendor = "IBM",
> .product = "^1742",
> .bl_product = "Universal Xport",
> - .features = DEFAULT_FEATURES,
> .hwhandler = "1 rdac",
> .pgpolicy = GROUP_BY_PRIO,
> .pgfailback = -FAILBACK_IMMEDIATE,
> @@ -450,7 +397,6 @@ static struct hwentry default_hw[] = {
> .vendor = "IBM",
> .product = "^1814",
> .bl_product = "Universal Xport",
> - .features = DEFAULT_FEATURES,
> .hwhandler = "1 rdac",
> .pgpolicy = GROUP_BY_PRIO,
> .pgfailback = -FAILBACK_IMMEDIATE,
> @@ -465,7 +411,6 @@ static struct hwentry default_hw[] = {
> .vendor = "IBM",
> .product = "^1815",
> .bl_product = "Universal Xport",
> - .features = DEFAULT_FEATURES,
> .hwhandler = "1 rdac",
> .pgpolicy = GROUP_BY_PRIO,
> .pgfailback = -FAILBACK_IMMEDIATE,
> @@ -480,7 +425,6 @@ static struct hwentry default_hw[] = {
> .vendor = "IBM",
> .product = "^1818",
> .bl_product = "Universal Xport",
> - .features = DEFAULT_FEATURES,
> .hwhandler = "1 rdac",
> .pgpolicy = GROUP_BY_PRIO,
> .pgfailback = -FAILBACK_IMMEDIATE,
> @@ -495,7 +439,6 @@ static struct hwentry default_hw[] = {
> .vendor = "IBM",
> .product = "^3526",
> .bl_product = "Universal Xport",
> - .features = DEFAULT_FEATURES,
> .hwhandler = "1 rdac",
> .pgpolicy = GROUP_BY_PRIO,
> .pgfailback = -FAILBACK_IMMEDIATE,
> @@ -509,13 +452,10 @@ static struct hwentry default_hw[] = {
> /* IBM DS4200 / FAStT200 */
> .vendor = "IBM",
> .product = "^3542",
> - .features = DEFAULT_FEATURES,
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = GROUP_BY_SERIAL,
> .pgfailback = FAILBACK_UNDEF,
> .rr_weight = RR_WEIGHT_NONE,
> .no_path_retry = NO_PATH_RETRY_UNDEF,
> - .prio_name = DEFAULT_PRIO,
> .prio_args = NULL,
> },
> {
> @@ -523,12 +463,10 @@ static struct hwentry default_hw[] = {
> .vendor = "IBM",
> .product = "^2105800",
> .features = "1 queue_if_no_path",
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = GROUP_BY_SERIAL,
> .pgfailback = FAILBACK_UNDEF,
> .rr_weight = RR_WEIGHT_NONE,
> .no_path_retry = NO_PATH_RETRY_UNDEF,
> - .prio_name = DEFAULT_PRIO,
> .prio_args = NULL,
> },
> {
> @@ -536,12 +474,10 @@ static struct hwentry default_hw[] = {
> .vendor = "IBM",
> .product = "^2105F20",
> .features = "1 queue_if_no_path",
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = GROUP_BY_SERIAL,
> .pgfailback = FAILBACK_UNDEF,
> .rr_weight = RR_WEIGHT_NONE,
> .no_path_retry = NO_PATH_RETRY_UNDEF,
> - .prio_name = DEFAULT_PRIO,
> .prio_args = NULL,
> },
> {
> @@ -549,7 +485,6 @@ static struct hwentry default_hw[] = {
> .vendor = "IBM",
> .product = "^1750500",
> .features = "1 queue_if_no_path",
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = GROUP_BY_PRIO,
> .pgfailback = -FAILBACK_IMMEDIATE,
> .rr_weight = RR_WEIGHT_NONE,
> @@ -562,12 +497,10 @@ static struct hwentry default_hw[] = {
> .vendor = "IBM",
> .product = "^2107900",
> .features = "1 queue_if_no_path",
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = MULTIBUS,
> .pgfailback = FAILBACK_UNDEF,
> .rr_weight = RR_WEIGHT_NONE,
> .no_path_retry = NO_PATH_RETRY_UNDEF,
> - .prio_name = DEFAULT_PRIO,
> .prio_args = NULL,
> },
> {
> @@ -575,7 +508,6 @@ static struct hwentry default_hw[] = {
> .vendor = "IBM",
> .product = "^2145",
> .features = "1 queue_if_no_path",
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = GROUP_BY_PRIO,
> .pgfailback = -FAILBACK_IMMEDIATE,
> .rr_weight = RR_WEIGHT_NONE,
> @@ -590,12 +522,10 @@ static struct hwentry default_hw[] = {
> .bl_product = "S/390.*",
> .uid_attribute = "ID_UID",
> .features = "1 queue_if_no_path",
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = MULTIBUS,
> .pgfailback = FAILBACK_UNDEF,
> .rr_weight = RR_WEIGHT_NONE,
> .no_path_retry = NO_PATH_RETRY_UNDEF,
> - .prio_name = DEFAULT_PRIO,
> .prio_args = NULL,
> },
> {
> @@ -605,12 +535,10 @@ static struct hwentry default_hw[] = {
> .bl_product = "S/390.*",
> .uid_attribute = "ID_UID",
> .features = "1 queue_if_no_path",
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = MULTIBUS,
> .pgfailback = FAILBACK_UNDEF,
> .rr_weight = RR_WEIGHT_NONE,
> .no_path_retry = NO_PATH_RETRY_UNDEF,
> - .prio_name = DEFAULT_PRIO,
> .prio_args = NULL,
> },
> {
> @@ -630,8 +558,6 @@ static struct hwentry default_hw[] = {
> /* IBM RSSM */
> .vendor = "IBM",
> .product = "1820N00",
> - .features = DEFAULT_FEATURES,
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = GROUP_BY_PRIO,
> .pgfailback = -FAILBACK_IMMEDIATE,
> .rr_weight = RR_WEIGHT_NONE,
> @@ -645,13 +571,11 @@ static struct hwentry default_hw[] = {
> .vendor = "IBM",
> .product = "2810XIV",
> .features = "1 queue_if_no_path",
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = MULTIBUS,
> .pgfailback = 15,
> .rr_weight = RR_WEIGHT_NONE,
> .no_path_retry = NO_PATH_RETRY_UNDEF,
> .minio = 15,
> - .prio_name = DEFAULT_PRIO,
> .prio_args = NULL,
> },
> /*
> @@ -664,33 +588,26 @@ static struct hwentry default_hw[] = {
> /* AIX VDASD */
> .vendor = "AIX",
> .product = "VDASD",
> - .features = DEFAULT_FEATURES,
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = MULTIBUS,
> .pgfailback = -FAILBACK_IMMEDIATE,
> .rr_weight = RR_WEIGHT_NONE,
> .no_path_retry = (300 / DEFAULT_CHECKINT),
> - .prio_name = DEFAULT_PRIO,
> .prio_args = NULL,
> },
> {
> /* IBM 3303 NVDISK */
> .vendor = "IBM",
> .product = "3303 NVDISK",
> - .features = DEFAULT_FEATURES,
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = FAILOVER,
> .pgfailback = -FAILBACK_IMMEDIATE,
> .rr_weight = RR_WEIGHT_NONE,
> .no_path_retry = (300 / DEFAULT_CHECKINT),
> - .prio_name = DEFAULT_PRIO,
> .prio_args = NULL,
> },
> {
> /* AIX NVDISK */
> .vendor = "AIX",
> .product = "NVDISK",
> - .features = DEFAULT_FEATURES,
> .hwhandler = "1 alua",
> .pgpolicy = GROUP_BY_PRIO,
> .pgfailback = -FAILBACK_IMMEDIATE,
> @@ -757,7 +674,6 @@ static struct hwentry default_hw[] = {
> .vendor = "NETAPP",
> .product = "LUN.*",
> .features = "3 queue_if_no_path pg_init_retries 50",
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = GROUP_BY_PRIO,
> .pgfailback = -FAILBACK_IMMEDIATE,
> .flush_on_last_del = FLUSH_ENABLED,
> @@ -775,7 +691,6 @@ static struct hwentry default_hw[] = {
> .vendor = "IBM",
> .product = "Nseries.*",
> .features = "1 queue_if_no_path",
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = GROUP_BY_PRIO,
> .pgfailback = -FAILBACK_IMMEDIATE,
> .rr_weight = RR_WEIGHT_NONE,
> @@ -794,13 +709,11 @@ static struct hwentry default_hw[] = {
> .vendor = "NEXENTA",
> .product = "COMSTAR",
> .features = "1 queue_if_no_path",
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = GROUP_BY_SERIAL,
> .pgfailback = -FAILBACK_IMMEDIATE,
> .rr_weight = RR_WEIGHT_NONE,
> .no_path_retry = 30,
> .minio = 128,
> - .prio_name = DEFAULT_PRIO,
> .prio_args = NULL,
> },
> /*
> @@ -812,8 +725,6 @@ static struct hwentry default_hw[] = {
> {
> .vendor = "Pillar",
> .product = "Axiom.*",
> - .features = DEFAULT_FEATURES,
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = GROUP_BY_PRIO,
> .pgfailback = FAILBACK_UNDEF,
> .rr_weight = RR_WEIGHT_NONE,
> @@ -827,20 +738,16 @@ static struct hwentry default_hw[] = {
> {
> .vendor = "SGI",
> .product = "TP9[13]00",
> - .features = DEFAULT_FEATURES,
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = MULTIBUS,
> .pgfailback = FAILBACK_UNDEF,
> .rr_weight = RR_WEIGHT_NONE,
> .no_path_retry = NO_PATH_RETRY_UNDEF,
> - .prio_name = DEFAULT_PRIO,
> .prio_args = NULL,
> },
> {
> .vendor = "SGI",
> .product = "TP9[45]00",
> .bl_product = "Universal Xport",
> - .features = DEFAULT_FEATURES,
> .hwhandler = "1 rdac",
> .pgpolicy = GROUP_BY_PRIO,
> .pgfailback = -FAILBACK_IMMEDIATE,
> @@ -871,7 +778,6 @@ static struct hwentry default_hw[] = {
> /* M-Series */
> .vendor = "NEC",
> .product = "DISK ARRAY",
> - .features = DEFAULT_FEATURES,
> .hwhandler = "1 alua",
> .pgpolicy = GROUP_BY_PRIO,
> .pgfailback = -FAILBACK_IMMEDIATE,
> @@ -887,7 +793,6 @@ static struct hwentry default_hw[] = {
> .vendor = "STK",
> .product = "OPENstorage D280",
> .bl_product = "Universal Xport",
> - .features = DEFAULT_FEATURES,
> .hwhandler = "1 rdac",
> .pgpolicy = GROUP_BY_PRIO,
> .pgfailback = -FAILBACK_IMMEDIATE,
> @@ -903,20 +808,16 @@ static struct hwentry default_hw[] = {
> {
> .vendor = "SUN",
> .product = "(StorEdge 3510|T4)",
> - .features = DEFAULT_FEATURES,
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = MULTIBUS,
> .pgfailback = FAILBACK_UNDEF,
> .rr_weight = RR_WEIGHT_NONE,
> .no_path_retry = NO_PATH_RETRY_UNDEF,
> - .prio_name = DEFAULT_PRIO,
> .prio_args = NULL,
> },
> {
> .vendor = "SUN",
> .product = "STK6580_6780",
> .bl_product = "Universal Xport",
> - .features = DEFAULT_FEATURES,
> .hwhandler = "1 rdac",
> .pgpolicy = GROUP_BY_PRIO,
> .pgfailback = -FAILBACK_IMMEDIATE,
> @@ -929,13 +830,10 @@ static struct hwentry default_hw[] = {
> {
> .vendor = "EUROLOGC",
> .product = "FC2502",
> - .features = DEFAULT_FEATURES,
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = GROUP_BY_PRIO,
> .pgfailback = FAILBACK_UNDEF,
> .rr_weight = RR_WEIGHT_NONE,
> .no_path_retry = NO_PATH_RETRY_UNDEF,
> - .prio_name = DEFAULT_PRIO,
> .prio_args = NULL,
> },
> /*
> @@ -948,20 +846,17 @@ static struct hwentry default_hw[] = {
> .vendor = "PIVOT3",
> .product = "RAIGE VOLUME",
> .features = "1 queue_if_no_path",
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = MULTIBUS,
> .pgfailback = FAILBACK_UNDEF,
> .rr_weight = RR_WEIGHT_NONE,
> .no_path_retry = NO_PATH_RETRY_UNDEF,
> .minio = 100,
> - .prio_name = DEFAULT_PRIO,
> .prio_args = NULL,
> },
> {
> .vendor = "SUN",
> .product = "CSM200_R",
> .bl_product = "Universal Xport",
> - .features = DEFAULT_FEATURES,
> .hwhandler = "1 rdac",
> .pgpolicy = GROUP_BY_PRIO,
> .pgfailback = -FAILBACK_IMMEDIATE,
> @@ -976,7 +871,6 @@ static struct hwentry default_hw[] = {
> .vendor = "SUN",
> .product = "LCSM100_[IEFS]",
> .bl_product = "Universal Xport",
> - .features = DEFAULT_FEATURES,
> .hwhandler = "1 rdac",
> .pgpolicy = GROUP_BY_PRIO,
> .pgfailback = -FAILBACK_IMMEDIATE,
> @@ -991,14 +885,11 @@ static struct hwentry default_hw[] = {
> .vendor = "SUN",
> .product = "SUN_6180",
> .bl_product = "Universal Xport",
> - .features = DEFAULT_FEATURES,
> .hwhandler = "1 rdac",
> .pgpolicy = GROUP_BY_PRIO,
> .pgfailback = -FAILBACK_IMMEDIATE,
> .rr_weight = RR_WEIGHT_NONE,
> .no_path_retry = NO_PATH_RETRY_QUEUE,
> - .minio = DEFAULT_MINIO,
> - .minio_rq = DEFAULT_MINIO_RQ,
> .checker_name = RDAC,
> .prio_name = PRIO_RDAC,
> },
> @@ -1027,7 +918,6 @@ static struct hwentry default_hw[] = {
> .vendor = "STK",
> .product = "FLEXLINE 380",
> .bl_product = "Universal Xport",
> - .features = DEFAULT_FEATURES,
> .hwhandler = "1 rdac",
> .pgpolicy = GROUP_BY_PRIO,
> .pgfailback = -FAILBACK_IMMEDIATE,
> @@ -1040,7 +930,6 @@ static struct hwentry default_hw[] = {
> {
> .vendor = "Intel",
> .product = "Multi-Flex",
> - .features = DEFAULT_FEATURES,
> .hwhandler = "1 alua",
> .pgpolicy = GROUP_BY_PRIO,
> .pgfailback = -FAILBACK_IMMEDIATE,
> @@ -1052,7 +941,6 @@ static struct hwentry default_hw[] = {
> {
> .vendor = "(LIO-ORG|SUSE)",
> .product = "RBD",
> - .features = DEFAULT_FEATURES,
> .hwhandler = "1 alua",
> .pgpolicy = GROUP_BY_PRIO,
> .pgfailback = -FAILBACK_IMMEDIATE,
> @@ -1065,8 +953,6 @@ static struct hwentry default_hw[] = {
> {
> .vendor = "DataCore",
> .product = "SANmelody",
> - .features = DEFAULT_FEATURES,
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = GROUP_BY_PRIO,
> .pgfailback = -FAILBACK_IMMEDIATE,
> .rr_weight = RR_WEIGHT_NONE,
> @@ -1077,8 +963,6 @@ static struct hwentry default_hw[] = {
> {
> .vendor = "DataCore",
> .product = "Virtual Disk",
> - .features = DEFAULT_FEATURES,
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = GROUP_BY_PRIO,
> .pgfailback = -FAILBACK_IMMEDIATE,
> .rr_weight = RR_WEIGHT_NONE,
> @@ -1089,13 +973,10 @@ static struct hwentry default_hw[] = {
> {
> .vendor = "PURE",
> .product = "FlashArray",
> - .features = DEFAULT_FEATURES,
> - .hwhandler = DEFAULT_HWHANDLER,
> .selector = "queue-length 0",
> .pgpolicy = MULTIBUS,
> .pgfailback = -FAILBACK_IMMEDIATE,
> .fast_io_fail = 10,
> - .prio_name = DEFAULT_PRIO,
> .no_path_retry = 0,
> .dev_loss = 60,
> .prio_args = NULL,
> @@ -1103,8 +984,6 @@ static struct hwentry default_hw[] = {
> {
> .vendor = "HUAWEI",
> .product = "XSG1",
> - .features = DEFAULT_FEATURES,
> - .hwhandler = DEFAULT_HWHANDLER,
> .pgpolicy = MULTIBUS,
> .pgfailback = -FAILBACK_IMMEDIATE,
> },
> @@ -1132,7 +1011,6 @@ static struct hwentry default_hw[] = {
> .prio_name = PRIO_ALUA,
> .pgpolicy = GROUP_BY_PRIO,
> .selector = "round-robin 0",
> - .features = DEFAULT_FEATURES,
> .pgfailback = 30,
> .rr_weight = RR_WEIGHT_PRIO,
> .no_path_retry = NO_PATH_RETRY_FAIL,
> --
> 2.7.4
>
>
[-- Attachment #1.2: Type: text/html, Size: 42270 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 2/6] multipath-tools: delete prio_args attribute when it is equal to default value
2016-07-08 23:58 [PATCH 0/6] Delete attributes with default values Xose Vazquez Perez
2016-07-08 23:58 ` [PATCH 1/6] multipath-tools: delete attributes with DEFAULT_* values in hwtable.c Xose Vazquez Perez
@ 2016-07-08 23:58 ` Xose Vazquez Perez
2016-07-08 23:58 ` [PATCH 3/6] multipath-tools: delete no_path_retry " Xose Vazquez Perez
` (4 subsequent siblings)
6 siblings, 0 replies; 13+ messages in thread
From: Xose Vazquez Perez @ 2016-07-08 23:58 UTC (permalink / raw)
Cc: device-mapper development, Xose Vazquez Perez
73 .prio_args = NULL,
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
libmultipath/hwtable.c | 72 --------------------------------------------------
1 file changed, 72 deletions(-)
diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 6d87cf4..8b742f4 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -32,7 +32,6 @@ static struct hwentry default_hw[] = {
.pgfailback = -FAILBACK_IMMEDIATE,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_QUEUE,
- .prio_args = NULL,
},
/*
* Apple
@@ -47,7 +46,6 @@ static struct hwentry default_hw[] = {
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
- .prio_args = NULL,
},
/*
* StorageWorks/HPE
@@ -59,7 +57,6 @@ static struct hwentry default_hw[] = {
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
- .prio_args = NULL,
},
{
.vendor = "DEC",
@@ -72,7 +69,6 @@ static struct hwentry default_hw[] = {
.no_path_retry = NO_PATH_RETRY_UNDEF,
.checker_name = HP_SW,
.prio_name = PRIO_HP_SW,
- .prio_args = NULL,
},
{
.vendor = "HP",
@@ -81,7 +77,6 @@ static struct hwentry default_hw[] = {
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = 12,
- .prio_args = NULL,
},
{
/* MSA 1000/MSA1500 EVA 3000/5000 with old firmware */
@@ -96,7 +91,6 @@ static struct hwentry default_hw[] = {
.minio = 100,
.checker_name = HP_SW,
.prio_name = PRIO_HP_SW,
- .prio_args = NULL,
},
{
/* MSA 1000/1500 with new firmware */
@@ -108,7 +102,6 @@ static struct hwentry default_hw[] = {
.no_path_retry = 12,
.minio = 100,
.prio_name = PRIO_ALUA,
- .prio_args = NULL,
},
{
/* EVA 3000/5000 with new firmware, EVA 4000/6000/8000 */
@@ -120,7 +113,6 @@ static struct hwentry default_hw[] = {
.no_path_retry = 12,
.minio = 100,
.prio_name = PRIO_ALUA,
- .prio_args = NULL,
},
{
/* HP MSA2000 family with old firmware */
@@ -131,7 +123,6 @@ static struct hwentry default_hw[] = {
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = 18,
.minio = 100,
- .prio_args = NULL,
},
{
/* HP MSA2000 family with new firmware */
@@ -143,7 +134,6 @@ static struct hwentry default_hw[] = {
.no_path_retry = 18,
.minio = 100,
.prio_name = PRIO_ALUA,
- .prio_args = NULL,
},
{
/* HP MSA 1040/2040 family */
@@ -155,7 +145,6 @@ static struct hwentry default_hw[] = {
.no_path_retry = 18,
.minio = 100,
.prio_name = PRIO_ALUA,
- .prio_args = NULL,
},
{
/* HP SVSP */
@@ -168,7 +157,6 @@ static struct hwentry default_hw[] = {
.no_path_retry = 12,
.minio = 100,
.prio_name = PRIO_ALUA,
- .prio_args = NULL,
},
{
/* HP Smart Array */
@@ -178,7 +166,6 @@ static struct hwentry default_hw[] = {
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = 12,
- .prio_args = NULL,
},
{
/* HP P2000 family */
@@ -190,7 +177,6 @@ static struct hwentry default_hw[] = {
.no_path_retry = 18,
.minio = 100,
.prio_name = PRIO_ALUA,
- .prio_args = NULL,
},
/*
* DDN
@@ -202,7 +188,6 @@ static struct hwentry default_hw[] = {
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
- .prio_args = NULL,
},
/*
* EMC/DELL
@@ -217,7 +202,6 @@ static struct hwentry default_hw[] = {
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = 6,
- .prio_args = NULL,
},
{
/* DGC CLARiiON CX/AX and EMC VNX */
@@ -232,7 +216,6 @@ static struct hwentry default_hw[] = {
.no_path_retry = (300 / DEFAULT_CHECKINT),
.checker_name = EMC_CLARIION,
.prio_name = PRIO_EMC,
- .prio_args = NULL,
.retain_hwhandler = RETAIN_HWHANDLER_ON,
.detect_prio = DETECT_PRIO_ON,
},
@@ -244,7 +227,6 @@ static struct hwentry default_hw[] = {
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = 5,
- .prio_args = NULL,
},
{
.vendor = "XtremIO",
@@ -253,7 +235,6 @@ static struct hwentry default_hw[] = {
.pgpolicy = MULTIBUS,
.pgfailback = FAILBACK_UNDEF,
.fast_io_fail = 5,
- .prio_args = NULL,
},
/*
* Fujitsu
@@ -265,7 +246,6 @@ static struct hwentry default_hw[] = {
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
- .prio_args = NULL,
},
{
.vendor = "FUJITSU",
@@ -276,7 +256,6 @@ static struct hwentry default_hw[] = {
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = 10,
.prio_name = PRIO_ALUA,
- .prio_args = NULL,
},
/*
* Hitachi
@@ -291,7 +270,6 @@ static struct hwentry default_hw[] = {
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
- .prio_args = NULL,
},
{
.vendor = "HITACHI",
@@ -302,7 +280,6 @@ static struct hwentry default_hw[] = {
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
.prio_name = PRIO_HDS,
- .prio_args = NULL,
},
/*
* IBM
@@ -317,7 +294,6 @@ static struct hwentry default_hw[] = {
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
- .prio_args = NULL,
},
{
/* IBM FAStT 1722-600 */
@@ -332,7 +308,6 @@ static struct hwentry default_hw[] = {
.no_path_retry = 300,
.checker_name = RDAC,
.prio_name = PRIO_RDAC,
- .prio_args = NULL,
},
{
/* IBM DS4100 */
@@ -347,7 +322,6 @@ static struct hwentry default_hw[] = {
.no_path_retry = 300,
.checker_name = RDAC,
.prio_name = PRIO_RDAC,
- .prio_args = NULL,
},
{
/* IBM DS3200 / DS3300 / DS3400 */
@@ -362,7 +336,6 @@ static struct hwentry default_hw[] = {
.no_path_retry = 300,
.checker_name = RDAC,
.prio_name = PRIO_RDAC,
- .prio_args = NULL,
},
{
/* IBM DS4400 / DS4500 / FAStT700 */
@@ -376,7 +349,6 @@ static struct hwentry default_hw[] = {
.no_path_retry = NO_PATH_RETRY_QUEUE,
.checker_name = RDAC,
.prio_name = PRIO_RDAC,
- .prio_args = NULL,
},
{
.vendor = "IBM",
@@ -390,7 +362,6 @@ static struct hwentry default_hw[] = {
.no_path_retry = 15,
.checker_name = RDAC,
.prio_name = PRIO_RDAC,
- .prio_args = NULL,
},
{
/* IBM DS4700 */
@@ -404,7 +375,6 @@ static struct hwentry default_hw[] = {
.no_path_retry = NO_PATH_RETRY_QUEUE,
.checker_name = RDAC,
.prio_name = PRIO_RDAC,
- .prio_args = NULL,
},
{
/* IBM DS4800 */
@@ -418,7 +388,6 @@ static struct hwentry default_hw[] = {
.no_path_retry = NO_PATH_RETRY_QUEUE,
.checker_name = RDAC,
.prio_name = PRIO_RDAC,
- .prio_args = NULL,
},
{
/* IBM DS5000 */
@@ -432,7 +401,6 @@ static struct hwentry default_hw[] = {
.no_path_retry = NO_PATH_RETRY_QUEUE,
.checker_name = RDAC,
.prio_name = PRIO_RDAC,
- .prio_args = NULL,
},
{
/* IBM Netfinity Fibre Channel RAID Controller Unit */
@@ -446,7 +414,6 @@ static struct hwentry default_hw[] = {
.no_path_retry = NO_PATH_RETRY_QUEUE,
.checker_name = RDAC,
.prio_name = PRIO_RDAC,
- .prio_args = NULL,
},
{
/* IBM DS4200 / FAStT200 */
@@ -456,7 +423,6 @@ static struct hwentry default_hw[] = {
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
- .prio_args = NULL,
},
{
/* IBM ESS F20 aka Shark */
@@ -467,7 +433,6 @@ static struct hwentry default_hw[] = {
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
- .prio_args = NULL,
},
{
/* IBM ESS F20 aka Shark */
@@ -478,7 +443,6 @@ static struct hwentry default_hw[] = {
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
- .prio_args = NULL,
},
{
/* IBM DS6000 */
@@ -490,7 +454,6 @@ static struct hwentry default_hw[] = {
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
.prio_name = PRIO_ALUA,
- .prio_args = NULL,
},
{
/* IBM DS8000 */
@@ -501,7 +464,6 @@ static struct hwentry default_hw[] = {
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
- .prio_args = NULL,
},
{
/* IBM SAN Volume Controller */
@@ -513,7 +475,6 @@ static struct hwentry default_hw[] = {
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
.prio_name = PRIO_ALUA,
- .prio_args = NULL,
},
{
/* IBM S/390 ECKD DASD */
@@ -526,7 +487,6 @@ static struct hwentry default_hw[] = {
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
- .prio_args = NULL,
},
{
/* IBM S/390 FBA DASD */
@@ -539,7 +499,6 @@ static struct hwentry default_hw[] = {
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
- .prio_args = NULL,
},
{
/* IBM IPR */
@@ -552,7 +511,6 @@ static struct hwentry default_hw[] = {
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
.prio_name = PRIO_ALUA,
- .prio_args = NULL,
},
{
/* IBM RSSM */
@@ -564,7 +522,6 @@ static struct hwentry default_hw[] = {
.no_path_retry = NO_PATH_RETRY_QUEUE,
.minio = 100,
.prio_name = PRIO_ALUA,
- .prio_args = NULL,
},
{
/* IBM XIV Storage System */
@@ -576,7 +533,6 @@ static struct hwentry default_hw[] = {
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
.minio = 15,
- .prio_args = NULL,
},
/*
* IBM Power Virtual SCSI Devices
@@ -592,7 +548,6 @@ static struct hwentry default_hw[] = {
.pgfailback = -FAILBACK_IMMEDIATE,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = (300 / DEFAULT_CHECKINT),
- .prio_args = NULL,
},
{
/* IBM 3303 NVDISK */
@@ -602,7 +557,6 @@ static struct hwentry default_hw[] = {
.pgfailback = -FAILBACK_IMMEDIATE,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = (300 / DEFAULT_CHECKINT),
- .prio_args = NULL,
},
{
/* AIX NVDISK */
@@ -614,7 +568,6 @@ static struct hwentry default_hw[] = {
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = (300 / DEFAULT_CHECKINT),
.prio_name = PRIO_ALUA,
- .prio_args = NULL,
},
/*
* DELL
@@ -632,7 +585,6 @@ static struct hwentry default_hw[] = {
.no_path_retry = 15,
.checker_name = RDAC,
.prio_name = PRIO_RDAC,
- .prio_args = NULL,
},
{
/* DELL MD32xx/MD36xx */
@@ -647,7 +599,6 @@ static struct hwentry default_hw[] = {
.no_path_retry = 15,
.checker_name = RDAC,
.prio_name = PRIO_RDAC,
- .prio_args = NULL,
},
{
/* DELL MD34xx/MD38xx */
@@ -662,7 +613,6 @@ static struct hwentry default_hw[] = {
.no_path_retry = 15,
.checker_name = RDAC,
.prio_name = PRIO_RDAC,
- .prio_args = NULL,
},
/*
* NETAPP ONTAP family
@@ -682,7 +632,6 @@ static struct hwentry default_hw[] = {
.minio = 128,
.dev_loss = MAX_DEV_LOSS_TMO,
.prio_name = PRIO_ONTAP,
- .prio_args = NULL,
.retain_hwhandler = RETAIN_HWHANDLER_ON,
.detect_prio = DETECT_PRIO_ON,
},
@@ -697,7 +646,6 @@ static struct hwentry default_hw[] = {
.no_path_retry = NO_PATH_RETRY_UNDEF,
.minio = 128,
.prio_name = PRIO_ONTAP,
- .prio_args = NULL,
},
/*
* NEXENTA
@@ -714,7 +662,6 @@ static struct hwentry default_hw[] = {
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = 30,
.minio = 128,
- .prio_args = NULL,
},
/*
* Pillar Data/Oracle
@@ -730,7 +677,6 @@ static struct hwentry default_hw[] = {
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
.prio_name = PRIO_ALUA,
- .prio_args = NULL,
},
/*
* SGI
@@ -742,7 +688,6 @@ static struct hwentry default_hw[] = {
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
- .prio_args = NULL,
},
{
.vendor = "SGI",
@@ -755,7 +700,6 @@ static struct hwentry default_hw[] = {
.no_path_retry = NO_PATH_RETRY_QUEUE,
.checker_name = RDAC,
.prio_name = PRIO_RDAC,
- .prio_args = NULL,
},
{
.vendor = "SGI",
@@ -769,7 +713,6 @@ static struct hwentry default_hw[] = {
.no_path_retry = 15,
.checker_name = RDAC,
.prio_name = PRIO_RDAC,
- .prio_args = NULL,
},
/*
* NEC
@@ -784,7 +727,6 @@ static struct hwentry default_hw[] = {
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
.prio_name = PRIO_ALUA,
- .prio_args = NULL,
},
/*
* STK/Oracle
@@ -800,7 +742,6 @@ static struct hwentry default_hw[] = {
.no_path_retry = NO_PATH_RETRY_UNDEF,
.checker_name = RDAC,
.prio_name = PRIO_RDAC,
- .prio_args = NULL,
},
/*
* SUN/Oracle
@@ -812,7 +753,6 @@ static struct hwentry default_hw[] = {
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
- .prio_args = NULL,
},
{
.vendor = "SUN",
@@ -825,7 +765,6 @@ static struct hwentry default_hw[] = {
.no_path_retry = NO_PATH_RETRY_UNDEF,
.checker_name = RDAC,
.prio_name = PRIO_RDAC,
- .prio_args = NULL,
},
{
.vendor = "EUROLOGC",
@@ -834,7 +773,6 @@ static struct hwentry default_hw[] = {
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
- .prio_args = NULL,
},
/*
* Pivot3
@@ -851,7 +789,6 @@ static struct hwentry default_hw[] = {
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_UNDEF,
.minio = 100,
- .prio_args = NULL,
},
{
.vendor = "SUN",
@@ -864,7 +801,6 @@ static struct hwentry default_hw[] = {
.no_path_retry = NO_PATH_RETRY_QUEUE,
.checker_name = RDAC,
.prio_name = PRIO_RDAC,
- .prio_args = NULL,
},
/* SUN/LSI 2510, 2540, 2530, 2540 */
{
@@ -878,7 +814,6 @@ static struct hwentry default_hw[] = {
.no_path_retry = NO_PATH_RETRY_QUEUE,
.checker_name = RDAC,
.prio_name = PRIO_RDAC,
- .prio_args = NULL,
},
/* StorageTek 6180 */
{
@@ -910,7 +845,6 @@ static struct hwentry default_hw[] = {
.no_path_retry = 30,
.checker_name = RDAC,
.prio_name = PRIO_RDAC,
- .prio_args = NULL,
.detect_prio = DETECT_PRIO_ON,
.retain_hwhandler = RETAIN_HWHANDLER_ON,
},
@@ -925,7 +859,6 @@ static struct hwentry default_hw[] = {
.no_path_retry = NO_PATH_RETRY_QUEUE,
.checker_name = RDAC,
.prio_name = PRIO_RDAC,
- .prio_args = NULL,
},
{
.vendor = "Intel",
@@ -936,7 +869,6 @@ static struct hwentry default_hw[] = {
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_QUEUE,
.prio_name = PRIO_ALUA,
- .prio_args = NULL,
},
{
.vendor = "(LIO-ORG|SUSE)",
@@ -948,7 +880,6 @@ static struct hwentry default_hw[] = {
.no_path_retry = 12,
.minio = 100,
.prio_name = PRIO_ALUA,
- .prio_args = NULL,
},
{
.vendor = "DataCore",
@@ -958,7 +889,6 @@ static struct hwentry default_hw[] = {
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_QUEUE,
.prio_name = PRIO_ALUA,
- .prio_args = NULL,
},
{
.vendor = "DataCore",
@@ -968,7 +898,6 @@ static struct hwentry default_hw[] = {
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = NO_PATH_RETRY_QUEUE,
.prio_name = PRIO_ALUA,
- .prio_args = NULL,
},
{
.vendor = "PURE",
@@ -979,7 +908,6 @@ static struct hwentry default_hw[] = {
.fast_io_fail = 10,
.no_path_retry = 0,
.dev_loss = 60,
- .prio_args = NULL,
},
{
.vendor = "HUAWEI",
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH 3/6] multipath-tools: delete no_path_retry attribute when it is equal to default value
2016-07-08 23:58 [PATCH 0/6] Delete attributes with default values Xose Vazquez Perez
2016-07-08 23:58 ` [PATCH 1/6] multipath-tools: delete attributes with DEFAULT_* values in hwtable.c Xose Vazquez Perez
2016-07-08 23:58 ` [PATCH 2/6] multipath-tools: delete prio_args attribute when it is equal to default value Xose Vazquez Perez
@ 2016-07-08 23:58 ` Xose Vazquez Perez
2016-07-08 23:58 ` [PATCH 4/6] multipath-tools: delete minio_rq " Xose Vazquez Perez
` (3 subsequent siblings)
6 siblings, 0 replies; 13+ messages in thread
From: Xose Vazquez Perez @ 2016-07-08 23:58 UTC (permalink / raw)
Cc: device-mapper development, Xose Vazquez Perez
28 .no_path_retry = NO_PATH_RETRY_UNDEF,
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
libmultipath/hwtable.c | 28 ----------------------------
1 file changed, 28 deletions(-)
diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 8b742f4..efc1759 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -45,7 +45,6 @@ static struct hwentry default_hw[] = {
.pgpolicy = MULTIBUS,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
- .no_path_retry = NO_PATH_RETRY_UNDEF,
},
/*
* StorageWorks/HPE
@@ -56,7 +55,6 @@ static struct hwentry default_hw[] = {
.pgpolicy = MULTIBUS,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
- .no_path_retry = NO_PATH_RETRY_UNDEF,
},
{
.vendor = "DEC",
@@ -66,7 +64,6 @@ static struct hwentry default_hw[] = {
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
- .no_path_retry = NO_PATH_RETRY_UNDEF,
.checker_name = HP_SW,
.prio_name = PRIO_HP_SW,
},
@@ -187,7 +184,6 @@ static struct hwentry default_hw[] = {
.pgpolicy = MULTIBUS,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
- .no_path_retry = NO_PATH_RETRY_UNDEF,
},
/*
* EMC/DELL
@@ -245,7 +241,6 @@ static struct hwentry default_hw[] = {
.pgpolicy = GROUP_BY_SERIAL,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
- .no_path_retry = NO_PATH_RETRY_UNDEF,
},
{
.vendor = "FUJITSU",
@@ -269,7 +264,6 @@ static struct hwentry default_hw[] = {
.pgpolicy = MULTIBUS,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
- .no_path_retry = NO_PATH_RETRY_UNDEF,
},
{
.vendor = "HITACHI",
@@ -278,7 +272,6 @@ static struct hwentry default_hw[] = {
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
.rr_weight = RR_WEIGHT_NONE,
- .no_path_retry = NO_PATH_RETRY_UNDEF,
.prio_name = PRIO_HDS,
},
/*
@@ -293,7 +286,6 @@ static struct hwentry default_hw[] = {
.pgpolicy = MULTIBUS,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
- .no_path_retry = NO_PATH_RETRY_UNDEF,
},
{
/* IBM FAStT 1722-600 */
@@ -422,7 +414,6 @@ static struct hwentry default_hw[] = {
.pgpolicy = GROUP_BY_SERIAL,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
- .no_path_retry = NO_PATH_RETRY_UNDEF,
},
{
/* IBM ESS F20 aka Shark */
@@ -432,7 +423,6 @@ static struct hwentry default_hw[] = {
.pgpolicy = GROUP_BY_SERIAL,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
- .no_path_retry = NO_PATH_RETRY_UNDEF,
},
{
/* IBM ESS F20 aka Shark */
@@ -442,7 +432,6 @@ static struct hwentry default_hw[] = {
.pgpolicy = GROUP_BY_SERIAL,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
- .no_path_retry = NO_PATH_RETRY_UNDEF,
},
{
/* IBM DS6000 */
@@ -452,7 +441,6 @@ static struct hwentry default_hw[] = {
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
.rr_weight = RR_WEIGHT_NONE,
- .no_path_retry = NO_PATH_RETRY_UNDEF,
.prio_name = PRIO_ALUA,
},
{
@@ -463,7 +451,6 @@ static struct hwentry default_hw[] = {
.pgpolicy = MULTIBUS,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
- .no_path_retry = NO_PATH_RETRY_UNDEF,
},
{
/* IBM SAN Volume Controller */
@@ -473,7 +460,6 @@ static struct hwentry default_hw[] = {
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
.rr_weight = RR_WEIGHT_NONE,
- .no_path_retry = NO_PATH_RETRY_UNDEF,
.prio_name = PRIO_ALUA,
},
{
@@ -486,7 +472,6 @@ static struct hwentry default_hw[] = {
.pgpolicy = MULTIBUS,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
- .no_path_retry = NO_PATH_RETRY_UNDEF,
},
{
/* IBM S/390 FBA DASD */
@@ -498,7 +483,6 @@ static struct hwentry default_hw[] = {
.pgpolicy = MULTIBUS,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
- .no_path_retry = NO_PATH_RETRY_UNDEF,
},
{
/* IBM IPR */
@@ -509,7 +493,6 @@ static struct hwentry default_hw[] = {
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
.rr_weight = RR_WEIGHT_NONE,
- .no_path_retry = NO_PATH_RETRY_UNDEF,
.prio_name = PRIO_ALUA,
},
{
@@ -531,7 +514,6 @@ static struct hwentry default_hw[] = {
.pgpolicy = MULTIBUS,
.pgfailback = 15,
.rr_weight = RR_WEIGHT_NONE,
- .no_path_retry = NO_PATH_RETRY_UNDEF,
.minio = 15,
},
/*
@@ -628,7 +610,6 @@ static struct hwentry default_hw[] = {
.pgfailback = -FAILBACK_IMMEDIATE,
.flush_on_last_del = FLUSH_ENABLED,
.rr_weight = RR_WEIGHT_NONE,
- .no_path_retry = NO_PATH_RETRY_UNDEF,
.minio = 128,
.dev_loss = MAX_DEV_LOSS_TMO,
.prio_name = PRIO_ONTAP,
@@ -643,7 +624,6 @@ static struct hwentry default_hw[] = {
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
.rr_weight = RR_WEIGHT_NONE,
- .no_path_retry = NO_PATH_RETRY_UNDEF,
.minio = 128,
.prio_name = PRIO_ONTAP,
},
@@ -675,7 +655,6 @@ static struct hwentry default_hw[] = {
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
- .no_path_retry = NO_PATH_RETRY_UNDEF,
.prio_name = PRIO_ALUA,
},
/*
@@ -687,7 +666,6 @@ static struct hwentry default_hw[] = {
.pgpolicy = MULTIBUS,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
- .no_path_retry = NO_PATH_RETRY_UNDEF,
},
{
.vendor = "SGI",
@@ -725,7 +703,6 @@ static struct hwentry default_hw[] = {
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
.rr_weight = RR_WEIGHT_NONE,
- .no_path_retry = NO_PATH_RETRY_UNDEF,
.prio_name = PRIO_ALUA,
},
/*
@@ -739,7 +716,6 @@ static struct hwentry default_hw[] = {
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
.rr_weight = RR_WEIGHT_NONE,
- .no_path_retry = NO_PATH_RETRY_UNDEF,
.checker_name = RDAC,
.prio_name = PRIO_RDAC,
},
@@ -752,7 +728,6 @@ static struct hwentry default_hw[] = {
.pgpolicy = MULTIBUS,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
- .no_path_retry = NO_PATH_RETRY_UNDEF,
},
{
.vendor = "SUN",
@@ -762,7 +737,6 @@ static struct hwentry default_hw[] = {
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = -FAILBACK_IMMEDIATE,
.rr_weight = RR_WEIGHT_NONE,
- .no_path_retry = NO_PATH_RETRY_UNDEF,
.checker_name = RDAC,
.prio_name = PRIO_RDAC,
},
@@ -772,7 +746,6 @@ static struct hwentry default_hw[] = {
.pgpolicy = GROUP_BY_PRIO,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
- .no_path_retry = NO_PATH_RETRY_UNDEF,
},
/*
* Pivot3
@@ -787,7 +760,6 @@ static struct hwentry default_hw[] = {
.pgpolicy = MULTIBUS,
.pgfailback = FAILBACK_UNDEF,
.rr_weight = RR_WEIGHT_NONE,
- .no_path_retry = NO_PATH_RETRY_UNDEF,
.minio = 100,
},
{
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH 4/6] multipath-tools: delete minio_rq attribute when it is equal to default value
2016-07-08 23:58 [PATCH 0/6] Delete attributes with default values Xose Vazquez Perez
` (2 preceding siblings ...)
2016-07-08 23:58 ` [PATCH 3/6] multipath-tools: delete no_path_retry " Xose Vazquez Perez
@ 2016-07-08 23:58 ` Xose Vazquez Perez
2016-07-08 23:58 ` [PATCH 5/6] multipath-tools: delete fast_io_fail " Xose Vazquez Perez
` (2 subsequent siblings)
6 siblings, 0 replies; 13+ messages in thread
From: Xose Vazquez Perez @ 2016-07-08 23:58 UTC (permalink / raw)
Cc: device-mapper development, Xose Vazquez Perez
1 .minio_rq = 1,
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
libmultipath/hwtable.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index efc1759..d3be19a 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -914,7 +914,6 @@ static struct hwentry default_hw[] = {
.pgfailback = 30,
.rr_weight = RR_WEIGHT_PRIO,
.no_path_retry = NO_PATH_RETRY_FAIL,
- .minio_rq = 1,
.flush_on_last_del = FLUSH_ENABLED,
.fast_io_fail = 5,
.dev_loss = 30,
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH 5/6] multipath-tools: delete fast_io_fail attribute when it is equal to default value
2016-07-08 23:58 [PATCH 0/6] Delete attributes with default values Xose Vazquez Perez
` (3 preceding siblings ...)
2016-07-08 23:58 ` [PATCH 4/6] multipath-tools: delete minio_rq " Xose Vazquez Perez
@ 2016-07-08 23:58 ` Xose Vazquez Perez
2016-07-08 23:58 ` [PATCH 6/6] multipath-tools: delete pgpolicy " Xose Vazquez Perez
2016-07-09 8:17 ` [PATCH 0/6] Delete attributes with default values Christophe Varoqui
6 siblings, 0 replies; 13+ messages in thread
From: Xose Vazquez Perez @ 2016-07-08 23:58 UTC (permalink / raw)
Cc: device-mapper development, Xose Vazquez Perez
2 .fast_io_fail = 5,
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
libmultipath/hwtable.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index d3be19a..0f52761 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -230,7 +230,6 @@ static struct hwentry default_hw[] = {
.selector = "queue-length 0",
.pgpolicy = MULTIBUS,
.pgfailback = FAILBACK_UNDEF,
- .fast_io_fail = 5,
},
/*
* Fujitsu
@@ -915,7 +914,6 @@ static struct hwentry default_hw[] = {
.rr_weight = RR_WEIGHT_PRIO,
.no_path_retry = NO_PATH_RETRY_FAIL,
.flush_on_last_del = FLUSH_ENABLED,
- .fast_io_fail = 5,
.dev_loss = 30,
},
/*
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH 6/6] multipath-tools: delete pgpolicy attribute when it is equal to default value
2016-07-08 23:58 [PATCH 0/6] Delete attributes with default values Xose Vazquez Perez
` (4 preceding siblings ...)
2016-07-08 23:58 ` [PATCH 5/6] multipath-tools: delete fast_io_fail " Xose Vazquez Perez
@ 2016-07-08 23:58 ` Xose Vazquez Perez
2016-07-09 8:17 ` [PATCH 0/6] Delete attributes with default values Christophe Varoqui
6 siblings, 0 replies; 13+ messages in thread
From: Xose Vazquez Perez @ 2016-07-08 23:58 UTC (permalink / raw)
Cc: device-mapper development, Xose Vazquez Perez
1 .pgpolicy = FAILOVER,
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
libmultipath/hwtable.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 0f52761..e5c3fef 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -534,7 +534,6 @@ static struct hwentry default_hw[] = {
/* IBM 3303 NVDISK */
.vendor = "IBM",
.product = "3303 NVDISK",
- .pgpolicy = FAILOVER,
.pgfailback = -FAILBACK_IMMEDIATE,
.rr_weight = RR_WEIGHT_NONE,
.no_path_retry = (300 / DEFAULT_CHECKINT),
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 0/6] Delete attributes with default values
2016-07-08 23:58 [PATCH 0/6] Delete attributes with default values Xose Vazquez Perez
` (5 preceding siblings ...)
2016-07-08 23:58 ` [PATCH 6/6] multipath-tools: delete pgpolicy " Xose Vazquez Perez
@ 2016-07-09 8:17 ` Christophe Varoqui
2016-07-10 15:54 ` Xose Vazquez Perez
` (2 more replies)
6 siblings, 3 replies; 13+ messages in thread
From: Christophe Varoqui @ 2016-07-09 8:17 UTC (permalink / raw)
To: Xose Vazquez Perez; +Cc: device-mapper development
[-- Attachment #1.1: Type: text/plain, Size: 1410 bytes --]
I'll wait for comments from distribution maintainers on this patchset.
Because, though we have already deleted the checker_name settings when
equal to the default value, it should be clear that with this patchset
changing a default may cause re-certification for all impacted devices.
This can be viewed as a problem for distributors.
Hannes, Ben, do you ack this patchset ? If not, what do we do the
checker_name settings, that I understood Hannes wanted to switch to TUR
anyway.
On Sat, Jul 9, 2016 at 1:58 AM, Xose Vazquez Perez <xose.vazquez@gmail.com>
wrote:
> Xose Vazquez Perez (6):
> multipath-tools: delete attributes with DEFAULT_* values in hwtable.c
> multipath-tools: delete prio_args attribute when it is equal to default
> value
> multipath-tools: delete no_path_retry attribute when it is equal to
> default value
> multipath-tools: delete minio_rq attribute when it is equal to default
> value
> multipath-tools: delete fast_io_fail attribute when it is equal to
> default value
> multipath-tools: delete pgpolicy attribute when it is equal to default
> value
>
> libmultipath/hwtable.c | 226
> -------------------------------------------------
> 1 file changed, 226 deletions(-)
>
> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> Cc: device-mapper development <dm-devel@redhat.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
>
> --
> 2.7.4
>
>
[-- Attachment #1.2: Type: text/html, Size: 1980 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 0/6] Delete attributes with default values
2016-07-09 8:17 ` [PATCH 0/6] Delete attributes with default values Christophe Varoqui
@ 2016-07-10 15:54 ` Xose Vazquez Perez
2016-07-11 14:33 ` Hannes Reinecke
2016-07-13 16:17 ` Benjamin Marzinski
2 siblings, 0 replies; 13+ messages in thread
From: Xose Vazquez Perez @ 2016-07-10 15:54 UTC (permalink / raw)
To: Christophe Varoqui, Hannes Reinecke, Benjamin Marzinski,
device-mapper development
On 07/09/2016 10:17 AM, Christophe Varoqui wrote:
> I'll wait for comments from distribution maintainers on this patchset.
> Because, though we have already deleted the checker_name settings when equal
> to the default value, it should be clear that with this patchset changing a
> default may cause re-certification for all impacted devices. This can be
> viewed as a problem for distributors.
In general terms arrays manufacturers only test, certify and write documentation
for enterprise distributions. They don't care about upstream kernel or
upstream multipath-tools.
And enterprise distributions usually carry very outdated and heavily patched
packages. The next enterprise distributions are, at least, two years away.
Let's see the patches:
> multipath-tools: delete attributes with DEFAULT_* values in hwtable.c
This patch deletes:
48 .features = DEFAULT_FEATURES,
44 .hwhandler = DEFAULT_HWHANDLER,
28 .prio_name = DEFAULT_PRIO,
1 .minio = DEFAULT_MINIO,
1 .minio_rq = DEFAULT_MINIO_RQ,
- DEFAULT_FEATURES is "0"
It has to be explicitly defined, no default value possible.
- DEFAULT_HWHANDLER is "unset/0"
Always it's Hardware-dependent, no default value possible.
- DEFAULT_PRIO is "const"
All others alternatives are Hardware-dependent or an unusual option(random/weightedpath/datacore/iet).
- DEFAULT_MINIO is 1000
Relevant for hardware? Is default value right?
- DEFAULT_MINIO_RQ is 1
Hardware-dependent related? Is default value right?
> multipath-tools: delete prio_args attribute when it is equal to default value
This patch deletes:
73 .prio_args = NULL,
- DEFAULT_PRIO_ARGS is ""
It has to be explicitly defined, no default value possible.
> multipath-tools: delete no_path_retry attribute when it is equal to default value
This patch deletes:
28 .no_path_retry = NO_PATH_RETRY_UNDEF,
- DEFAULT_NO_PATH_RETRY is 0/unset
Perhaps this default value could be changed in the future. ???
The current hwtable is full with some "random" values:
28 .no_path_retry = NO_PATH_RETRY_UNDEF,
15 .no_path_retry = NO_PATH_RETRY_QUEUE,
7 .no_path_retry = 12,
5 .no_path_retry = 15,
4 .no_path_retry = (300 / DEFAULT_CHECKINT),
4 .no_path_retry = 300,
4 .no_path_retry = 18,
2 .no_path_retry = 30,
2 .no_path_retry = 10,
1 .no_path_retry = NO_PATH_RETRY_FAIL,
1 .no_path_retry = 6,
1 .no_path_retry = 5,
Is no_path_retry really Hardware-dependent? or were values selected arbitrarily?
Were they tested with upstream kernel/multipath-tools? Any logic here?
> multipath-tools: delete minio_rq attribute when it is equal to default value
This patch deletes:
1 .minio_rq = 1,
Duplicate, see above.
> multipath-tools: delete fast_io_fail attribute when it is equal to default value
This patch deletes:
2 .fast_io_fail = 5,
- DEFAULT_FAST_IO_FAIL is 5
Perhaps this default value could be changed in the future. ???
At hwtable there are only 3 defined:
2 .fast_io_fail = 5,
1 .fast_io_fail = 10,
Again, Hardware-dependent? or crystal ball? Is default value good enough?
> multipath-tools: delete pgpolicy attribute when it is equal to default value
This patch deletes:
1 .pgpolicy = FAILOVER,
- DEFAULT_PGPOLICY is FAILOVER
At hwtable:
48 .pgpolicy = GROUP_BY_PRIO,
23 .pgpolicy = MULTIBUS,
5 .pgpolicy = GROUP_BY_SERIAL,
1 .pgpolicy = FAILOVER,
FAILOVER(DEFAULT_PGPOLICY) is not very popular. Maybe it should be changed to
GROUP_BY_PRIO and then remove 48 lines.
Right now there is not a well defined policy. What should be the default rule?
(a) a *mininal* "devices section": only hardware-dependent, stability or
high-performance related attributes are allowed.
(b) a *fully detailed* "devices section", all attributes defined.
(c) *no rules* at "devices section", do what you want.
Now it's (c), should it be changed?
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 0/6] Delete attributes with default values
2016-07-09 8:17 ` [PATCH 0/6] Delete attributes with default values Christophe Varoqui
2016-07-10 15:54 ` Xose Vazquez Perez
@ 2016-07-11 14:33 ` Hannes Reinecke
2016-07-13 16:17 ` Benjamin Marzinski
2 siblings, 0 replies; 13+ messages in thread
From: Hannes Reinecke @ 2016-07-11 14:33 UTC (permalink / raw)
To: dm-devel
On 07/09/2016 10:17 AM, Christophe Varoqui wrote:
> I'll wait for comments from distribution maintainers on this patchset.
>
> Because, though we have already deleted the checker_name settings when
> equal to the default value, it should be clear that with this patchset
> changing a default may cause re-certification for all impacted devices.
> This can be viewed as a problem for distributors.
>
> Hannes, Ben, do you ack this patchset ? If not, what do we do the
> checker_name settings, that I understood Hannes wanted to switch to TUR
> anyway.
>
That is fine. Eliminating the default values shouldn't cause any issues
with us.
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 0/6] Delete attributes with default values
2016-07-09 8:17 ` [PATCH 0/6] Delete attributes with default values Christophe Varoqui
2016-07-10 15:54 ` Xose Vazquez Perez
2016-07-11 14:33 ` Hannes Reinecke
@ 2016-07-13 16:17 ` Benjamin Marzinski
2016-07-22 9:52 ` Christophe Varoqui
2 siblings, 1 reply; 13+ messages in thread
From: Benjamin Marzinski @ 2016-07-13 16:17 UTC (permalink / raw)
To: Christophe Varoqui; +Cc: device-mapper development, Xose Vazquez Perez
On Sat, Jul 09, 2016 at 10:17:05AM +0200, Christophe Varoqui wrote:
> I'll wait for comments from distribution maintainers on this patchset.
> Because, though we have already deleted the checker_name settings when
> equal to the default value, it should be clear that with this patchset
> changing a default may cause re-certification for all impacted devices.
> This can be viewed as a problem for distributors.
> Hannes, Ben, do you ack this patchset ? If not, what do we do the
> checker_name settings, that I understood Hannes wanted to switch to TUR
> anyway.
I'm fine with this.
-Ben
> On Sat, Jul 9, 2016 at 1:58 AM, Xose Vazquez Perez
> <[1]xose.vazquez@gmail.com> wrote:
>
> Xose Vazquez Perez (6):
> multipath-tools: delete attributes with DEFAULT_* values in hwtable.c
> multipath-tools: delete prio_args attribute when it is equal to
> default value
> multipath-tools: delete no_path_retry attribute when it is equal to
> default value
> multipath-tools: delete minio_rq attribute when it is equal to default
> value
> multipath-tools: delete fast_io_fail attribute when it is equal to
> default value
> multipath-tools: delete pgpolicy attribute when it is equal to default
> value
>
> libmultipath/hwtable.c | 226
> -------------------------------------------------
> 1 file changed, 226 deletions(-)
>
> Cc: Christophe Varoqui <[2]christophe.varoqui@opensvc.com>
> Cc: device-mapper development <[3]dm-devel@redhat.com>
> Signed-off-by: Xose Vazquez Perez <[4]xose.vazquez@gmail.com>
>
> --
> 2.7.4
>
> References
>
> Visible links
> 1. mailto:xose.vazquez@gmail.com
> 2. mailto:christophe.varoqui@opensvc.com
> 3. mailto:dm-devel@redhat.com
> 4. mailto:xose.vazquez@gmail.com
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 0/6] Delete attributes with default values
2016-07-13 16:17 ` Benjamin Marzinski
@ 2016-07-22 9:52 ` Christophe Varoqui
0 siblings, 0 replies; 13+ messages in thread
From: Christophe Varoqui @ 2016-07-22 9:52 UTC (permalink / raw)
To: Benjamin Marzinski; +Cc: device-mapper development, Xose Vazquez Perez
[-- Attachment #1.1: Type: text/plain, Size: 2314 bytes --]
Ok.
All defaults settings tweaks and removal patches from Xosé are merged.
Thanks.
On Wed, Jul 13, 2016 at 6:17 PM, Benjamin Marzinski <bmarzins@redhat.com>
wrote:
> On Sat, Jul 09, 2016 at 10:17:05AM +0200, Christophe Varoqui wrote:
> > I'll wait for comments from distribution maintainers on this patchset.
> > Because, though we have already deleted the checker_name settings when
> > equal to the default value, it should be clear that with this patchset
> > changing a default may cause re-certification for all impacted
> devices.
> > This can be viewed as a problem for distributors.
> > Hannes, Ben, do you ack this patchset ? If not, what do we do the
> > checker_name settings, that I understood Hannes wanted to switch to
> TUR
> > anyway.
>
> I'm fine with this.
>
> -Ben
>
> > On Sat, Jul 9, 2016 at 1:58 AM, Xose Vazquez Perez
> > <[1]xose.vazquez@gmail.com> wrote:
> >
> > Xose Vazquez Perez (6):
> > multipath-tools: delete attributes with DEFAULT_* values in
> hwtable.c
> > multipath-tools: delete prio_args attribute when it is equal to
> > default value
> > multipath-tools: delete no_path_retry attribute when it is equal
> to
> > default value
> > multipath-tools: delete minio_rq attribute when it is equal to
> default
> > value
> > multipath-tools: delete fast_io_fail attribute when it is equal to
> > default value
> > multipath-tools: delete pgpolicy attribute when it is equal to
> default
> > value
> >
> > libmultipath/hwtable.c | 226
> > -------------------------------------------------
> > 1 file changed, 226 deletions(-)
> >
> > Cc: Christophe Varoqui <[2]christophe.varoqui@opensvc.com>
> > Cc: device-mapper development <[3]dm-devel@redhat.com>
> > Signed-off-by: Xose Vazquez Perez <[4]xose.vazquez@gmail.com>
> >
> > --
> > 2.7.4
> >
> > References
> >
> > Visible links
> > 1. mailto:xose.vazquez@gmail.com
> > 2. mailto:christophe.varoqui@opensvc.com
> > 3. mailto:dm-devel@redhat.com
> > 4. mailto:xose.vazquez@gmail.com
>
> > --
> > dm-devel mailing list
> > dm-devel@redhat.com
> > https://www.redhat.com/mailman/listinfo/dm-devel
>
>
[-- Attachment #1.2: Type: text/html, Size: 3624 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread