* [[PATCH][yocto-autobuilder] 1/2] buildbot/steps/transfer.py: Fix typo in DirectoryDownload step. @ 2016-07-11 21:37 Aníbal Limón 2016-07-11 21:37 ` [[PATCH][yocto-autobuilder] 2/2] buildsteps/RunOeSelftest.py: Set native_lsb to universal Aníbal Limón 2016-07-13 15:19 ` [[PATCH][yocto-autobuilder] 1/2] buildbot/steps/transfer.py: Fix typo in DirectoryDownload step Joshua G Lock 0 siblings, 2 replies; 7+ messages in thread From: Aníbal Limón @ 2016-07-11 21:37 UTC (permalink / raw) To: yocto DirectoryDownload step is based on UploadDirectory and i miss to upgrade the error log when the buildslave don't support downloadDirectory previously said uploadDirectory. Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com> --- .../site-packages/buildbot-0.8.8-py2.7.egg/buildbot/steps/transfer.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/python2.7/site-packages/buildbot-0.8.8-py2.7.egg/buildbot/steps/transfer.py b/lib/python2.7/site-packages/buildbot-0.8.8-py2.7.egg/buildbot/steps/transfer.py index fb49597..a2f7007 100644 --- a/lib/python2.7/site-packages/buildbot-0.8.8-py2.7.egg/buildbot/steps/transfer.py +++ b/lib/python2.7/site-packages/buildbot-0.8.8-py2.7.egg/buildbot/steps/transfer.py @@ -487,7 +487,7 @@ class DirectoryDownload(_TransferBuildStep): version = self.slaveVersion("downloadDirectory") if not version: - m = "slave is too old, does not know about uploadDirectory" + m = "slave is too old, does not know about downloadDirectory" raise BuildSlaveTooOldError(m) # we rely upon the fact that the buildmaster runs chdir'ed into its -- 2.1.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [[PATCH][yocto-autobuilder] 2/2] buildsteps/RunOeSelftest.py: Set native_lsb to universal 2016-07-11 21:37 [[PATCH][yocto-autobuilder] 1/2] buildbot/steps/transfer.py: Fix typo in DirectoryDownload step Aníbal Limón @ 2016-07-11 21:37 ` Aníbal Limón 2016-07-12 16:09 ` Joshua G Lock 2016-07-13 15:19 ` [[PATCH][yocto-autobuilder] 1/2] buildbot/steps/transfer.py: Fix typo in DirectoryDownload step Joshua G Lock 1 sibling, 1 reply; 7+ messages in thread From: Aníbal Limón @ 2016-07-11 21:37 UTC (permalink / raw) To: yocto The error report is generated into AB master and currently we don't have a method to get AB worker distro, so set to universal. Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com> --- lib/python2.7/site-packages/autobuilder/buildsteps/RunOeSelftest.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/python2.7/site-packages/autobuilder/buildsteps/RunOeSelftest.py b/lib/python2.7/site-packages/autobuilder/buildsteps/RunOeSelftest.py index 5b9e408..809bcc3 100644 --- a/lib/python2.7/site-packages/autobuilder/buildsteps/RunOeSelftest.py +++ b/lib/python2.7/site-packages/autobuilder/buildsteps/RunOeSelftest.py @@ -52,7 +52,9 @@ class RunOeSelftest(ShellCommand): report['machine'] = 'universal' report['build_sys'] = "%s-%s" % (platform.machine(), platform.system().lower()) - report['nativelsb'] = get_lsb_distro() or 'universal' + # XXX: Set to universal because isn't easy to get Autobuilder + # worker distro. + report['nativelsb'] = 'universal' report['distro'] = 'universal' report['target_sys'] = 'universal' -- 2.1.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [[PATCH][yocto-autobuilder] 2/2] buildsteps/RunOeSelftest.py: Set native_lsb to universal 2016-07-11 21:37 ` [[PATCH][yocto-autobuilder] 2/2] buildsteps/RunOeSelftest.py: Set native_lsb to universal Aníbal Limón @ 2016-07-12 16:09 ` Joshua G Lock 2016-07-12 16:21 ` Aníbal Limón 0 siblings, 1 reply; 7+ messages in thread From: Joshua G Lock @ 2016-07-12 16:09 UTC (permalink / raw) To: Aníbal Limón, yocto On Mon, 2016-07-11 at 16:37 -0500, Aníbal Limón wrote: > The error report is generated into AB master and currently we > don't have a method to get AB worker distro, so set to universal. Can you elaborate a bit here? Why don't we have a method available to get the worker distro? Is it because we don't ensure all of the builders in the cluster include lsb_release? Are our worker distro versions new enough that we can rely on os- release? http://manpages.ubuntu.com/manpages/xenial/en/man5/os-release.5.html Regards, Joshua > > Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com> > --- > lib/python2.7/site-packages/autobuilder/buildsteps/RunOeSelftest.py > | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/lib/python2.7/site- > packages/autobuilder/buildsteps/RunOeSelftest.py > b/lib/python2.7/site-packages/autobuilder/buildsteps/RunOeSelftest.py > index 5b9e408..809bcc3 100644 > --- a/lib/python2.7/site- > packages/autobuilder/buildsteps/RunOeSelftest.py > +++ b/lib/python2.7/site- > packages/autobuilder/buildsteps/RunOeSelftest.py > @@ -52,7 +52,9 @@ class RunOeSelftest(ShellCommand): > report['machine'] = 'universal' > report['build_sys'] = "%s-%s" % (platform.machine(), > platform.system().lower()) > - report['nativelsb'] = get_lsb_distro() or 'universal' > + # XXX: Set to universal because isn't easy to get > Autobuilder > + # worker distro. > + report['nativelsb'] = 'universal' > report['distro'] = 'universal' > report['target_sys'] = 'universal' > > -- > 2.1.4 > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [[PATCH][yocto-autobuilder] 2/2] buildsteps/RunOeSelftest.py: Set native_lsb to universal 2016-07-12 16:09 ` Joshua G Lock @ 2016-07-12 16:21 ` Aníbal Limón 2016-07-13 13:32 ` Joshua G Lock 0 siblings, 1 reply; 7+ messages in thread From: Aníbal Limón @ 2016-07-12 16:21 UTC (permalink / raw) To: Joshua G Lock, yocto [-- Attachment #1: Type: text/plain, Size: 2224 bytes --] On 07/12/2016 11:09 AM, Joshua G Lock wrote: > On Mon, 2016-07-11 at 16:37 -0500, Aníbal Limón wrote: >> The error report is generated into AB master and currently we >> don't have a method to get AB worker distro, so set to universal. > > Can you elaborate a bit here? Why don't we have a method available to > get the worker distro? Is it because we don't ensure all of the > builders in the cluster include lsb_release? Currently, we don't have an easy way to get the worker distro an buildstep is needed in order TODO that but isn't trivial. I propose to have at step at buildinit for get the worker information. At this time only will be distro. I removed the get_lsb_distro() because it gets the distro of the master instead of the worker. I added a bug for this task, https://bugzilla.yoctoproject.org/show_bug.cgi?id=9917 Cheers, alimon > > Are our worker distro versions new enough that we can rely on os- > release? > > http://manpages.ubuntu.com/manpages/xenial/en/man5/os-release.5.html > > Regards, > > Joshua > >> >> Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com> >> --- >> lib/python2.7/site-packages/autobuilder/buildsteps/RunOeSelftest.py >> | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/lib/python2.7/site- >> packages/autobuilder/buildsteps/RunOeSelftest.py >> b/lib/python2.7/site-packages/autobuilder/buildsteps/RunOeSelftest.py >> index 5b9e408..809bcc3 100644 >> --- a/lib/python2.7/site- >> packages/autobuilder/buildsteps/RunOeSelftest.py >> +++ b/lib/python2.7/site- >> packages/autobuilder/buildsteps/RunOeSelftest.py >> @@ -52,7 +52,9 @@ class RunOeSelftest(ShellCommand): >> report['machine'] = 'universal' >> report['build_sys'] = "%s-%s" % (platform.machine(), >> platform.system().lower()) >> - report['nativelsb'] = get_lsb_distro() or 'universal' >> + # XXX: Set to universal because isn't easy to get >> Autobuilder >> + # worker distro. >> + report['nativelsb'] = 'universal' >> report['distro'] = 'universal' >> report['target_sys'] = 'universal' >> >> -- >> 2.1.4 >> [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [[PATCH][yocto-autobuilder] 2/2] buildsteps/RunOeSelftest.py: Set native_lsb to universal 2016-07-12 16:21 ` Aníbal Limón @ 2016-07-13 13:32 ` Joshua G Lock 2016-07-13 15:07 ` Aníbal Limón 0 siblings, 1 reply; 7+ messages in thread From: Joshua G Lock @ 2016-07-13 13:32 UTC (permalink / raw) To: Aníbal Limón, yocto On Tue, 2016-07-12 at 11:21 -0500, Aníbal Limón wrote: > > On 07/12/2016 11:09 AM, Joshua G Lock wrote: > > On Mon, 2016-07-11 at 16:37 -0500, Aníbal Limón wrote: > > > The error report is generated into AB master and currently we > > > don't have a method to get AB worker distro, so set to universal. > > > > Can you elaborate a bit here? Why don't we have a method available > > to > > get the worker distro? Is it because we don't ensure all of the > > builders in the cluster include lsb_release? > > Currently, we don't have an easy way to get the worker distro an > buildstep is needed in order TODO that but isn't trivial. > > I propose to have at step at buildinit for get the worker > information. > At this time only will be distro. I removed the get_lsb_distro() > because > it gets the distro of the master instead of the worker. Could we just extract the value of NATIVELSBSTRING[1] from the build header in the logs? Regards, Joshua 1. http://www.yoctoproject.org/docs/2.1/ref-manual/ref-manual.html#var- NATIVELSBSTRING > > I added a bug for this task, > > https://bugzilla.yoctoproject.org/show_bug.cgi?id=9917 > > Cheers, > alimon > > > > > > Are our worker distro versions new enough that we can rely on os- > > release? > > > > http://manpages.ubuntu.com/manpages/xenial/en/man5/os-release.5.htm > > l > > > > Regards, > > > > Joshua > > > > > > > > Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com> > > > --- > > > lib/python2.7/site- > > > packages/autobuilder/buildsteps/RunOeSelftest.py > > > > 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/lib/python2.7/site- > > > packages/autobuilder/buildsteps/RunOeSelftest.py > > > b/lib/python2.7/site- > > > packages/autobuilder/buildsteps/RunOeSelftest.py > > > index 5b9e408..809bcc3 100644 > > > --- a/lib/python2.7/site- > > > packages/autobuilder/buildsteps/RunOeSelftest.py > > > +++ b/lib/python2.7/site- > > > packages/autobuilder/buildsteps/RunOeSelftest.py > > > @@ -52,7 +52,9 @@ class RunOeSelftest(ShellCommand): > > > report['machine'] = 'universal' > > > report['build_sys'] = "%s-%s" % (platform.machine(), > > > platform.system().lower()) > > > - report['nativelsb'] = get_lsb_distro() or 'universal' > > > + # XXX: Set to universal because isn't easy to get > > > Autobuilder > > > + # worker distro. > > > + report['nativelsb'] = 'universal' > > > report['distro'] = 'universal' > > > report['target_sys'] = 'universal' > > > > > > -- > > > 2.1.4 > > > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [[PATCH][yocto-autobuilder] 2/2] buildsteps/RunOeSelftest.py: Set native_lsb to universal 2016-07-13 13:32 ` Joshua G Lock @ 2016-07-13 15:07 ` Aníbal Limón 0 siblings, 0 replies; 7+ messages in thread From: Aníbal Limón @ 2016-07-13 15:07 UTC (permalink / raw) To: Joshua G Lock, yocto [-- Attachment #1: Type: text/plain, Size: 2964 bytes --] On 07/13/2016 08:32 AM, Joshua G Lock wrote: > On Tue, 2016-07-12 at 11:21 -0500, Aníbal Limón wrote: >> >> On 07/12/2016 11:09 AM, Joshua G Lock wrote: >>> On Mon, 2016-07-11 at 16:37 -0500, Aníbal Limón wrote: >>>> The error report is generated into AB master and currently we >>>> don't have a method to get AB worker distro, so set to universal. >>> >>> Can you elaborate a bit here? Why don't we have a method available >>> to >>> get the worker distro? Is it because we don't ensure all of the >>> builders in the cluster include lsb_release? >> >> Currently, we don't have an easy way to get the worker distro an >> buildstep is needed in order TODO that but isn't trivial. >> >> I propose to have at step at buildinit for get the worker >> information. >> At this time only will be distro. I removed the get_lsb_distro() >> because >> it gets the distro of the master instead of the worker. > > Could we just extract the value of NATIVELSBSTRING[1] from the build > header in the logs? I use this value in the BuildImages steps because bitbake builds an image an print that information but for the oe-selftest isn't available because it executes a different tests suites maybe or not using bitbake. alimon > > Regards, > > Joshua > > 1. http://www.yoctoproject.org/docs/2.1/ref-manual/ref-manual.html#var- > NATIVELSBSTRING > >> >> I added a bug for this task, >> >> https://bugzilla.yoctoproject.org/show_bug.cgi?id=9917 >> >> Cheers, >> alimon >> >> >>> >>> Are our worker distro versions new enough that we can rely on os- >>> release? >>> >>> http://manpages.ubuntu.com/manpages/xenial/en/man5/os-release.5.htm >>> l >>> >>> Regards, >>> >>> Joshua >>> >>>> >>>> Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com> >>>> --- >>>> lib/python2.7/site- >>>> packages/autobuilder/buildsteps/RunOeSelftest.py >>>>> 4 +++- >>>> 1 file changed, 3 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/lib/python2.7/site- >>>> packages/autobuilder/buildsteps/RunOeSelftest.py >>>> b/lib/python2.7/site- >>>> packages/autobuilder/buildsteps/RunOeSelftest.py >>>> index 5b9e408..809bcc3 100644 >>>> --- a/lib/python2.7/site- >>>> packages/autobuilder/buildsteps/RunOeSelftest.py >>>> +++ b/lib/python2.7/site- >>>> packages/autobuilder/buildsteps/RunOeSelftest.py >>>> @@ -52,7 +52,9 @@ class RunOeSelftest(ShellCommand): >>>> report['machine'] = 'universal' >>>> report['build_sys'] = "%s-%s" % (platform.machine(), >>>> platform.system().lower()) >>>> - report['nativelsb'] = get_lsb_distro() or 'universal' >>>> + # XXX: Set to universal because isn't easy to get >>>> Autobuilder >>>> + # worker distro. >>>> + report['nativelsb'] = 'universal' >>>> report['distro'] = 'universal' >>>> report['target_sys'] = 'universal' >>>> >>>> -- >>>> 2.1.4 >>>> >> [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [[PATCH][yocto-autobuilder] 1/2] buildbot/steps/transfer.py: Fix typo in DirectoryDownload step. 2016-07-11 21:37 [[PATCH][yocto-autobuilder] 1/2] buildbot/steps/transfer.py: Fix typo in DirectoryDownload step Aníbal Limón 2016-07-11 21:37 ` [[PATCH][yocto-autobuilder] 2/2] buildsteps/RunOeSelftest.py: Set native_lsb to universal Aníbal Limón @ 2016-07-13 15:19 ` Joshua G Lock 1 sibling, 0 replies; 7+ messages in thread From: Joshua G Lock @ 2016-07-13 15:19 UTC (permalink / raw) To: Aníbal Limón, yocto This and the 2/2 have been pushed to master, thanks. Joshua On Mon, 2016-07-11 at 16:37 -0500, Aníbal Limón wrote: > DirectoryDownload step is based on UploadDirectory and i miss > to upgrade the error log when the buildslave don't support > downloadDirectory previously said uploadDirectory. > > Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com> > --- > .../site-packages/buildbot-0.8.8- > py2.7.egg/buildbot/steps/transfer.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/python2.7/site-packages/buildbot-0.8.8- > py2.7.egg/buildbot/steps/transfer.py b/lib/python2.7/site- > packages/buildbot-0.8.8-py2.7.egg/buildbot/steps/transfer.py > index fb49597..a2f7007 100644 > --- a/lib/python2.7/site-packages/buildbot-0.8.8- > py2.7.egg/buildbot/steps/transfer.py > +++ b/lib/python2.7/site-packages/buildbot-0.8.8- > py2.7.egg/buildbot/steps/transfer.py > @@ -487,7 +487,7 @@ class DirectoryDownload(_TransferBuildStep): > version = self.slaveVersion("downloadDirectory") > > if not version: > - m = "slave is too old, does not know about > uploadDirectory" > + m = "slave is too old, does not know about > downloadDirectory" > raise BuildSlaveTooOldError(m) > > # we rely upon the fact that the buildmaster runs chdir'ed > into its > -- > 2.1.4 > ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-07-13 15:20 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-07-11 21:37 [[PATCH][yocto-autobuilder] 1/2] buildbot/steps/transfer.py: Fix typo in DirectoryDownload step Aníbal Limón 2016-07-11 21:37 ` [[PATCH][yocto-autobuilder] 2/2] buildsteps/RunOeSelftest.py: Set native_lsb to universal Aníbal Limón 2016-07-12 16:09 ` Joshua G Lock 2016-07-12 16:21 ` Aníbal Limón 2016-07-13 13:32 ` Joshua G Lock 2016-07-13 15:07 ` Aníbal Limón 2016-07-13 15:19 ` [[PATCH][yocto-autobuilder] 1/2] buildbot/steps/transfer.py: Fix typo in DirectoryDownload step Joshua G Lock
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.