From: sagi@grimberg.me (Sagi Grimberg)
Subject: crash on device removal
Date: Wed, 13 Jul 2016 13:06:01 +0300 [thread overview]
Message-ID: <57861289.5020404@grimberg.me> (raw)
In-Reply-To: <010201d1dc81$9f59cf10$de0d6d30$@opengridcomputing.com>
>> We actually missed a kref_get in nvme_get_ns_from_disk().
>>
>> This should fix it. Could you help to verify?
>>
>> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
>> index 4babdf0..b146f52 100644
>> --- a/drivers/nvme/host/core.c
>> +++ b/drivers/nvme/host/core.c
>> @@ -183,6 +183,8 @@ static struct nvme_ns *nvme_get_ns_from_disk(struct
>> gendisk *disk)
>> }
>> spin_unlock(&dev_list_lock);
>>
>> + kref_get(&ns->ctrl->kref);
>> +
>> return ns;
>>
>> fail_put_ns:
>
> Hey Ming. This avoids the crash in nvme_rdma_free_qe(), but now I see another crash:
>
> [ 975.633436] nvme nvme0: new ctrl: NQN "nqn.2014-08.org.nvmexpress.discovery", addr 10.0.1.14:4420
> [ 978.463636] nvme nvme0: creating 32 I/O queues.
> [ 979.187826] nvme nvme0: new ctrl: NQN "testnqn", addr 10.0.1.14:4420
> [ 987.778287] nvme nvme0: Got rdma device removal event, deleting ctrl
> [ 987.882202] BUG: unable to handle kernel paging request at ffff880e770e01f8
> [ 987.890024] IP: [<ffffffffa03a1a46>] __ib_process_cq+0x46/0xc0 [ib_core]
>
> This looks like another problem with freeing the tag sets before stopping the QP. I thought we fixed that once and for all, but perhaps there is some other path we missed. :(
The fix doesn't look right to me. But I wander how you got this crash
now? if at all, this would delay the controller removal...
WARNING: multiple messages have this Message-ID (diff)
From: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
To: Steve Wise
<swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>,
'Ming Lin' <mlin-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: 'Christoph Hellwig' <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: crash on device removal
Date: Wed, 13 Jul 2016 13:06:01 +0300 [thread overview]
Message-ID: <57861289.5020404@grimberg.me> (raw)
In-Reply-To: <010201d1dc81$9f59cf10$de0d6d30$@opengridcomputing.com>
>> We actually missed a kref_get in nvme_get_ns_from_disk().
>>
>> This should fix it. Could you help to verify?
>>
>> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
>> index 4babdf0..b146f52 100644
>> --- a/drivers/nvme/host/core.c
>> +++ b/drivers/nvme/host/core.c
>> @@ -183,6 +183,8 @@ static struct nvme_ns *nvme_get_ns_from_disk(struct
>> gendisk *disk)
>> }
>> spin_unlock(&dev_list_lock);
>>
>> + kref_get(&ns->ctrl->kref);
>> +
>> return ns;
>>
>> fail_put_ns:
>
> Hey Ming. This avoids the crash in nvme_rdma_free_qe(), but now I see another crash:
>
> [ 975.633436] nvme nvme0: new ctrl: NQN "nqn.2014-08.org.nvmexpress.discovery", addr 10.0.1.14:4420
> [ 978.463636] nvme nvme0: creating 32 I/O queues.
> [ 979.187826] nvme nvme0: new ctrl: NQN "testnqn", addr 10.0.1.14:4420
> [ 987.778287] nvme nvme0: Got rdma device removal event, deleting ctrl
> [ 987.882202] BUG: unable to handle kernel paging request at ffff880e770e01f8
> [ 987.890024] IP: [<ffffffffa03a1a46>] __ib_process_cq+0x46/0xc0 [ib_core]
>
> This looks like another problem with freeing the tag sets before stopping the QP. I thought we fixed that once and for all, but perhaps there is some other path we missed. :(
The fix doesn't look right to me. But I wander how you got this crash
now? if at all, this would delay the controller removal...
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-07-13 10:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 16:34 crash on device removal Steve Wise
2016-07-12 16:34 ` Steve Wise
2016-07-12 20:40 ` Ming Lin
2016-07-12 20:40 ` Ming Lin
2016-07-12 21:09 ` Steve Wise
2016-07-12 21:09 ` Steve Wise
2016-07-12 21:47 ` Ming Lin
2016-07-12 21:47 ` Ming Lin
2016-07-12 22:17 ` Steve Wise
2016-07-12 22:17 ` Steve Wise
2016-07-13 10:06 ` Sagi Grimberg [this message]
2016-07-13 10:06 ` Sagi Grimberg
2016-07-13 10:02 ` Sagi Grimberg
2016-07-13 10:02 ` Sagi Grimberg
2016-07-13 15:05 ` Steve Wise
2016-07-13 15:05 ` Steve Wise
2016-07-13 16:17 ` Steve Wise
2016-07-13 16:17 ` Steve Wise
[not found] <00cc01d1dc5b$51c7fa90$f557efb0$@opengridcomputing.com>
2016-07-12 16:38 ` Steve Wise
2016-07-12 16:38 ` Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57861289.5020404@grimberg.me \
--to=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.