[meta-oe][PATCH] CANopenNode: recipe for building the CANopenSocket tools

[meta-oe][PATCH] CANopenNode: recipe for building the CANopenSocket tools

[cynthiachiu]

Initial check-in for the CANopenSocket tools recipe.

Signed-off-by: cynthiachiu <cynthia.ms.chiu@gmail.com>
---
 .../canopennode/canopensocket_git.bb               | 31 ++++++++++++++++++++++
 1 file changed, 31 insertions(+)
 create mode 100644 meta-oe/recipes-extended/canopennode/canopensocket_git.bb

diff --git a/meta-oe/recipes-extended/canopennode/canopensocket_git.bb b/meta-oe/recipes-extended/canopennode/canopensocket_git.bb
new file mode 100644
index 0000000..4506698
--- /dev/null
+++ b/meta-oe/recipes-extended/canopennode/canopensocket_git.bb
@@ -0,0 +1,31 @@
+SUMMARY = "Linux CANOpen tools"
+DESCRIPTION = "Linux CANOpen Protocol Stack Tools"
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://gpl-2.0.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263"
+
+SRC_URI = "git://github.com/CANopenNode/CANopenSocket.git"
+SRCREV = "${AUTOREV}"
+
+S = "${WORKDIR}/git"
+
+do_compile_prepend() {
+    cd ${S}
+    git submodule init
+    git submodule update
+}
+
+do_compile() {
+    cd ${S}/canopend
+    make
+    cd ${S}/canopencomm
+    make
+    cd ${S}/canopencgi
+    make
+}
+
+do_install(){
+    install -d ${D}${bindir}
+    install -m 0755 ${S}/canopend/app/canopend ${D}${bindir}
+    install -m 0755 ${S}/canopencomm/canopencomm ${D}${bindir}
+    install -m 0755 ${S}/canopencgi/canopen.cgi ${D}${bindir}
+}
-- 
1.9.1

Re: [meta-oe][PATCH] CANopenNode: recipe for building the CANopenSocket tools

[Gary Thomas]

On 2016-07-13 16:57, cynthiachiu wrote:
> Initial check-in for the CANopenSocket tools recipe.
>
> Signed-off-by: cynthiachiu <cynthia.ms.chiu@gmail.com>
> ---
>   .../canopennode/canopensocket_git.bb               | 31 ++++++++++++++++++++++
>   1 file changed, 31 insertions(+)
>   create mode 100644 meta-oe/recipes-extended/canopennode/canopensocket_git.bb
>
> diff --git a/meta-oe/recipes-extended/canopennode/canopensocket_git.bb b/meta-oe/recipes-extended/canopennode/canopensocket_git.bb
> new file mode 100644
> index 0000000..4506698
> --- /dev/null
> +++ b/meta-oe/recipes-extended/canopennode/canopensocket_git.bb
> @@ -0,0 +1,31 @@
> +SUMMARY = "Linux CANOpen tools"
> +DESCRIPTION = "Linux CANOpen Protocol Stack Tools"
> +LICENSE = "GPLv2"
> +LIC_FILES_CHKSUM = "file://gpl-2.0.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> +
> +SRC_URI = "git://github.com/CANopenNode/CANopenSocket.git"
> +SRCREV = "${AUTOREV}"

Can't you pick a known, working ${REV}?  Using ${AUTOREV} makes it impossible
to use this recipe disconnected from the internet (yes, that's still a concern
in 2016!)

> +
> +S = "${WORKDIR}/git"
> +
> +do_compile_prepend() {
> +    cd ${S}
> +    git submodule init
> +    git submodule update
> +}
> +
> +do_compile() {
> +    cd ${S}/canopend
> +    make
> +    cd ${S}/canopencomm
> +    make
> +    cd ${S}/canopencgi
> +    make
> +}
> +
> +do_install(){
> +    install -d ${D}${bindir}
> +    install -m 0755 ${S}/canopend/app/canopend ${D}${bindir}
> +    install -m 0755 ${S}/canopencomm/canopencomm ${D}${bindir}
> +    install -m 0755 ${S}/canopencgi/canopen.cgi ${D}${bindir}
> +}
>


-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

Re: [meta-oe][PATCH] CANopenNode: recipe for building the CANopenSocket tools

[Christopher Larson]

On Wed, Jul 13, 2016 at 8:00 AM, Gary Thomas <gary@mlbassoc.com> wrote:

> On 2016-07-13 16:57, cynthiachiu wrote:
>
>> Initial check-in for the CANopenSocket tools recipe.
>>
>> Signed-off-by: cynthiachiu <cynthia.ms.chiu@gmail.com>
>> ---
>>   .../canopennode/canopensocket_git.bb               | 31
>> ++++++++++++++++++++++
>>   1 file changed, 31 insertions(+)
>>   create mode 100644 meta-oe/recipes-extended/canopennode/
>> canopensocket_git.bb
>>
>> diff --git a/meta-oe/recipes-extended/canopennode/canopensocket_git.bb
>> b/meta-oe/recipes-extended/canopennode/canopensocket_git.bb
>> new file mode 100644
>> index 0000000..4506698
>> --- /dev/null
>> +++ b/meta-oe/recipes-extended/canopennode/canopensocket_git.bb
>> @@ -0,0 +1,31 @@
>> +SUMMARY = "Linux CANOpen tools"
>> +DESCRIPTION = "Linux CANOpen Protocol Stack Tools"
>> +LICENSE = "GPLv2"
>> +LIC_FILES_CHKSUM =
>> "file://gpl-2.0.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263"
>> +
>> +SRC_URI = "git://github.com/CANopenNode/CANopenSocket.git"
>> +SRCREV = "${AUTOREV}"
>>
>
> Can't you pick a known, working ${REV}?  Using ${AUTOREV} makes it
> impossible
> to use this recipe disconnected from the internet (yes, that's still a
> concern
> in 2016!)
>
>
> +
>> +S = "${WORKDIR}/git"
>> +
>> +do_compile_prepend() {
>> +    cd ${S}
>> +    git submodule init
>> +    git submodule update
>>
>
This fetches things at do_compile time, which is not appropriate. Use
gitsm:// instead of git:// and let the fetcher handle the submodules.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

Re: [meta-oe][PATCH] CANopenNode: recipe for building the CANopenSocket tools

[Derek Straka]

Have you tried using the gitsm (
https://www.yoctoproject.org/docs/2.1/bitbake-user-manual/bitbake-user-manual.html#gitsm-fetcher)
fetcher instead of git?  I believe gitsm should do all of the submodule
init and update actions automatically rather than having to use a
do_compile_prepend.

-Derek


On Wed, Jul 13, 2016 at 10:57 AM, cynthiachiu <cynthia.ms.chiu@gmail.com>
> wrote:
>
>> Initial check-in for the CANopenSocket tools recipe.
>>
>> Signed-off-by: cynthiachiu <cynthia.ms.chiu@gmail.com>
>> ---
>>  .../canopennode/canopensocket_git.bb               | 31
>> ++++++++++++++++++++++
>>  1 file changed, 31 insertions(+)
>>  create mode 100644 meta-oe/recipes-extended/canopennode/
>> canopensocket_git.bb
>>
>> diff --git a/meta-oe/recipes-extended/canopennode/canopensocket_git.bb
>> b/meta-oe/recipes-extended/canopennode/canopensocket_git.bb
>> new file mode 100644
>> index 0000000..4506698
>> --- /dev/null
>> +++ b/meta-oe/recipes-extended/canopennode/canopensocket_git.bb
>> @@ -0,0 +1,31 @@
>> +SUMMARY = "Linux CANOpen tools"
>> +DESCRIPTION = "Linux CANOpen Protocol Stack Tools"
>> +LICENSE = "GPLv2"
>> +LIC_FILES_CHKSUM =
>> "file://gpl-2.0.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263"
>> +
>> +SRC_URI = "git://github.com/CANopenNode/CANopenSocket.git"
>> +SRCREV = "${AUTOREV}"
>> +
>> +S = "${WORKDIR}/git"
>> +
>> +do_compile_prepend() {
>> +    cd ${S}
>> +    git submodule init
>> +    git submodule update
>> +}
>> +
>> +do_compile() {
>> +    cd ${S}/canopend
>> +    make
>> +    cd ${S}/canopencomm
>> +    make
>> +    cd ${S}/canopencgi
>> +    make
>> +}
>> +
>> +do_install(){
>> +    install -d ${D}${bindir}
>> +    install -m 0755 ${S}/canopend/app/canopend ${D}${bindir}
>> +    install -m 0755 ${S}/canopencomm/canopencomm ${D}${bindir}
>> +    install -m 0755 ${S}/canopencgi/canopen.cgi ${D}${bindir}
>> +}
>> --
>> 1.9.1
>>
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>
>
>

Re: [meta-oe][PATCH] CANopenNode: recipe for building the CANopenSocket tools

[Cynthia Chiu]

Thanks for your feedback! I have updated it to use gitsm.

On Wed, Jul 13, 2016 at 9:50 AM, Derek Straka <derek@asterius.io> wrote:

> Have you tried using the gitsm (
>
> https://www.yoctoproject.org/docs/2.1/bitbake-user-manual/bitbake-user-manual.html#gitsm-fetcher
> )
> fetcher instead of git?  I believe gitsm should do all of the submodule
> init and update actions automatically rather than having to use a
> do_compile_prepend.
>
> -Derek
>
>
> On Wed, Jul 13, 2016 at 10:57 AM, cynthiachiu <cynthia.ms.chiu@gmail.com>
> > wrote:
> >
> >> Initial check-in for the CANopenSocket tools recipe.
> >>
> >> Signed-off-by: cynthiachiu <cynthia.ms.chiu@gmail.com>
> >> ---
> >>  .../canopennode/canopensocket_git.bb               | 31
> >> ++++++++++++++++++++++
> >>  1 file changed, 31 insertions(+)
> >>  create mode 100644 meta-oe/recipes-extended/canopennode/
> >> canopensocket_git.bb
> >>
> >> diff --git a/meta-oe/recipes-extended/canopennode/canopensocket_git.bb
> >> b/meta-oe/recipes-extended/canopennode/canopensocket_git.bb
> >> new file mode 100644
> >> index 0000000..4506698
> >> --- /dev/null
> >> +++ b/meta-oe/recipes-extended/canopennode/canopensocket_git.bb
> >> @@ -0,0 +1,31 @@
> >> +SUMMARY = "Linux CANOpen tools"
> >> +DESCRIPTION = "Linux CANOpen Protocol Stack Tools"
> >> +LICENSE = "GPLv2"
> >> +LIC_FILES_CHKSUM =
> >> "file://gpl-2.0.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> >> +
> >> +SRC_URI = "git://github.com/CANopenNode/CANopenSocket.git"
> >> +SRCREV = "${AUTOREV}"
> >> +
> >> +S = "${WORKDIR}/git"
> >> +
> >> +do_compile_prepend() {
> >> +    cd ${S}
> >> +    git submodule init
> >> +    git submodule update
> >> +}
> >> +
> >> +do_compile() {
> >> +    cd ${S}/canopend
> >> +    make
> >> +    cd ${S}/canopencomm
> >> +    make
> >> +    cd ${S}/canopencgi
> >> +    make
> >> +}
> >> +
> >> +do_install(){
> >> +    install -d ${D}${bindir}
> >> +    install -m 0755 ${S}/canopend/app/canopend ${D}${bindir}
> >> +    install -m 0755 ${S}/canopencomm/canopencomm ${D}${bindir}
> >> +    install -m 0755 ${S}/canopencgi/canopen.cgi ${D}${bindir}
> >> +}
> >> --
> >> 1.9.1
> >>
> >> --
> >> _______________________________________________
> >> Openembedded-devel mailing list
> >> Openembedded-devel@lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >>
> >
> >
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>