All of lore.kernel.org
 help / color / mirror / Atom feed
From: f.fainelli@gmail.com (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: Add Broadcom Set Top Box Kconfig entry point
Date: Wed, 13 Jul 2016 14:24:19 -0700	[thread overview]
Message-ID: <5786B183.2010007@gmail.com> (raw)
In-Reply-To: <5784B300.2000308@arm.com>

On 07/12/2016 02:06 AM, Sudeep Holla wrote:
> 
> 
> On 29/06/16 20:49, Markus Mayer wrote:
>> From: Florian Fainelli <f.fainelli@gmail.com>
>>
>> Add an ARCH_BRCMSTB Kconfig symbol which allows us not to update the
>> dependencies for all STB-related drivers. Select BRCMSTB_L2_IRQ and
>> GENERIC_IRQ_CHIP which are required for proper functioning.
>>
>> Signed-off-by: Doug Berger <opendmb@gmail.com>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>> Signed-off-by: Markus Mayer <mmayer@broadcom.com>
>> ---
>>
>>   arch/arm64/Kconfig.platforms | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
>> index 7ef1d05..22b5c7f 100644
>> --- a/arch/arm64/Kconfig.platforms
>> +++ b/arch/arm64/Kconfig.platforms
>> @@ -29,6 +29,13 @@ config ARCH_BERLIN
>>       help
>>         This enables support for Marvell Berlin SoC Family
>>
>> +config ARCH_BRCMSTB
>> +    bool "Broadcom Set-Top-Box SoCs"
>> +    select BRCMSTB_L2_IRQ
> 
> I see that BRCMSTB_L2_IRQ selects GENERIC_IRQ_CHIP already so the below
> one is redundant, generally irqchip code should select GENERIC_IRQ_CHIP

Thanks, I applied a fix in place which removes the select
GENERIC_IRQ_CHIP since it is redundant.
-- 
Florian

WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: Sudeep Holla <sudeep.holla@arm.com>, Markus Mayer <mmayer@broadcom.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Doug Berger <opendmb@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>,
	ARM Kernel Mailing List  <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: Add Broadcom Set Top Box Kconfig entry point
Date: Wed, 13 Jul 2016 14:24:19 -0700	[thread overview]
Message-ID: <5786B183.2010007@gmail.com> (raw)
In-Reply-To: <5784B300.2000308@arm.com>

On 07/12/2016 02:06 AM, Sudeep Holla wrote:
> 
> 
> On 29/06/16 20:49, Markus Mayer wrote:
>> From: Florian Fainelli <f.fainelli@gmail.com>
>>
>> Add an ARCH_BRCMSTB Kconfig symbol which allows us not to update the
>> dependencies for all STB-related drivers. Select BRCMSTB_L2_IRQ and
>> GENERIC_IRQ_CHIP which are required for proper functioning.
>>
>> Signed-off-by: Doug Berger <opendmb@gmail.com>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>> Signed-off-by: Markus Mayer <mmayer@broadcom.com>
>> ---
>>
>>   arch/arm64/Kconfig.platforms | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
>> index 7ef1d05..22b5c7f 100644
>> --- a/arch/arm64/Kconfig.platforms
>> +++ b/arch/arm64/Kconfig.platforms
>> @@ -29,6 +29,13 @@ config ARCH_BERLIN
>>       help
>>         This enables support for Marvell Berlin SoC Family
>>
>> +config ARCH_BRCMSTB
>> +    bool "Broadcom Set-Top-Box SoCs"
>> +    select BRCMSTB_L2_IRQ
> 
> I see that BRCMSTB_L2_IRQ selects GENERIC_IRQ_CHIP already so the below
> one is redundant, generally irqchip code should select GENERIC_IRQ_CHIP

Thanks, I applied a fix in place which removes the select
GENERIC_IRQ_CHIP since it is redundant.
-- 
Florian

  reply	other threads:[~2016-07-13 21:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-29 19:49 [PATCH] arm64: Add Broadcom Set Top Box Kconfig entry point Markus Mayer
2016-06-29 19:49 ` Markus Mayer
2016-07-11 23:50 ` Florian Fainelli
2016-07-11 23:50   ` Florian Fainelli
2016-07-12  9:06 ` Sudeep Holla
2016-07-12  9:06   ` Sudeep Holla
2016-07-13 21:24   ` Florian Fainelli [this message]
2016-07-13 21:24     ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5786B183.2010007@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.