From: Xishi Qiu <qiuxishi@huawei.com>
To: David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Linux MM <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/2] mem-hotplug: use GFP_HIGHUSER_MOVABLE in, alloc_migrate_target()
Date: Fri, 15 Jul 2016 10:47:06 +0800 [thread overview]
Message-ID: <57884EAA.9030603@huawei.com> (raw)
alloc_migrate_target() is called from migrate_pages(), and the page
is always from user space, so we can add __GFP_HIGHMEM directly.
Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
---
mm/page_isolation.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/mm/page_isolation.c b/mm/page_isolation.c
index 612122b..4f32c9f 100644
--- a/mm/page_isolation.c
+++ b/mm/page_isolation.c
@@ -282,8 +282,6 @@ int test_pages_isolated(unsigned long start_pfn, unsigned long end_pfn,
struct page *alloc_migrate_target(struct page *page, unsigned long private,
int **resultp)
{
- gfp_t gfp_mask = GFP_USER | __GFP_MOVABLE;
-
/*
* TODO: allocate a destination hugepage from a nearest neighbor node,
* accordance with memory policy of the user process if possible. For
@@ -293,9 +291,6 @@ struct page *alloc_migrate_target(struct page *page, unsigned long private,
return alloc_huge_page_node(page_hstate(compound_head(page)),
next_node_in(page_to_nid(page),
node_online_map));
-
- if (PageHighMem(page))
- gfp_mask |= __GFP_HIGHMEM;
-
- return alloc_page(gfp_mask);
+ else
+ return alloc_page(GFP_HIGHUSER_MOVABLE);
}
--
1.8.3.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Xishi Qiu <qiuxishi@huawei.com>
To: David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Linux MM <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/2] mem-hotplug: use GFP_HIGHUSER_MOVABLE in, alloc_migrate_target()
Date: Fri, 15 Jul 2016 10:47:06 +0800 [thread overview]
Message-ID: <57884EAA.9030603@huawei.com> (raw)
alloc_migrate_target() is called from migrate_pages(), and the page
is always from user space, so we can add __GFP_HIGHMEM directly.
Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
---
mm/page_isolation.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/mm/page_isolation.c b/mm/page_isolation.c
index 612122b..4f32c9f 100644
--- a/mm/page_isolation.c
+++ b/mm/page_isolation.c
@@ -282,8 +282,6 @@ int test_pages_isolated(unsigned long start_pfn, unsigned long end_pfn,
struct page *alloc_migrate_target(struct page *page, unsigned long private,
int **resultp)
{
- gfp_t gfp_mask = GFP_USER | __GFP_MOVABLE;
-
/*
* TODO: allocate a destination hugepage from a nearest neighbor node,
* accordance with memory policy of the user process if possible. For
@@ -293,9 +291,6 @@ struct page *alloc_migrate_target(struct page *page, unsigned long private,
return alloc_huge_page_node(page_hstate(compound_head(page)),
next_node_in(page_to_nid(page),
node_online_map));
-
- if (PageHighMem(page))
- gfp_mask |= __GFP_HIGHMEM;
-
- return alloc_page(gfp_mask);
+ else
+ return alloc_page(GFP_HIGHUSER_MOVABLE);
}
--
1.8.3.1
next reply other threads:[~2016-07-15 2:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 2:47 Xishi Qiu [this message]
2016-07-15 2:47 ` [PATCH 1/2] mem-hotplug: use GFP_HIGHUSER_MOVABLE in, alloc_migrate_target() Xishi Qiu
2016-07-15 2:51 ` [PATCH 2/2] mem-hotplug: use different mempolicy in alloc_migrate_target() Xishi Qiu
2016-07-15 2:51 ` Xishi Qiu
2016-07-18 8:00 ` Vlastimil Babka
2016-07-18 8:00 ` Vlastimil Babka
2016-07-18 5:51 ` [PATCH 1/2] mem-hotplug: use GFP_HIGHUSER_MOVABLE in, alloc_migrate_target() Joonsoo Kim
2016-07-18 5:51 ` Joonsoo Kim
2016-07-18 7:45 ` Vlastimil Babka
2016-07-18 7:45 ` Vlastimil Babka
2016-07-18 8:00 ` Xishi Qiu
2016-07-18 8:00 ` Xishi Qiu
2016-07-18 8:05 ` Vlastimil Babka
2016-07-18 8:05 ` Vlastimil Babka
2016-07-18 8:31 ` Xishi Qiu
2016-07-18 8:31 ` Xishi Qiu
2016-07-19 6:50 ` Joonsoo Kim
2016-07-19 6:50 ` Joonsoo Kim
2016-07-19 7:18 ` Xishi Qiu
2016-07-19 7:18 ` Xishi Qiu
2016-07-19 19:05 ` David Rientjes
2016-07-19 19:05 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57884EAA.9030603@huawei.com \
--to=qiuxishi@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.