From: Alim Akhtar <alim.akhtar@samsung.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Kukjin Kim <kgene@kernel.org>,
linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: mmc: dwmmc: exynos: Warn if HS400 is being used on non-Exynos5420 chipset
Date: Fri, 15 Jul 2016 09:45:59 +0530 [thread overview]
Message-ID: <5788637F.2070908@samsung.com> (raw)
In-Reply-To: <1468502547-18571-1-git-send-email-k.kozlowski@samsung.com>
Hi Krzysztof,
On 07/14/2016 06:52 PM, Krzysztof Kozlowski wrote:
> Chipsets before Exynos5420 did not support HS400 so if MMC core tries to
> configure HS400 timing, this might or might not work. Warn in such
> cases because this is DTB misconfiguration.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> drivers/mmc/host/dw_mmc-exynos.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
> index da0ef1765735..7ab3d749b5ae 100644
> --- a/drivers/mmc/host/dw_mmc-exynos.c
> +++ b/drivers/mmc/host/dw_mmc-exynos.c
> @@ -225,8 +225,12 @@ static void dw_mci_exynos_config_hs400(struct dw_mci *host, u32 timing)
> * Not supported to configure register
> * related to HS400
> */
> - if (priv->ctrl_type < DW_MCI_TYPE_EXYNOS5420)
> + if (priv->ctrl_type < DW_MCI_TYPE_EXYNOS5420) {
> + if (timing == MMC_TIMING_MMC_HS400)
> + dev_warn(host->dev,
> + "cannot configure HS400, unsupported chipset\n");
> return;
> + }
>
It is good to have extra bit of debug information handy.
> dqs = priv->saved_dqs_en;
> strobe = priv->saved_strobe_ctrl;
>
WARNING: multiple messages have this Message-ID (diff)
From: alim.akhtar@samsung.com (Alim Akhtar)
To: linux-arm-kernel@lists.infradead.org
Subject: mmc: dwmmc: exynos: Warn if HS400 is being used on non-Exynos5420 chipset
Date: Fri, 15 Jul 2016 09:45:59 +0530 [thread overview]
Message-ID: <5788637F.2070908@samsung.com> (raw)
In-Reply-To: <1468502547-18571-1-git-send-email-k.kozlowski@samsung.com>
Hi Krzysztof,
On 07/14/2016 06:52 PM, Krzysztof Kozlowski wrote:
> Chipsets before Exynos5420 did not support HS400 so if MMC core tries to
> configure HS400 timing, this might or might not work. Warn in such
> cases because this is DTB misconfiguration.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> drivers/mmc/host/dw_mmc-exynos.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
> index da0ef1765735..7ab3d749b5ae 100644
> --- a/drivers/mmc/host/dw_mmc-exynos.c
> +++ b/drivers/mmc/host/dw_mmc-exynos.c
> @@ -225,8 +225,12 @@ static void dw_mci_exynos_config_hs400(struct dw_mci *host, u32 timing)
> * Not supported to configure register
> * related to HS400
> */
> - if (priv->ctrl_type < DW_MCI_TYPE_EXYNOS5420)
> + if (priv->ctrl_type < DW_MCI_TYPE_EXYNOS5420) {
> + if (timing == MMC_TIMING_MMC_HS400)
> + dev_warn(host->dev,
> + "cannot configure HS400, unsupported chipset\n");
> return;
> + }
>
It is good to have extra bit of debug information handy.
> dqs = priv->saved_dqs_en;
> strobe = priv->saved_strobe_ctrl;
>
next prev parent reply other threads:[~2016-07-15 4:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 13:22 [PATCH] mmc: dwmmc: exynos: Warn if HS400 is being used on non-Exynos5420 chipset Krzysztof Kozlowski
2016-07-14 13:22 ` Krzysztof Kozlowski
2016-07-15 4:15 ` Alim Akhtar [this message]
2016-07-15 4:15 ` Alim Akhtar
2016-07-26 0:49 ` Jaehoon Chung
2016-07-26 0:49 ` Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5788637F.2070908@samsung.com \
--to=alim.akhtar@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=jh80.chung@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.