* [PATCH] tcl: fix INCLUDE_SPEC and LIB_SPEC
@ 2016-07-05 6:20 Zhenhua Luo
2016-07-05 15:15 ` Khem Raj
0 siblings, 1 reply; 6+ messages in thread
From: Zhenhua Luo @ 2016-07-05 6:20 UTC (permalink / raw)
To: openembedded-core
TCL_INCLUDE_SPEC -I+<includedir> and TCL_LIB_SPEC -L+${libdir} break
the cross-compile of packages which require tcl headers and libraries.
One example is that postgresql configure failed at the following error:
| checking for tcl.h... no
| configure: error: header file <tcl.h> is required for Tcl
Signed-off-by: Zhenhua Luo <zhenhua.luo@nxp.com>
---
meta/recipes-devtools/tcltk/tcl_8.6.5.bb | 2 --
1 file changed, 2 deletions(-)
diff --git a/meta/recipes-devtools/tcltk/tcl_8.6.5.bb b/meta/recipes-devtools/tcltk/tcl_8.6.5.bb
index 46fc8a7..d75232b 100644
--- a/meta/recipes-devtools/tcltk/tcl_8.6.5.bb
+++ b/meta/recipes-devtools/tcltk/tcl_8.6.5.bb
@@ -56,8 +56,6 @@ do_install() {
ln -sf tclsh8.6 ${D}${bindir}/tclsh${VER}
sed -i "s+-L${B}+-L${STAGING_LIBDIR}+g" tclConfig.sh
sed -i "s+${WORKDIR}+${STAGING_INCDIR}+g" tclConfig.sh
- sed -i "s,-L${libdir},-L=${libdir},g" tclConfig.sh
- sed -i "s,-I${includedir},-I=${includedir},g" tclConfig.sh
install -d ${D}${bindir_crossscripts}
install -m 0755 tclConfig.sh ${D}${bindir_crossscripts}
install -m 0755 tclConfig.sh ${D}${libdir}
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] tcl: fix INCLUDE_SPEC and LIB_SPEC 2016-07-05 6:20 [PATCH] tcl: fix INCLUDE_SPEC and LIB_SPEC Zhenhua Luo @ 2016-07-05 15:15 ` Khem Raj 2016-07-06 4:08 ` Zhenhua Luo 0 siblings, 1 reply; 6+ messages in thread From: Khem Raj @ 2016-07-05 15:15 UTC (permalink / raw) To: Zhenhua Luo; +Cc: Patches and discussions about the oe-core layer On Mon, Jul 4, 2016 at 11:20 PM, Zhenhua Luo <zhenhua.luo@nxp.com> wrote: > TCL_INCLUDE_SPEC -I+<includedir> and TCL_LIB_SPEC -L+${libdir} break > the cross-compile of packages which require tcl headers and libraries. > > One example is that postgresql configure failed at the following error: > | checking for tcl.h... no > | configure: error: header file <tcl.h> is required for Tcl > > Signed-off-by: Zhenhua Luo <zhenhua.luo@nxp.com> > --- > meta/recipes-devtools/tcltk/tcl_8.6.5.bb | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/meta/recipes-devtools/tcltk/tcl_8.6.5.bb b/meta/recipes-devtools/tcltk/tcl_8.6.5.bb > index 46fc8a7..d75232b 100644 > --- a/meta/recipes-devtools/tcltk/tcl_8.6.5.bb > +++ b/meta/recipes-devtools/tcltk/tcl_8.6.5.bb > @@ -56,8 +56,6 @@ do_install() { > ln -sf tclsh8.6 ${D}${bindir}/tclsh${VER} > sed -i "s+-L${B}+-L${STAGING_LIBDIR}+g" tclConfig.sh > sed -i "s+${WORKDIR}+${STAGING_INCDIR}+g" tclConfig.sh > - sed -i "s,-L${libdir},-L=${libdir},g" tclConfig.sh > - sed -i "s,-I${includedir},-I=${includedir},g" tclConfig.sh does this now include some of your host headers in build then ? > install -d ${D}${bindir_crossscripts} > install -m 0755 tclConfig.sh ${D}${bindir_crossscripts} > install -m 0755 tclConfig.sh ${D}${libdir} > -- > 2.7.4 > > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tcl: fix INCLUDE_SPEC and LIB_SPEC 2016-07-05 15:15 ` Khem Raj @ 2016-07-06 4:08 ` Zhenhua Luo 2016-07-15 6:13 ` Zhenhua Luo 2016-07-15 7:35 ` Khem Raj 0 siblings, 2 replies; 6+ messages in thread From: Zhenhua Luo @ 2016-07-06 4:08 UTC (permalink / raw) To: Khem Raj; +Cc: Patches and discussions about the oe-core layer > -----Original Message----- > From: Khem Raj [mailto:raj.khem@gmail.com] > Sent: Tuesday, July 05, 2016 11:16 PM > To: Zhenhua Luo <zhenhua.luo@nxp.com> > Cc: Patches and discussions about the oe-core layer <openembedded- > core@lists.openembedded.org> > Subject: Re: [OE-core] [oe-core][PATCH] tcl: fix INCLUDE_SPEC and LIB_SPEC > > On Mon, Jul 4, 2016 at 11:20 PM, Zhenhua Luo <zhenhua.luo@nxp.com> wrote: > > TCL_INCLUDE_SPEC -I+<includedir> and TCL_LIB_SPEC -L+${libdir} break > > the cross-compile of packages which require tcl headers and libraries. > > > > One example is that postgresql configure failed at the following error: > > | checking for tcl.h... no > > | configure: error: header file <tcl.h> is required for Tcl > > > > Signed-off-by: Zhenhua Luo <zhenhua.luo@nxp.com> > > --- > > meta/recipes-devtools/tcltk/tcl_8.6.5.bb | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/meta/recipes-devtools/tcltk/tcl_8.6.5.bb > > b/meta/recipes-devtools/tcltk/tcl_8.6.5.bb > > index 46fc8a7..d75232b 100644 > > --- a/meta/recipes-devtools/tcltk/tcl_8.6.5.bb > > +++ b/meta/recipes-devtools/tcltk/tcl_8.6.5.bb > > @@ -56,8 +56,6 @@ do_install() { > > ln -sf tclsh8.6 ${D}${bindir}/tclsh${VER} > > sed -i "s+-L${B}+-L${STAGING_LIBDIR}+g" tclConfig.sh > > sed -i "s+${WORKDIR}+${STAGING_INCDIR}+g" tclConfig.sh > > - sed -i "s,-L${libdir},-L=${libdir},g" tclConfig.sh > > - sed -i "s,-I${includedir},-I=${includedir},g" tclConfig.sh > > does this now include some of your host headers in build then ? [Luo Zhenhua-B19537] The patch does the following changes for tclConfig.sh. Without the change, tcl.h can't be found when cross building packages(e.g. postgresql) which depend on tcl. I have cross-compiled several packages(postgresql, expect, ruby, tk) that have tcl dependency and see no issue. 1. tmp/sysroots/qemuarm64/usr/bin/crossscripts/tclConfig.sh # String to pass to linker to pick up the Tcl library from its # installed directory. -TCL_LIB_SPEC='-L=/home/bjsimics/workspace/poky-os/qemuppc/tmp/sysroots/qemuarm64/usr/lib -ltcl8.6' +TCL_LIB_SPEC='-L/home/bjsimics/workspace/poky-os/qemuppc/tmp/sysroots/qemuarm64/usr/lib -ltcl8.6' # String to pass to the compiler so that an extension can # find installed Tcl headers. -TCL_INCLUDE_SPEC='-I=/home/bjsimics/workspace/poky-os/qemuppc/tmp/sysroots/qemuarm64/usr/include/tcl8.6' +TCL_INCLUDE_SPEC='-I/home/bjsimics/workspace/poky-os/qemuppc/tmp/sysroots/qemuarm64/usr/include/tcl8.6' # String to pass to linker to pick up the Tcl stub library from its # installed directory. -TCL_STUB_LIB_SPEC='-L=/home/bjsimics/workspace/poky-os/qemuppc/tmp/sysroots/qemuarm64/usr/lib -ltclstub8.6' +TCL_STUB_LIB_SPEC='-L/home/bjsimics/workspace/poky-os/qemuppc/tmp/sysroots/qemuarm64/usr/lib -ltclstub8.6' 2. tmp/sysroots/qemuarm64/usr/lib/tclConfig.sh # String to pass to linker to pick up the Tcl library from its # installed directory. -TCL_LIB_SPEC='-L=/usr/lib -ltcl8.6' +TCL_LIB_SPEC='-L/usr/lib -ltcl8.6' # String to pass to the compiler so that an extension can # find installed Tcl headers. -TCL_INCLUDE_SPEC='-I=/usr/include/tcl8.6' +TCL_INCLUDE_SPEC='-I/usr/include/tcl8.6' # String to pass to linker to pick up the Tcl stub library from its # installed directory. -TCL_STUB_LIB_SPEC='-L=/usr/lib -ltclstub8.6' +TCL_STUB_LIB_SPEC='-L/usr/lib -ltclstub8.6' Best Regards, Zhenhua > > install -d ${D}${bindir_crossscripts} > > install -m 0755 tclConfig.sh ${D}${bindir_crossscripts} > > install -m 0755 tclConfig.sh ${D}${libdir} > > -- > > 2.7.4 > > > > -- > > _______________________________________________ > > Openembedded-core mailing list > > Openembedded-core@lists.openembedded.org > > http://lists.openembedded.org/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tcl: fix INCLUDE_SPEC and LIB_SPEC 2016-07-06 4:08 ` Zhenhua Luo @ 2016-07-15 6:13 ` Zhenhua Luo 2016-07-15 6:23 ` Robert Yang 2016-07-15 7:35 ` Khem Raj 1 sibling, 1 reply; 6+ messages in thread From: Zhenhua Luo @ 2016-07-15 6:13 UTC (permalink / raw) To: Patches and discussions about the oe-core layer Ping. Is there any other comment to be addressed for the patch? Best Regards, Zhenhua > -----Original Message----- > From: openembedded-core-bounces@lists.openembedded.org > [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf > Of Zhenhua Luo > Sent: Wednesday, July 06, 2016 12:09 PM > To: Khem Raj <raj.khem@gmail.com> > Cc: Patches and discussions about the oe-core layer <openembedded- > core@lists.openembedded.org> > Subject: Re: [OE-core] [oe-core][PATCH] tcl: fix INCLUDE_SPEC and LIB_SPEC > > > -----Original Message----- > > From: Khem Raj [mailto:raj.khem@gmail.com] > > Sent: Tuesday, July 05, 2016 11:16 PM > > To: Zhenhua Luo <zhenhua.luo@nxp.com> > > Cc: Patches and discussions about the oe-core layer <openembedded- > > core@lists.openembedded.org> > > Subject: Re: [OE-core] [oe-core][PATCH] tcl: fix INCLUDE_SPEC and > > LIB_SPEC > > > > On Mon, Jul 4, 2016 at 11:20 PM, Zhenhua Luo <zhenhua.luo@nxp.com> > wrote: > > > TCL_INCLUDE_SPEC -I+<includedir> and TCL_LIB_SPEC -L+${libdir} break > > > the cross-compile of packages which require tcl headers and libraries. > > > > > > One example is that postgresql configure failed at the following error: > > > | checking for tcl.h... no > > > | configure: error: header file <tcl.h> is required for Tcl > > > > > > Signed-off-by: Zhenhua Luo <zhenhua.luo@nxp.com> > > > --- > > > meta/recipes-devtools/tcltk/tcl_8.6.5.bb | 2 -- > > > 1 file changed, 2 deletions(-) > > > > > > diff --git a/meta/recipes-devtools/tcltk/tcl_8.6.5.bb > > > b/meta/recipes-devtools/tcltk/tcl_8.6.5.bb > > > index 46fc8a7..d75232b 100644 > > > --- a/meta/recipes-devtools/tcltk/tcl_8.6.5.bb > > > +++ b/meta/recipes-devtools/tcltk/tcl_8.6.5.bb > > > @@ -56,8 +56,6 @@ do_install() { > > > ln -sf tclsh8.6 ${D}${bindir}/tclsh${VER} > > > sed -i "s+-L${B}+-L${STAGING_LIBDIR}+g" tclConfig.sh > > > sed -i "s+${WORKDIR}+${STAGING_INCDIR}+g" tclConfig.sh > > > - sed -i "s,-L${libdir},-L=${libdir},g" tclConfig.sh > > > - sed -i "s,-I${includedir},-I=${includedir},g" tclConfig.sh > > > > does this now include some of your host headers in build then ? > [Luo Zhenhua-B19537] The patch does the following changes for tclConfig.sh. > Without the change, tcl.h can't be found when cross building packages(e.g. > postgresql) which depend on tcl. I have cross-compiled several > packages(postgresql, expect, ruby, tk) that have tcl dependency and see no > issue. > 1. tmp/sysroots/qemuarm64/usr/bin/crossscripts/tclConfig.sh > # String to pass to linker to pick up the Tcl library from its > # installed directory. > -TCL_LIB_SPEC='-L=/home/bjsimics/workspace/poky- > os/qemuppc/tmp/sysroots/qemuarm64/usr/lib -ltcl8.6' > +TCL_LIB_SPEC='-L/home/bjsimics/workspace/poky- > os/qemuppc/tmp/sysroots/qemuarm64/usr/lib -ltcl8.6' > > # String to pass to the compiler so that an extension can > # find installed Tcl headers. > -TCL_INCLUDE_SPEC='-I=/home/bjsimics/workspace/poky- > os/qemuppc/tmp/sysroots/qemuarm64/usr/include/tcl8.6' > +TCL_INCLUDE_SPEC='-I/home/bjsimics/workspace/poky- > os/qemuppc/tmp/sysroots/qemuarm64/usr/include/tcl8.6' > > # String to pass to linker to pick up the Tcl stub library from its > # installed directory. > -TCL_STUB_LIB_SPEC='-L=/home/bjsimics/workspace/poky- > os/qemuppc/tmp/sysroots/qemuarm64/usr/lib -ltclstub8.6' > +TCL_STUB_LIB_SPEC='-L/home/bjsimics/workspace/poky- > os/qemuppc/tmp/sysroots/qemuarm64/usr/lib -ltclstub8.6' > > 2. tmp/sysroots/qemuarm64/usr/lib/tclConfig.sh > # String to pass to linker to pick up the Tcl library from its > # installed directory. > -TCL_LIB_SPEC='-L=/usr/lib -ltcl8.6' > +TCL_LIB_SPEC='-L/usr/lib -ltcl8.6' > > # String to pass to the compiler so that an extension can > # find installed Tcl headers. > -TCL_INCLUDE_SPEC='-I=/usr/include/tcl8.6' > +TCL_INCLUDE_SPEC='-I/usr/include/tcl8.6' > > # String to pass to linker to pick up the Tcl stub library from its > # installed directory. > -TCL_STUB_LIB_SPEC='-L=/usr/lib -ltclstub8.6' > +TCL_STUB_LIB_SPEC='-L/usr/lib -ltclstub8.6' > > > Best Regards, > > Zhenhua > > > > install -d ${D}${bindir_crossscripts} > > > install -m 0755 tclConfig.sh ${D}${bindir_crossscripts} > > > install -m 0755 tclConfig.sh ${D}${libdir} > > > -- > > > 2.7.4 > > > > > > -- > > > _______________________________________________ > > > Openembedded-core mailing list > > > Openembedded-core@lists.openembedded.org > > > http://lists.openembedded.org/mailman/listinfo/openembedded-core > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tcl: fix INCLUDE_SPEC and LIB_SPEC 2016-07-15 6:13 ` Zhenhua Luo @ 2016-07-15 6:23 ` Robert Yang 0 siblings, 0 replies; 6+ messages in thread From: Robert Yang @ 2016-07-15 6:23 UTC (permalink / raw) To: Zhenhua Luo, Patches and discussions about the oe-core layer FYI, I had sent one before: http://lists.openembedded.org/pipermail/openembedded-core/2016-June/123006.html And pending for reviewing. // Robert On 07/15/2016 02:13 PM, Zhenhua Luo wrote: > Ping. > > Is there any other comment to be addressed for the patch? > > > Best Regards, > > Zhenhua > >> -----Original Message----- >> From: openembedded-core-bounces@lists.openembedded.org >> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf >> Of Zhenhua Luo >> Sent: Wednesday, July 06, 2016 12:09 PM >> To: Khem Raj <raj.khem@gmail.com> >> Cc: Patches and discussions about the oe-core layer <openembedded- >> core@lists.openembedded.org> >> Subject: Re: [OE-core] [oe-core][PATCH] tcl: fix INCLUDE_SPEC and LIB_SPEC >> >>> -----Original Message----- >>> From: Khem Raj [mailto:raj.khem@gmail.com] >>> Sent: Tuesday, July 05, 2016 11:16 PM >>> To: Zhenhua Luo <zhenhua.luo@nxp.com> >>> Cc: Patches and discussions about the oe-core layer <openembedded- >>> core@lists.openembedded.org> >>> Subject: Re: [OE-core] [oe-core][PATCH] tcl: fix INCLUDE_SPEC and >>> LIB_SPEC >>> >>> On Mon, Jul 4, 2016 at 11:20 PM, Zhenhua Luo <zhenhua.luo@nxp.com> >> wrote: >>>> TCL_INCLUDE_SPEC -I+<includedir> and TCL_LIB_SPEC -L+${libdir} break >>>> the cross-compile of packages which require tcl headers and libraries. >>>> >>>> One example is that postgresql configure failed at the following error: >>>> | checking for tcl.h... no >>>> | configure: error: header file <tcl.h> is required for Tcl >>>> >>>> Signed-off-by: Zhenhua Luo <zhenhua.luo@nxp.com> >>>> --- >>>> meta/recipes-devtools/tcltk/tcl_8.6.5.bb | 2 -- >>>> 1 file changed, 2 deletions(-) >>>> >>>> diff --git a/meta/recipes-devtools/tcltk/tcl_8.6.5.bb >>>> b/meta/recipes-devtools/tcltk/tcl_8.6.5.bb >>>> index 46fc8a7..d75232b 100644 >>>> --- a/meta/recipes-devtools/tcltk/tcl_8.6.5.bb >>>> +++ b/meta/recipes-devtools/tcltk/tcl_8.6.5.bb >>>> @@ -56,8 +56,6 @@ do_install() { >>>> ln -sf tclsh8.6 ${D}${bindir}/tclsh${VER} >>>> sed -i "s+-L${B}+-L${STAGING_LIBDIR}+g" tclConfig.sh >>>> sed -i "s+${WORKDIR}+${STAGING_INCDIR}+g" tclConfig.sh >>>> - sed -i "s,-L${libdir},-L=${libdir},g" tclConfig.sh >>>> - sed -i "s,-I${includedir},-I=${includedir},g" tclConfig.sh >>> >>> does this now include some of your host headers in build then ? >> [Luo Zhenhua-B19537] The patch does the following changes for tclConfig.sh. >> Without the change, tcl.h can't be found when cross building packages(e.g. >> postgresql) which depend on tcl. I have cross-compiled several >> packages(postgresql, expect, ruby, tk) that have tcl dependency and see no >> issue. >> 1. tmp/sysroots/qemuarm64/usr/bin/crossscripts/tclConfig.sh >> # String to pass to linker to pick up the Tcl library from its >> # installed directory. >> -TCL_LIB_SPEC='-L=/home/bjsimics/workspace/poky- >> os/qemuppc/tmp/sysroots/qemuarm64/usr/lib -ltcl8.6' >> +TCL_LIB_SPEC='-L/home/bjsimics/workspace/poky- >> os/qemuppc/tmp/sysroots/qemuarm64/usr/lib -ltcl8.6' >> >> # String to pass to the compiler so that an extension can >> # find installed Tcl headers. >> -TCL_INCLUDE_SPEC='-I=/home/bjsimics/workspace/poky- >> os/qemuppc/tmp/sysroots/qemuarm64/usr/include/tcl8.6' >> +TCL_INCLUDE_SPEC='-I/home/bjsimics/workspace/poky- >> os/qemuppc/tmp/sysroots/qemuarm64/usr/include/tcl8.6' >> >> # String to pass to linker to pick up the Tcl stub library from its >> # installed directory. >> -TCL_STUB_LIB_SPEC='-L=/home/bjsimics/workspace/poky- >> os/qemuppc/tmp/sysroots/qemuarm64/usr/lib -ltclstub8.6' >> +TCL_STUB_LIB_SPEC='-L/home/bjsimics/workspace/poky- >> os/qemuppc/tmp/sysroots/qemuarm64/usr/lib -ltclstub8.6' >> >> 2. tmp/sysroots/qemuarm64/usr/lib/tclConfig.sh >> # String to pass to linker to pick up the Tcl library from its >> # installed directory. >> -TCL_LIB_SPEC='-L=/usr/lib -ltcl8.6' >> +TCL_LIB_SPEC='-L/usr/lib -ltcl8.6' >> >> # String to pass to the compiler so that an extension can >> # find installed Tcl headers. >> -TCL_INCLUDE_SPEC='-I=/usr/include/tcl8.6' >> +TCL_INCLUDE_SPEC='-I/usr/include/tcl8.6' >> >> # String to pass to linker to pick up the Tcl stub library from its >> # installed directory. >> -TCL_STUB_LIB_SPEC='-L=/usr/lib -ltclstub8.6' >> +TCL_STUB_LIB_SPEC='-L/usr/lib -ltclstub8.6' >> >> >> Best Regards, >> >> Zhenhua >> >>>> install -d ${D}${bindir_crossscripts} >>>> install -m 0755 tclConfig.sh ${D}${bindir_crossscripts} >>>> install -m 0755 tclConfig.sh ${D}${libdir} >>>> -- >>>> 2.7.4 >>>> >>>> -- >>>> _______________________________________________ >>>> Openembedded-core mailing list >>>> Openembedded-core@lists.openembedded.org >>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core >> -- >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tcl: fix INCLUDE_SPEC and LIB_SPEC 2016-07-06 4:08 ` Zhenhua Luo 2016-07-15 6:13 ` Zhenhua Luo @ 2016-07-15 7:35 ` Khem Raj 1 sibling, 0 replies; 6+ messages in thread From: Khem Raj @ 2016-07-15 7:35 UTC (permalink / raw) To: Zhenhua Luo; +Cc: Patches and discussions about the oe-core layer On Tue, Jul 5, 2016 at 9:08 PM, Zhenhua Luo <zhenhua.luo@nxp.com> wrote: >> -----Original Message----- >> From: Khem Raj [mailto:raj.khem@gmail.com] >> Sent: Tuesday, July 05, 2016 11:16 PM >> To: Zhenhua Luo <zhenhua.luo@nxp.com> >> Cc: Patches and discussions about the oe-core layer <openembedded- >> core@lists.openembedded.org> >> Subject: Re: [OE-core] [oe-core][PATCH] tcl: fix INCLUDE_SPEC and LIB_SPEC >> >> On Mon, Jul 4, 2016 at 11:20 PM, Zhenhua Luo <zhenhua.luo@nxp.com> wrote: >> > TCL_INCLUDE_SPEC -I+<includedir> and TCL_LIB_SPEC -L+${libdir} break >> > the cross-compile of packages which require tcl headers and libraries. >> > >> > One example is that postgresql configure failed at the following error: >> > | checking for tcl.h... no >> > | configure: error: header file <tcl.h> is required for Tcl >> > >> > Signed-off-by: Zhenhua Luo <zhenhua.luo@nxp.com> >> > --- >> > meta/recipes-devtools/tcltk/tcl_8.6.5.bb | 2 -- >> > 1 file changed, 2 deletions(-) >> > >> > diff --git a/meta/recipes-devtools/tcltk/tcl_8.6.5.bb >> > b/meta/recipes-devtools/tcltk/tcl_8.6.5.bb >> > index 46fc8a7..d75232b 100644 >> > --- a/meta/recipes-devtools/tcltk/tcl_8.6.5.bb >> > +++ b/meta/recipes-devtools/tcltk/tcl_8.6.5.bb >> > @@ -56,8 +56,6 @@ do_install() { >> > ln -sf tclsh8.6 ${D}${bindir}/tclsh${VER} >> > sed -i "s+-L${B}+-L${STAGING_LIBDIR}+g" tclConfig.sh >> > sed -i "s+${WORKDIR}+${STAGING_INCDIR}+g" tclConfig.sh >> > - sed -i "s,-L${libdir},-L=${libdir},g" tclConfig.sh >> > - sed -i "s,-I${includedir},-I=${includedir},g" tclConfig.sh >> >> does this now include some of your host headers in build then ? > [Luo Zhenhua-B19537] The patch does the following changes for tclConfig.sh. Without the change, tcl.h can't be found when cross building packages(e.g. postgresql) which depend on tcl. I have cross-compiled several packages(postgresql, expect, ruby, tk) that have tcl dependency and see no issue. > 1. tmp/sysroots/qemuarm64/usr/bin/crossscripts/tclConfig.sh > # String to pass to linker to pick up the Tcl library from its > # installed directory. > -TCL_LIB_SPEC='-L=/home/bjsimics/workspace/poky-os/qemuppc/tmp/sysroots/qemuarm64/usr/lib -ltcl8.6' > +TCL_LIB_SPEC='-L/home/bjsimics/workspace/poky-os/qemuppc/tmp/sysroots/qemuarm64/usr/lib -ltcl8.6' > > # String to pass to the compiler so that an extension can > # find installed Tcl headers. > -TCL_INCLUDE_SPEC='-I=/home/bjsimics/workspace/poky-os/qemuppc/tmp/sysroots/qemuarm64/usr/include/tcl8.6' > +TCL_INCLUDE_SPEC='-I/home/bjsimics/workspace/poky-os/qemuppc/tmp/sysroots/qemuarm64/usr/include/tcl8.6' > > # String to pass to linker to pick up the Tcl stub library from its > # installed directory. > -TCL_STUB_LIB_SPEC='-L=/home/bjsimics/workspace/poky-os/qemuppc/tmp/sysroots/qemuarm64/usr/lib -ltclstub8.6' > +TCL_STUB_LIB_SPEC='-L/home/bjsimics/workspace/poky-os/qemuppc/tmp/sysroots/qemuarm64/usr/lib -ltclstub8.6' > > 2. tmp/sysroots/qemuarm64/usr/lib/tclConfig.sh > # String to pass to linker to pick up the Tcl library from its > # installed directory. > -TCL_LIB_SPEC='-L=/usr/lib -ltcl8.6' > +TCL_LIB_SPEC='-L/usr/lib -ltcl8.6' > > # String to pass to the compiler so that an extension can > # find installed Tcl headers. > -TCL_INCLUDE_SPEC='-I=/usr/include/tcl8.6' > +TCL_INCLUDE_SPEC='-I/usr/include/tcl8.6' > > # String to pass to linker to pick up the Tcl stub library from its > # installed directory. > -TCL_STUB_LIB_SPEC='-L=/usr/lib -ltclstub8.6' > +TCL_STUB_LIB_SPEC='-L/usr/lib -ltclstub8.6' > > > Best Regards, Thanks for verifying, this looks OK to me. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-07-15 7:35 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-07-05 6:20 [PATCH] tcl: fix INCLUDE_SPEC and LIB_SPEC Zhenhua Luo 2016-07-05 15:15 ` Khem Raj 2016-07-06 4:08 ` Zhenhua Luo 2016-07-15 6:13 ` Zhenhua Luo 2016-07-15 6:23 ` Robert Yang 2016-07-15 7:35 ` Khem Raj
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.