Re: [PATCH 7/8] pc: acpi: memhp: nvdimm hotplug support

[Xiao Guangrong <guangrong.xiao@linux.intel.com>]

On 07/14/2016 08:17 PM, Stefan Hajnoczi wrote:
> On Mon, Jul 11, 2016 at 09:45:17PM +0800, Xiao Guangrong wrote:
>> diff --git a/hw/acpi/memory_hotplug.c b/hw/acpi/memory_hotplug.c
>> index 73fa62d..d1c2e92 100644
>> --- a/hw/acpi/memory_hotplug.c
>> +++ b/hw/acpi/memory_hotplug.c
>> @@ -239,11 +239,6 @@ void acpi_memory_plug_cb(HotplugHandler *hotplug_dev, MemHotplugState *mem_st,
>>                            DeviceState *dev, Error **errp)
>>   {
>>       MemStatus *mdev;
>> -    DeviceClass *dc = DEVICE_GET_CLASS(dev);
>> -
>> -    if (!dc->hotpluggable) {
>> -        return;
>> -    }
>>
>>       mdev = acpi_memory_slot_status(mem_st, dev, errp);
>>       if (!mdev) {
>
> Did you mean to include this hunk in the patch?  Looks like something
> left over from debugging/prototyping.
>

As all memory devices, both pc-dimm and nvdimm, have supported hotplug now, i
think this chunk can be removed.

In fact, this check was introduced by nvdimm. :)