From: Guenter Roeck <linux@roeck-us.net>
To: Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
Wim Van Sebroeck <wim@iguana.be>,
Stephen Warren <swarren@wwwdotorg.org>,
Lee Jones <lee@kernel.org>, Eric Anholt <eric@anholt.net>
Cc: linux-watchdog@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] watchdog: bcm2835_wdt: remove redundant ->set_timeout callback
Date: Fri, 15 Jul 2016 06:47:29 -0700 [thread overview]
Message-ID: <5788E971.2020005@roeck-us.net> (raw)
In-Reply-To: <1468570524-18222-2-git-send-email-rasmus.villemoes@prevas.dk>
On 07/15/2016 01:15 AM, Rasmus Villemoes wrote:
> bcm2835_wdt_set_timeout does exactly what the watchdog framework does
> in the absence of a ->set_timeout callback (see watchdog_set_timeout
> in watchdog_dev.c), so remove it.
>
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/bcm2835_wdt.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/watchdog/bcm2835_wdt.c b/drivers/watchdog/bcm2835_wdt.c
> index 733e402..4dddd82 100644
> --- a/drivers/watchdog/bcm2835_wdt.c
> +++ b/drivers/watchdog/bcm2835_wdt.c
> @@ -82,12 +82,6 @@ static int bcm2835_wdt_stop(struct watchdog_device *wdog)
> return 0;
> }
>
> -static int bcm2835_wdt_set_timeout(struct watchdog_device *wdog, unsigned int t)
> -{
> - wdog->timeout = t;
> - return 0;
> -}
> -
> static unsigned int bcm2835_wdt_get_timeleft(struct watchdog_device *wdog)
> {
> struct bcm2835_wdt *wdt = watchdog_get_drvdata(wdog);
> @@ -100,7 +94,6 @@ static const struct watchdog_ops bcm2835_wdt_ops = {
> .owner = THIS_MODULE,
> .start = bcm2835_wdt_start,
> .stop = bcm2835_wdt_stop,
> - .set_timeout = bcm2835_wdt_set_timeout,
> .get_timeleft = bcm2835_wdt_get_timeleft,
> };
>
>
WARNING: multiple messages have this Message-ID (diff)
From: linux@roeck-us.net (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] watchdog: bcm2835_wdt: remove redundant ->set_timeout callback
Date: Fri, 15 Jul 2016 06:47:29 -0700 [thread overview]
Message-ID: <5788E971.2020005@roeck-us.net> (raw)
In-Reply-To: <1468570524-18222-2-git-send-email-rasmus.villemoes@prevas.dk>
On 07/15/2016 01:15 AM, Rasmus Villemoes wrote:
> bcm2835_wdt_set_timeout does exactly what the watchdog framework does
> in the absence of a ->set_timeout callback (see watchdog_set_timeout
> in watchdog_dev.c), so remove it.
>
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/bcm2835_wdt.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/watchdog/bcm2835_wdt.c b/drivers/watchdog/bcm2835_wdt.c
> index 733e402..4dddd82 100644
> --- a/drivers/watchdog/bcm2835_wdt.c
> +++ b/drivers/watchdog/bcm2835_wdt.c
> @@ -82,12 +82,6 @@ static int bcm2835_wdt_stop(struct watchdog_device *wdog)
> return 0;
> }
>
> -static int bcm2835_wdt_set_timeout(struct watchdog_device *wdog, unsigned int t)
> -{
> - wdog->timeout = t;
> - return 0;
> -}
> -
> static unsigned int bcm2835_wdt_get_timeleft(struct watchdog_device *wdog)
> {
> struct bcm2835_wdt *wdt = watchdog_get_drvdata(wdog);
> @@ -100,7 +94,6 @@ static const struct watchdog_ops bcm2835_wdt_ops = {
> .owner = THIS_MODULE,
> .start = bcm2835_wdt_start,
> .stop = bcm2835_wdt_stop,
> - .set_timeout = bcm2835_wdt_set_timeout,
> .get_timeleft = bcm2835_wdt_get_timeleft,
> };
>
>
next prev parent reply other threads:[~2016-07-15 13:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 8:15 [PATCH 1/3] watchdog: bcm2835_wdt: constify _ops and _info structures Rasmus Villemoes
2016-07-15 8:15 ` Rasmus Villemoes
2016-07-15 8:15 ` [PATCH 2/3] watchdog: bcm2835_wdt: remove redundant ->set_timeout callback Rasmus Villemoes
2016-07-15 8:15 ` Rasmus Villemoes
2016-07-15 13:47 ` Guenter Roeck [this message]
2016-07-15 13:47 ` Guenter Roeck
2016-07-15 18:58 ` Eric Anholt
2016-07-15 18:58 ` Eric Anholt
2016-07-17 20:27 ` Wim Van Sebroeck
2016-07-15 8:15 ` [PATCH 3/3] watchdog: bcm2835_wdt: set WDOG_HW_RUNNING bit when appropriate Rasmus Villemoes
2016-07-15 8:15 ` Rasmus Villemoes
2016-07-15 13:46 ` Guenter Roeck
2016-07-15 13:46 ` Guenter Roeck
2016-07-20 21:37 ` Rasmus Villemoes
2016-07-20 21:37 ` Rasmus Villemoes
2016-07-20 23:47 ` Guenter Roeck
2016-07-20 23:47 ` Guenter Roeck
2016-07-15 13:47 ` [PATCH 1/3] watchdog: bcm2835_wdt: constify _ops and _info structures Guenter Roeck
2016-07-15 13:47 ` Guenter Roeck
2016-07-17 20:26 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5788E971.2020005@roeck-us.net \
--to=linux@roeck-us.net \
--cc=eric@anholt.net \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=rasmus.villemoes@prevas.dk \
--cc=swarren@wwwdotorg.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.