Re: [Qemu-devel] [PATCH v3 1/2] crypto: add support for querying parameters for block encryption

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]

On 06/14/2016 10:33 AM, Max Reitz wrote:
> On 14.06.2016 18:24, Daniel P. Berrange wrote:
>> When creating new block encryption volumes, we accept a list of
>> parameters to control the formatting process. It is useful to
>> be able to query what those parameters were for existing block
>> devices. Add a qcrypto_block_get_info() method which returns a
>> QCryptoBlockInfo instance to report this data.
>>
>> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
>> ---
>>  crypto/block-luks.c    | 67 ++++++++++++++++++++++++++++++++++++++++++++
>>  crypto/block.c         | 17 +++++++++++
>>  crypto/blockpriv.h     |  4 +++
>>  include/crypto/block.h | 16 +++++++++++
>>  qapi/crypto.json       | 76 ++++++++++++++++++++++++++++++++++++++++++++++++++
>>  5 files changed, 180 insertions(+)
> 
> Reviewed-by: Max Reitz <mreitz@redhat.com>
> 
> (I'll be waiting whether Eric wants to comment)

Looks good to me as well; if you'd like you can add

Reviewed-by: Eric Blake <eblake@redhat.com>


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]