Re: [Qemu-devel] [PATCH v3 2/2] trace: [bsd-user] Commandline arguments to control tracing

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 987 bytes --]

On 07/15/2016 11:08 AM, Lluís Vilanova wrote:
> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> ---
>  bsd-user/main.c |   16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 

> @@ -754,6 +760,8 @@ int main(int argc, char **argv)
>  
>      cpu_model = NULL;
>  
> +    qemu_add_opts(&qemu_trace_opts);
> +
>      optind = 1;
>      for(;;) {

Optional, but since you are in the area, you could add the missing space
after 'for'.

>          if (optind >= argc)
> @@ -840,6 +848,9 @@ int main(int argc, char **argv)
>              singlestep = 1;
>          } else if (!strcmp(r, "strace")) {
>              do_strace = 1;
> +        } else if (!strcmp(r, "trace")) {
> +            g_free(trace_file);
> +            trace_file = trace_opt_parse(optarg);
>          } else
>          {

and fix the 'else {' to be on one line.


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]