From: Vegard Nossum <vegard.nossum@oracle.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
sparclinux@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: openpromfs root inode has ino 0
Date: Sun, 17 Jul 2016 12:29:18 +0000 [thread overview]
Message-ID: <578B7A1E.5090500@oracle.com> (raw)
Hi,
I noticed that fs/openpromfs/inode.c has:
#define OPENPROM_ROOT_INO 0
It seems it was originally 16 but was changed to 0 here:
commit 3d824a46b7210ea3b0a13ab0d0fbd7f6e2e91ddf
Author: David S. Miller <davem@davemloft.net>
Date: Sun Jun 25 23:19:14 2006 -0700
[OPENPROMFS]: Rewrite using in-kernel device tree and seq_file.
As far as I understand, inode 0 should never be used and can cause
various things to fail, e.g. my /bin/ls seems to completely ignore
getdents() results which have ->d_ino = 0.
I don't know if it actually causes any problems for people who are
actually using this, and I don't have the means to test the code anyway,
so just a heads up...
Vegard
WARNING: multiple messages have this Message-ID (diff)
From: Vegard Nossum <vegard.nossum@oracle.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
sparclinux@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: openpromfs root inode has ino 0
Date: Sun, 17 Jul 2016 14:29:18 +0200 [thread overview]
Message-ID: <578B7A1E.5090500@oracle.com> (raw)
Hi,
I noticed that fs/openpromfs/inode.c has:
#define OPENPROM_ROOT_INO 0
It seems it was originally 16 but was changed to 0 here:
commit 3d824a46b7210ea3b0a13ab0d0fbd7f6e2e91ddf
Author: David S. Miller <davem@davemloft.net>
Date: Sun Jun 25 23:19:14 2006 -0700
[OPENPROMFS]: Rewrite using in-kernel device tree and seq_file.
As far as I understand, inode 0 should never be used and can cause
various things to fail, e.g. my /bin/ls seems to completely ignore
getdents() results which have ->d_ino = 0.
I don't know if it actually causes any problems for people who are
actually using this, and I don't have the means to test the code anyway,
so just a heads up...
Vegard
next reply other threads:[~2016-07-17 12:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-17 12:29 Vegard Nossum [this message]
2016-07-17 12:29 ` openpromfs root inode has ino 0 Vegard Nossum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=578B7A1E.5090500@oracle.com \
--to=vegard.nossum@oracle.com \
--cc=davem@davemloft.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.