From: Stephen Warren <swarren@wwwdotorg.org>
To: Joseph Lo <josephl@nvidia.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Alexandre Courbot <gnurou@gmail.com>,
linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
Matthew Longnecker <MLongnecker@nvidia.com>,
devicetree@vger.kernel.org, Jassi Brar <jassisinghbrar@gmail.com>,
linux-kernel@vger.kernel.org,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Sivaram Nair <sivaramn@nvidia.com>
Subject: Re: [PATCH V3 01/10] Documentation: dt-bindings: mailbox: tegra: Add binding for HSP mailbox
Date: Tue, 19 Jul 2016 10:36:27 -0600 [thread overview]
Message-ID: <578E570B.8060404@wwwdotorg.org> (raw)
In-Reply-To: <20160719091723.30919-1-josephl@nvidia.com>
On 07/19/2016 03:17 AM, Joseph Lo wrote:
> Add DT binding for the Hardware Synchronization Primitives (HSP). The
> HSP is designed for the processors to share resources and communicate
> together. It provides a set of hardware synchronization primitives for
> interprocessor communication. So the interprocessor communication (IPC)
> protocols can use hardware synchronization primitive, when operating
> between two processors not in an SMP relationship.
Acked-by: Stephen Warren <swarren@nvidia.com>
A couple of nits below that you might want to fix up when posting the
final version of the series; your call.
> diff --git a/include/dt-bindings/mailbox/tegra186-hsp.h b/include/dt-bindings/mailbox/tegra186-hsp.h
> + */
> +
> +
> +#ifndef _DT_BINDINGS_MAILBOX_TEGRA186_HSP_H
Nit: There are 2 blank lines there.
> +#endif /* _DT_BINDINGS_MAILBOX_TEGRA186_HSP_H */
Nit: Personally I hate "filename" comments on the #endif, since it's
just one more place to update if the file moves or is copied.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 01/10] Documentation: dt-bindings: mailbox: tegra: Add binding for HSP mailbox
Date: Tue, 19 Jul 2016 10:36:27 -0600 [thread overview]
Message-ID: <578E570B.8060404@wwwdotorg.org> (raw)
In-Reply-To: <20160719091723.30919-1-josephl@nvidia.com>
On 07/19/2016 03:17 AM, Joseph Lo wrote:
> Add DT binding for the Hardware Synchronization Primitives (HSP). The
> HSP is designed for the processors to share resources and communicate
> together. It provides a set of hardware synchronization primitives for
> interprocessor communication. So the interprocessor communication (IPC)
> protocols can use hardware synchronization primitive, when operating
> between two processors not in an SMP relationship.
Acked-by: Stephen Warren <swarren@nvidia.com>
A couple of nits below that you might want to fix up when posting the
final version of the series; your call.
> diff --git a/include/dt-bindings/mailbox/tegra186-hsp.h b/include/dt-bindings/mailbox/tegra186-hsp.h
> + */
> +
> +
> +#ifndef _DT_BINDINGS_MAILBOX_TEGRA186_HSP_H
Nit: There are 2 blank lines there.
> +#endif /* _DT_BINDINGS_MAILBOX_TEGRA186_HSP_H */
Nit: Personally I hate "filename" comments on the #endif, since it's
just one more place to update if the file moves or is copied.
next prev parent reply other threads:[~2016-07-19 16:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 9:17 [PATCH V3 01/10] Documentation: dt-bindings: mailbox: tegra: Add binding for HSP mailbox Joseph Lo
2016-07-19 9:17 ` Joseph Lo
2016-07-19 9:17 ` Joseph Lo
[not found] ` <20160719091723.30919-1-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-07-19 9:17 ` [PATCH V3 3/10] Documentation: dt-bindings: firmware: tegra: add bindings of the BPMP Joseph Lo
2016-07-19 9:17 ` Joseph Lo
2016-07-19 9:17 ` Joseph Lo
[not found] ` <20160719091723.30919-2-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-07-19 16:37 ` Stephen Warren
2016-07-19 16:37 ` Stephen Warren
2016-07-19 16:37 ` Stephen Warren
2016-07-26 9:50 ` Jon Hunter
2016-07-26 9:50 ` Jon Hunter
2016-07-26 9:50 ` Jon Hunter
2016-07-20 1:22 ` Rob Herring
2016-07-20 1:22 ` Rob Herring
2016-07-20 1:37 ` Joseph Lo
2016-07-20 1:37 ` Joseph Lo
2016-07-20 1:37 ` Joseph Lo
2016-07-20 1:17 ` [PATCH V3 01/10] Documentation: dt-bindings: mailbox: tegra: Add binding for HSP mailbox Rob Herring
2016-07-20 1:17 ` Rob Herring
2016-07-20 1:17 ` Rob Herring
2016-07-19 16:36 ` Stephen Warren [this message]
2016-07-19 16:36 ` Stephen Warren
2016-07-26 9:41 ` Jon Hunter
2016-07-26 9:41 ` Jon Hunter
2016-07-26 9:41 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=578E570B.8060404@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=MLongnecker@nvidia.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=jassisinghbrar@gmail.com \
--cc=josephl@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pdeschrijver@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=sivaramn@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.