From: Dave Hansen <dave.hansen@intel.com>
To: zhouchengming <zhouchengming1@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, tj@kernel.org, guohanjun@huawei.com,
huawei.libin@huawei.com
Subject: Re: [PATCH] make __section_nr more efficient
Date: Thu, 21 Jul 2016 07:38:44 -0700 [thread overview]
Message-ID: <5790DE74.3080907@intel.com> (raw)
In-Reply-To: <57902B8A.8040907@huawei.com>
On 07/20/2016 06:55 PM, zhouchengming wrote:
> Thanks for your reply. I don't know the compiler will optimize the loop.
> But when I see the assembly code of __section_nr, it seems to still have
> the loop in it.
Oh, well. I guess it got broken in the last decade or so. Your patch
looks good to me, and the fact that we ended up here means the original
approach was at least a little fragile.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@intel.com>
To: zhouchengming <zhouchengming1@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, tj@kernel.org, guohanjun@huawei.com,
huawei.libin@huawei.com
Subject: Re: [PATCH] make __section_nr more efficient
Date: Thu, 21 Jul 2016 07:38:44 -0700 [thread overview]
Message-ID: <5790DE74.3080907@intel.com> (raw)
In-Reply-To: <57902B8A.8040907@huawei.com>
On 07/20/2016 06:55 PM, zhouchengming wrote:
> Thanks for your reply. I don't know the compiler will optimize the loop.
> But when I see the assembly code of __section_nr, it seems to still have
> the loop in it.
Oh, well. I guess it got broken in the last decade or so. Your patch
looks good to me, and the fact that we ended up here means the original
approach was at least a little fragile.
next prev parent reply other threads:[~2016-07-21 14:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 4:18 [PATCH] make __section_nr more efficient Zhou Chengming
2016-07-20 4:18 ` Zhou Chengming
2016-07-20 21:36 ` Dave Hansen
2016-07-20 21:36 ` Dave Hansen
2016-07-21 1:55 ` zhouchengming
2016-07-21 1:55 ` zhouchengming
2016-07-21 14:38 ` Dave Hansen [this message]
2016-07-21 14:38 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5790DE74.3080907@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=guohanjun@huawei.com \
--cc=huawei.libin@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tj@kernel.org \
--cc=zhouchengming1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.