Re: [Qemu-devel] [PATCH v22 02/10] Backup: clear all bitmap when doing block checkpoint

[Changlong Xie <xiecl.fnst@cn.fujitsu.com>]

On 07/26/2016 05:18 AM, Max Reitz wrote:
> On 22.07.2016 12:15, Wang WeiWei wrote:
>> From: Wen Congyang <wency@cn.fujitsu.com>
>>
>> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
>> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
>> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
>> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
>> Signed-off-by: Wang WeiWei <wangww.fnst@cn.fujitsu.com>
>> ---
>>   block/backup.c               | 18 ++++++++++++++++++
>>   include/block/block_backup.h |  3 +++
>>   2 files changed, 21 insertions(+)
>>   create mode 100644 include/block/block_backup.h
>
> [...]
>
>> diff --git a/include/block/block_backup.h b/include/block/block_backup.h
>> new file mode 100644
>> index 0000000..3753bcb
>> --- /dev/null
>> +++ b/include/block/block_backup.h
>> @@ -0,0 +1,3 @@
>> +#include "block/block_int.h"
>> +
>> +void backup_do_checkpoint(BlockJob *job, Error **errp);
>
> Include guards and copyright notice missing. I don't mind the missing
> copyright notice because it will default to GPL anyway. Also, I

I think i can copy the Copyright from backup.c and update it

> personally don't really mind the missing include guards, but I thought

Btw i'll add #ifndef...#define...#endif in next version

> I'd say something anyway.

warm welcome

>
> Max
>