From: Guenter Roeck <linux@roeck-us.net>
To: Caesar Wang <wxt@rock-chips.com>, jic23@kernel.org, heiko@sntech.de
Cc: devicetree@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, dianders@chromium.org,
linux-rockchip@lists.infradead.org, robh+dt@kernel.org,
john@metanate.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 3/4] arm64: dts: rockchip: add reset saradc node for rk3368 SoCs
Date: Wed, 27 Jul 2016 07:51:33 -0700 [thread overview]
Message-ID: <5798CA75.3010202@roeck-us.net> (raw)
In-Reply-To: <1469629447-544-3-git-send-email-wxt@rock-chips.com>
On 07/27/2016 07:24 AM, Caesar Wang wrote:
> SARADC controller needs to be reset before programming it, otherwise
> it will not function properly.
>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
>
> Changes in v3:
> - add Doug's reviewed tag.
>
Not to this patch ?
> Changes in v2: None
>
> arch/arm64/boot/dts/rockchip/rk3368.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> index d02a9003..4f44d11 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> @@ -270,6 +270,8 @@
> #io-channel-cells = <1>;
> clocks = <&cru SCLK_SARADC>, <&cru PCLK_SARADC>;
> clock-names = "saradc", "apb_pclk";
> + resets = <&cru SRST_SARADC>;
> + reset-names = "saradc-apb";
> status = "disabled";
> };
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
To: Caesar Wang <wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
john-HooS5bfzL4hWk0Htik3J/w@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v3 3/4] arm64: dts: rockchip: add reset saradc node for rk3368 SoCs
Date: Wed, 27 Jul 2016 07:51:33 -0700 [thread overview]
Message-ID: <5798CA75.3010202@roeck-us.net> (raw)
In-Reply-To: <1469629447-544-3-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
On 07/27/2016 07:24 AM, Caesar Wang wrote:
> SARADC controller needs to be reset before programming it, otherwise
> it will not function properly.
>
> Signed-off-by: Caesar Wang <wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Reviewed-by: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
> ---
>
> Changes in v3:
> - add Doug's reviewed tag.
>
Not to this patch ?
> Changes in v2: None
>
> arch/arm64/boot/dts/rockchip/rk3368.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> index d02a9003..4f44d11 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> @@ -270,6 +270,8 @@
> #io-channel-cells = <1>;
> clocks = <&cru SCLK_SARADC>, <&cru PCLK_SARADC>;
> clock-names = "saradc", "apb_pclk";
> + resets = <&cru SRST_SARADC>;
> + reset-names = "saradc-apb";
> status = "disabled";
> };
>
>
WARNING: multiple messages have this Message-ID (diff)
From: linux@roeck-us.net (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/4] arm64: dts: rockchip: add reset saradc node for rk3368 SoCs
Date: Wed, 27 Jul 2016 07:51:33 -0700 [thread overview]
Message-ID: <5798CA75.3010202@roeck-us.net> (raw)
In-Reply-To: <1469629447-544-3-git-send-email-wxt@rock-chips.com>
On 07/27/2016 07:24 AM, Caesar Wang wrote:
> SARADC controller needs to be reset before programming it, otherwise
> it will not function properly.
>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
>
> Changes in v3:
> - add Doug's reviewed tag.
>
Not to this patch ?
> Changes in v2: None
>
> arch/arm64/boot/dts/rockchip/rk3368.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> index d02a9003..4f44d11 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> @@ -270,6 +270,8 @@
> #io-channel-cells = <1>;
> clocks = <&cru SCLK_SARADC>, <&cru PCLK_SARADC>;
> clock-names = "saradc", "apb_pclk";
> + resets = <&cru SRST_SARADC>;
> + reset-names = "saradc-apb";
> status = "disabled";
> };
>
>
next prev parent reply other threads:[~2016-07-27 14:51 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-27 14:24 [PATCH v3 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it Caesar Wang
2016-07-27 14:24 ` Caesar Wang
2016-07-27 14:24 ` Caesar Wang
2016-07-27 14:24 ` [PATCH v3 2/4] arm64: dts: rockchip: add the saradc for rk3399 Caesar Wang
2016-07-27 14:24 ` Caesar Wang
2016-07-27 14:50 ` Guenter Roeck
2016-07-27 14:50 ` Guenter Roeck
2016-07-27 14:50 ` Guenter Roeck
2016-08-24 9:32 ` Heiko Stübner
2016-08-24 9:32 ` Heiko Stübner
2016-07-27 14:24 ` [PATCH v3 3/4] arm64: dts: rockchip: add reset saradc node for rk3368 SoCs Caesar Wang
2016-07-27 14:24 ` Caesar Wang
2016-07-27 14:24 ` Caesar Wang
2016-07-27 14:51 ` Guenter Roeck [this message]
2016-07-27 14:51 ` Guenter Roeck
2016-07-27 14:51 ` Guenter Roeck
2016-08-22 17:19 ` Heiko Stuebner
2016-08-22 17:19 ` Heiko Stuebner
2016-08-22 17:19 ` Heiko Stuebner
2016-08-23 18:08 ` Jonathan Cameron
2016-08-23 18:08 ` Jonathan Cameron
2016-08-23 18:08 ` Jonathan Cameron
2016-07-27 14:24 ` [PATCH v3 4/4] arm: dts: rockchip: add reset node for the exist saradc SoCs Caesar Wang
2016-07-27 14:24 ` Caesar Wang
2016-07-27 14:52 ` Guenter Roeck
2016-07-27 14:52 ` Guenter Roeck
2016-07-27 14:52 ` Guenter Roeck
2016-08-22 17:20 ` Heiko Stuebner
2016-08-22 17:20 ` Heiko Stuebner
2016-08-22 17:20 ` Heiko Stuebner
2016-08-23 18:09 ` Jonathan Cameron
2016-08-23 18:09 ` Jonathan Cameron
2016-08-23 18:09 ` Jonathan Cameron
2016-07-27 14:47 ` [PATCH v3 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it Peter Meerwald-Stadler
2016-07-27 14:47 ` Peter Meerwald-Stadler
2016-07-29 23:21 ` Caesar Wang
2016-07-29 23:21 ` Caesar Wang
2016-07-29 23:21 ` Caesar Wang
2016-07-27 14:50 ` Guenter Roeck
2016-07-27 14:50 ` Guenter Roeck
2016-07-29 21:28 ` Rob Herring
2016-07-29 21:28 ` Rob Herring
2016-07-29 21:28 ` Rob Herring
2016-07-29 23:13 ` Caesar Wang
2016-07-29 23:13 ` Caesar Wang
2016-07-29 23:13 ` Caesar Wang
2016-07-29 23:13 ` Caesar Wang
2016-07-29 23:13 ` Caesar Wang
2016-07-29 23:13 ` Caesar Wang
2016-08-15 17:41 ` Jonathan Cameron
2016-08-15 17:41 ` Jonathan Cameron
2016-08-15 17:41 ` Jonathan Cameron
2016-08-15 17:43 ` Jonathan Cameron
2016-08-15 17:43 ` Jonathan Cameron
2016-08-15 17:43 ` Jonathan Cameron
2016-08-15 18:10 ` Caesar Wang
[not found] ` <57B20584.3090502-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-08-21 19:11 ` Jonathan Cameron
2016-08-21 19:11 ` Jonathan Cameron
2016-08-21 20:01 ` Jonathan Cameron
2016-08-21 20:01 ` Jonathan Cameron
2016-08-21 20:01 ` Jonathan Cameron
2016-08-22 17:19 ` Heiko Stuebner
2016-08-22 17:19 ` Heiko Stuebner
2016-08-22 17:19 ` Heiko Stuebner
2016-08-23 18:08 ` Jonathan Cameron
2016-08-23 18:08 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5798CA75.3010202@roeck-us.net \
--to=linux@roeck-us.net \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=jic23@kernel.org \
--cc=john@metanate.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.