From: David Daney <ddaney-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Jan Glauber
<jan.glauber-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>,
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Steven J. Hill"
<steven.hill-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>,
David Daney <david.daney-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 6/6] spi: octeon: Add thunderx driver
Date: Wed, 27 Jul 2016 11:25:10 -0700 [thread overview]
Message-ID: <5798FC86.8040601@caviumnetworks.com> (raw)
In-Reply-To: <20160727181205.GT11806-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On 07/27/2016 11:12 AM, Mark Brown wrote:
> On Mon, Jul 25, 2016 at 09:31:15AM -0700, David Daney wrote:
>> On 07/25/2016 09:16 AM, Mark Brown wrote:
>
>>> The usual pattern would be something like (ARCH_THUNDER || COMPILE_TEST)
>>> && PCI && 64BIT (so that people on other platforms where the device will
>>> never actually appear don't get bothered by the prompt).
>
>> ARCH_THUNDER needs to die, so perhaps it should be (ARM64 || COMPILE_TEST)
>> && PCI && 64BIT if you really want to hide it from non-arm64 kernel configs.
>
> It does? Why?
It adds clutter. If we build a generic kernel, we first must select all
the ARCH_*, then go back and select the devices we want. Not much of a
value add.
Better to just directly select the devices and remove this middle ARCH_*
layer.
Also who is responsible for making sure the proper ARCH_* constraints
are maintained? If we remove ARCH_THUNDER, no need to worry about this.
> One of the functions of the vendor specific Kconfig
> options is to improve UX when configuring the kernel, if you're building
> for a particular SoC or set of SoCs then we can avoid showing you
> drivers that can never possibly appear in your system which makes life
> a bit easier. We shouldn't be using them in the code itself but they do
> help people in Kconfig.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: David Daney <ddaney@caviumnetworks.com>
To: Mark Brown <broonie@kernel.org>
Cc: Jan Glauber <jan.glauber@caviumnetworks.com>,
<linux-kernel@vger.kernel.org>, <linux-spi@vger.kernel.org>,
"Steven J. Hill" <steven.hill@cavium.com>,
David Daney <david.daney@cavium.com>
Subject: Re: [PATCH 6/6] spi: octeon: Add thunderx driver
Date: Wed, 27 Jul 2016 11:25:10 -0700 [thread overview]
Message-ID: <5798FC86.8040601@caviumnetworks.com> (raw)
In-Reply-To: <20160727181205.GT11806@sirena.org.uk>
On 07/27/2016 11:12 AM, Mark Brown wrote:
> On Mon, Jul 25, 2016 at 09:31:15AM -0700, David Daney wrote:
>> On 07/25/2016 09:16 AM, Mark Brown wrote:
>
>>> The usual pattern would be something like (ARCH_THUNDER || COMPILE_TEST)
>>> && PCI && 64BIT (so that people on other platforms where the device will
>>> never actually appear don't get bothered by the prompt).
>
>> ARCH_THUNDER needs to die, so perhaps it should be (ARM64 || COMPILE_TEST)
>> && PCI && 64BIT if you really want to hide it from non-arm64 kernel configs.
>
> It does? Why?
It adds clutter. If we build a generic kernel, we first must select all
the ARCH_*, then go back and select the devices we want. Not much of a
value add.
Better to just directly select the devices and remove this middle ARCH_*
layer.
Also who is responsible for making sure the proper ARCH_* constraints
are maintained? If we remove ARCH_THUNDER, no need to worry about this.
> One of the functions of the vendor specific Kconfig
> options is to improve UX when configuring the kernel, if you're building
> for a particular SoC or set of SoCs then we can avoid showing you
> drivers that can never possibly appear in your system which makes life
> a bit easier. We shouldn't be using them in the code itself but they do
> help people in Kconfig.
>
next prev parent reply other threads:[~2016-07-27 18:25 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-23 10:42 [PATCH 0/6] SPI ThunderX driver Jan Glauber
2016-07-23 10:42 ` Jan Glauber
2016-07-23 10:42 ` [PATCH 1/6] spi: octeon: Convert driver to use readq()/writeq() functions Jan Glauber
2016-07-23 10:42 ` [PATCH 2/6] spi: octeon: Store system clock freqency in struct octeon_spi Jan Glauber
2016-07-23 10:42 ` [PATCH 3/6] spi: octeon: Put register offsets into a struct Jan Glauber
2016-07-23 10:42 ` [PATCH 4/6] spi: octeon: Move include file from arch/mips to drivers/spi Jan Glauber
2016-07-23 10:42 ` [PATCH 5/6] spi: octeon: Split driver into Octeon specific and common parts Jan Glauber
2016-07-24 18:38 ` Paul Gortmaker
[not found] ` <CAP=VYLrQDwCfYFCkxd0N4PfgP-2U+pcw_Gm0Yo_8m0=0o3pBrA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-25 11:32 ` Jan Glauber
2016-07-25 11:32 ` Jan Glauber
[not found] ` <edfc55f3653fedd5e13a8bd1282e089b269a4e61.1469174814.git.jglauber-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
2016-07-24 20:54 ` Mark Brown
2016-07-24 20:54 ` Mark Brown
[not found] ` <20160724205416.GA6345-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-07-25 11:37 ` Jan Glauber
2016-07-25 11:37 ` Jan Glauber
2016-07-25 17:49 ` [PATCH v2] " Jan Glauber
2016-07-25 17:49 ` Jan Glauber
2016-07-23 10:42 ` [PATCH 6/6] spi: octeon: Add thunderx driver Jan Glauber
[not found] ` <f87d7a5ef8a713fb6e64c5d9471e7e5bf2051d18.1469174814.git.jglauber-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
2016-07-24 21:04 ` Mark Brown
2016-07-24 21:04 ` Mark Brown
[not found] ` <20160724210452.GB6345-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-07-25 15:51 ` Jan Glauber
2016-07-25 15:51 ` Jan Glauber
2016-07-25 16:16 ` Mark Brown
[not found] ` <20160725161632.GD11806-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-07-25 16:31 ` David Daney
2016-07-25 16:31 ` David Daney
2016-07-25 17:56 ` [PATCH v2] " Jan Glauber
[not found] ` <20160725175622.7167-1-jglauber-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
2016-07-27 18:08 ` Mark Brown
2016-07-27 18:08 ` Mark Brown
[not found] ` <20160727180824.GS11806-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-07-28 8:12 ` Jan Glauber
2016-07-28 8:12 ` Jan Glauber
2016-07-28 13:58 ` Mark Brown
2016-07-28 13:58 ` Mark Brown
[not found] ` <57963ED3.4090402-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2016-07-27 18:12 ` [PATCH 6/6] " Mark Brown
2016-07-27 18:12 ` Mark Brown
[not found] ` <20160727181205.GT11806-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-07-27 18:25 ` David Daney [this message]
2016-07-27 18:25 ` David Daney
[not found] ` <5798FC86.8040601-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2016-07-27 19:08 ` Mark Brown
2016-07-27 19:08 ` Mark Brown
2016-07-25 16:20 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5798FC86.8040601@caviumnetworks.com \
--to=ddaney-m3mlkvoiwjvv6pq1l3v1odbpr1lh4cv8@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=david.daney-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
--cc=jan.glauber-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=steven.hill-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.