From: Timur Tabi <timur@codeaurora.org>
To: Sinan Kaya <okaya@codeaurora.org>,
dmaengine@vger.kernel.org, cov@codeaurora.org
Cc: linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] dmaengine: qcom_hidma: release the descriptor before the callback
Date: Sun, 31 Jul 2016 09:13:48 -0500 [thread overview]
Message-ID: <579E079C.2040500@codeaurora.org> (raw)
In-Reply-To: <1469974266-28023-1-git-send-email-okaya@codeaurora.org>
Sinan Kaya wrote:
> + list_for_each_entry_safe(mdesc, next, &list, node) {
> enum dma_status llstat;
> + dma_async_tx_callback callback;
> + void *param;
>
> desc = &mdesc->desc;
>
> @@ -132,18 +135,19 @@ static void hidma_process_completed(struct hidma_chan *mchan)
> spin_unlock_irqrestore(&mchan->lock, irqflags);
>
> llstat = hidma_ll_status(mdma->lldev, mdesc->tre_ch);
> - if (desc->callback && (llstat == DMA_COMPLETE))
> - desc->callback(desc->callback_param);
> + callback = desc->callback;
> + param = desc->callback_param;
It looks to me like 'callback' and 'param' are never actually used.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.
WARNING: multiple messages have this Message-ID (diff)
From: timur@codeaurora.org (Timur Tabi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] dmaengine: qcom_hidma: release the descriptor before the callback
Date: Sun, 31 Jul 2016 09:13:48 -0500 [thread overview]
Message-ID: <579E079C.2040500@codeaurora.org> (raw)
In-Reply-To: <1469974266-28023-1-git-send-email-okaya@codeaurora.org>
Sinan Kaya wrote:
> + list_for_each_entry_safe(mdesc, next, &list, node) {
> enum dma_status llstat;
> + dma_async_tx_callback callback;
> + void *param;
>
> desc = &mdesc->desc;
>
> @@ -132,18 +135,19 @@ static void hidma_process_completed(struct hidma_chan *mchan)
> spin_unlock_irqrestore(&mchan->lock, irqflags);
>
> llstat = hidma_ll_status(mdma->lldev, mdesc->tre_ch);
> - if (desc->callback && (llstat == DMA_COMPLETE))
> - desc->callback(desc->callback_param);
> + callback = desc->callback;
> + param = desc->callback_param;
It looks to me like 'callback' and 'param' are never actually used.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.
next prev parent reply other threads:[~2016-07-31 14:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-31 14:11 [PATCH V2] dmaengine: qcom_hidma: release the descriptor before the callback Sinan Kaya
2016-07-31 14:11 ` Sinan Kaya
2016-07-31 14:13 ` Timur Tabi [this message]
2016-07-31 14:13 ` Timur Tabi
2016-07-31 14:14 ` Timur Tabi
2016-07-31 14:14 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=579E079C.2040500@codeaurora.org \
--to=timur@codeaurora.org \
--cc=cov@codeaurora.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=okaya@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.