From: Luis de Bethencourt <luisbg@osg.samsung.com>
To: Salah Triki <salah.triki@gmail.com>,
akpm@linux-foundation.org, viro@zeniv.linux.org.uk
Cc: mhocko@suse.com, vdavydov@virtuozzo.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] fs: befs: remove in vain variable assignment
Date: Mon, 01 Aug 2016 15:17:03 +0100 [thread overview]
Message-ID: <579F59DF.7090909@osg.samsung.com> (raw)
In-Reply-To: <db27f075476c7bb16f7a0a7332eb1f141dfe5f24.1469997250.git.salah.triki@gmail.com>
On 31/07/16 21:34, Salah Triki wrote:
> There is no need to init res, since it will be overwitten later by
> befs_fblock2brun().
>
> Signed-off-by: Salah Triki <salah.triki@gmail.com>
> ---
> fs/befs/linuxvfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c
> index 6bc5b40..2b68c81 100644
> --- a/fs/befs/linuxvfs.c
> +++ b/fs/befs/linuxvfs.c
> @@ -120,7 +120,7 @@ befs_get_block(struct inode *inode, sector_t block,
> struct super_block *sb = inode->i_sb;
> befs_data_stream *ds = &BEFS_I(inode)->i_data.ds;
> befs_block_run run = BAD_IADDR;
> - int res = 0;
> + int res;
> ulong disk_off;
>
> befs_debug(sb, "---> befs_get_block() for inode %lu, block %ld",
>
Looks good.
Thanks Salah,
Luis
Acked-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Pushed to the befs-next branch:
https://github.com/luisbg/linux-befs/tree/befs-next
next prev parent reply other threads:[~2016-08-01 14:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-31 20:34 [PATCH 1/6] fs: befs: remove unneeded initialization to zero Salah Triki
2016-07-31 20:34 ` [PATCH 2/6] fs: befs: remove in vain variable assignment Salah Triki
2016-08-01 13:24 ` Luis de Bethencourt
2016-08-06 18:35 ` Salah Triki
2016-07-31 20:34 ` [PATCH 3/6] fs: befs: remove useless initialization to zero Salah Triki
2016-08-01 13:44 ` Luis de Bethencourt
2016-08-06 18:36 ` Salah Triki
2016-07-31 20:34 ` [PATCH 4/6] fs: befs: remove unnecessary *befs_sb variable Salah Triki
2016-08-01 14:02 ` Luis de Bethencourt
2016-08-06 18:37 ` Salah Triki
2016-07-31 20:34 ` [PATCH 5/6] fs: befs: remove in vain variable assignment Salah Triki
2016-08-01 14:17 ` Luis de Bethencourt [this message]
2016-07-31 20:34 ` [PATCH 6/6] fs: befs: remove ret variable Salah Triki
2016-08-01 14:23 ` Luis de Bethencourt
2016-08-01 12:51 ` [PATCH 1/6] fs: befs: remove unneeded initialization to zero Luis de Bethencourt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=579F59DF.7090909@osg.samsung.com \
--to=luisbg@osg.samsung.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=salah.triki@gmail.com \
--cc=vdavydov@virtuozzo.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.