From: Jose Abreu <Jose.Abreu@synopsys.com>
To: Russell King - ARM Linux <linux@armlinux.org.uk>,
Jose Abreu <Jose.Abreu@synopsys.com>
Cc: dri-devel@lists.freedesktop.org,
Carlos Palminha <CARLOS.PALMINHA@synopsys.com>,
Archit Taneja <architt@codeaurora.org>,
David Airlie <airlied@linux.ie>,
Fabio Estevam <fabio.estevam@freescale.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Takashi Iwai <tiwai@suse.de>,
Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>,
Thierry Reding <treding@nvidia.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to .detect() callback
Date: Thu, 4 Aug 2016 14:58:00 +0100 [thread overview]
Message-ID: <57A349E8.5040400@synopsys.com> (raw)
In-Reply-To: <20160804104738.GR1041@n2100.armlinux.org.uk>
Hi Russell,
On 04-08-2016 11:47, Russell King - ARM Linux wrote:
> On Thu, Aug 04, 2016 at 11:44:51AM +0100, Jose Abreu wrote:
>> When running HDMI compliance tests we noticed that sometimes
>> the edid changes but the get_modes() function is not called
>> so the edid is not updated. Moving the edid reading to the
>> detect() callback ensures that the edid is correctly updated
>> after an hotplug.
> Wouldn't this be a bug in the higher levels of DRM?
>
I am not sure if this is a bug in DRM or a bad implementation of
dw-hdmi. I've seen at least two more drivers that do the edid
reading at the .detect() callback: nouveau and gma500. This is
noticeable if while sending video the edid changes like in a
compliance environment. In the environment that I tested I was
sending video and swapped an edid that had support for AI packets
to another one without support and I noticed that although the
hotplug is generated the edid was not being updated.
Best regards,
Jose Miguel Abreu
WARNING: multiple messages have this Message-ID (diff)
From: Jose Abreu <Jose.Abreu@synopsys.com>
To: Russell King - ARM Linux <linux@armlinux.org.uk>,
Jose Abreu <Jose.Abreu@synopsys.com>
Cc: <dri-devel@lists.freedesktop.org>,
Carlos Palminha <CARLOS.PALMINHA@synopsys.com>,
Archit Taneja <architt@codeaurora.org>,
David Airlie <airlied@linux.ie>,
Fabio Estevam <fabio.estevam@freescale.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Takashi Iwai <tiwai@suse.de>,
Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>,
Thierry Reding <treding@nvidia.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to .detect() callback
Date: Thu, 4 Aug 2016 14:58:00 +0100 [thread overview]
Message-ID: <57A349E8.5040400@synopsys.com> (raw)
In-Reply-To: <20160804104738.GR1041@n2100.armlinux.org.uk>
Hi Russell,
On 04-08-2016 11:47, Russell King - ARM Linux wrote:
> On Thu, Aug 04, 2016 at 11:44:51AM +0100, Jose Abreu wrote:
>> When running HDMI compliance tests we noticed that sometimes
>> the edid changes but the get_modes() function is not called
>> so the edid is not updated. Moving the edid reading to the
>> detect() callback ensures that the edid is correctly updated
>> after an hotplug.
> Wouldn't this be a bug in the higher levels of DRM?
>
I am not sure if this is a bug in DRM or a bad implementation of
dw-hdmi. I've seen at least two more drivers that do the edid
reading at the .detect() callback: nouveau and gma500. This is
noticeable if while sending video the edid changes like in a
compliance environment. In the environment that I tested I was
sending video and swapped an edid that had support for AI packets
to another one without support and I noticed that although the
hotplug is generated the edid was not being updated.
Best regards,
Jose Miguel Abreu
next prev parent reply other threads:[~2016-08-04 13:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 10:44 [PATCH 0/3 v3] drm: bridge/dw-hdmi: Fixes for dw-hdmi and DWC support Jose Abreu
2016-08-04 10:44 ` [PATCH 1/3 v3] drm: bridge/dw-hdmi: Add support for DWC Phy Jose Abreu
2016-08-04 10:44 ` [PATCH 2/3 v3] drm: bridge/dw-hdmi: Enable ISCR1, ISCR2 and ACP packets Jose Abreu
2016-08-04 15:32 ` Russell King - ARM Linux
2016-08-04 16:18 ` Jose Abreu
2016-08-04 16:18 ` Jose Abreu
2016-08-04 10:44 ` [PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to .detect() callback Jose Abreu
2016-08-04 10:47 ` Russell King - ARM Linux
2016-08-04 13:58 ` Jose Abreu [this message]
2016-08-04 13:58 ` Jose Abreu
2016-08-04 14:31 ` Russell King - ARM Linux
2016-08-04 14:57 ` Jose Abreu
2016-08-04 14:57 ` Jose Abreu
2016-08-04 15:04 ` Russell King - ARM Linux
2016-08-04 17:13 ` Jose Abreu
2016-08-04 17:13 ` Jose Abreu
2016-08-04 23:01 ` Russell King - ARM Linux
2016-08-05 8:06 ` Daniel Vetter
2016-08-05 8:06 ` Daniel Vetter
2016-08-05 8:13 ` Chris Wilson
2016-08-08 16:25 ` Jose Abreu
2016-08-08 16:25 ` Jose Abreu
2016-08-09 6:09 ` Daniel Vetter
2016-08-09 6:09 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57A349E8.5040400@synopsys.com \
--to=jose.abreu@synopsys.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=airlied@linux.ie \
--cc=architt@codeaurora.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabio.estevam@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=tiwai@suse.de \
--cc=treding@nvidia.com \
--cc=vladimir_zapolskiy@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.