Re: [PATCH] ASoC: nau8810: Add driver for Nuvoton codec chip NAU88C10

[John Hsu <KCHSU0@nuvoton.com>]

Hi,

On 8/8/2016 11:18 PM, Mark Brown wrote:
> On Mon, Aug 08, 2016 at 10:27:38AM +0800, John Hsu wrote:
>   
>> On 8/5/2016 8:08 PM, Mark Brown wrote:
>>     
>
>   
>>> What does the read actually look like on this device?
>>>       
>
>   
>> The data read from codec by the IIC bus is as the following.
>> 0 0 0 0 0 0 0 D8 ACK D7 D6 D5 D4 D3 D2 D1 D0
>> The bottom 9 bits are the real register value. The nau8810_reg_read
>> in driver is made by the formate.
>>     
>
> So there's really only one read "register"?  If that's the case I'd
> just open code the read and not bother with regmap, it's probably more
> trouble than it's worth.  There are other 7x9 CODECs that do the same
> thing.
>   

The most registers of the codec are for write function. Only a
little is read only, and they are all static value. I understand
your concern and agree that. I can take off the register read and
write function in the driver. Thanks for your advice.