All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Hsu <KCHSU0@nuvoton.com>
To: Mark Brown <broonie@kernel.org>
Cc: WTLI@nuvoton.com, YHCHuang@nuvoton.com,
	alsa-devel@alsa-project.org, CTLIN0@nuvoton.com,
	lgirdwood@gmail.com
Subject: Re: [PATCH] ASoC: nau8810: Add driver for Nuvoton codec chip NAU88C10
Date: Fri, 19 Aug 2016 10:51:22 +0800	[thread overview]
Message-ID: <57B6742A.7030301@nuvoton.com> (raw)
In-Reply-To: <20160818182439.GT9347@sirena.org.uk>

On 8/19/2016 2:24 AM, Mark Brown wrote:
> On Thu, Aug 18, 2016 at 09:04:12AM +0800, John Hsu wrote:
>   
>> On 8/17/2016 5:42 PM, Mark Brown wrote:
>>     
>
>   
>>> The whole point with raw read is that it isn't reformatting the value.
>>>       
>
>   
>> I post the partial function. The format_val is not valid for our
>> codec driver and we can't use the regmap_raw_read(). It's the reason
>> that we need to make the function like regmap_raw_read().
>>     
>
> Hrm, and you can't just make raw read work because other users are
> relying on the native endianness for single reads so bulk_read() then
> for the actual I/O?  At a bare minimum you need to provide comments in
> the code explaining what's going on, at the minute it looks like
> something that needs cleaning up.
>   

I'll have comment for details. Thank you for the advice.

  reply	other threads:[~2016-08-19  2:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-15  9:02 [PATCH] ASoC: nau8810: Add driver for Nuvoton codec chip NAU88C10 John Hsu
2016-08-15 14:06 ` Mark Brown
2016-08-16  3:57   ` John Hsu
2016-08-16 10:38     ` Mark Brown
2016-08-17  0:34       ` John Hsu
2016-08-17  9:42         ` Mark Brown
2016-08-18  1:04           ` John Hsu
2016-08-18 18:24             ` Mark Brown
2016-08-19  2:51               ` John Hsu [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-08-19  9:24 John Hsu
2016-06-17  8:40 John Hsu
2016-06-27 17:15 ` Mark Brown
2016-07-01  3:34   ` John Hsu
2016-07-01 10:04     ` Mark Brown
2016-07-04  3:34       ` John Hsu
2016-08-05 12:08         ` Mark Brown
2016-08-08  2:27           ` John Hsu
2016-08-08 15:18             ` Mark Brown
2016-08-09  2:09               ` John Hsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57B6742A.7030301@nuvoton.com \
    --to=kchsu0@nuvoton.com \
    --cc=CTLIN0@nuvoton.com \
    --cc=WTLI@nuvoton.com \
    --cc=YHCHuang@nuvoton.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.