From: thunder.leizhen@huawei.com (Leizhen (ThunderTown))
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 03/14] arm64/numa: add nid check for memory block
Date: Wed, 10 Aug 2016 11:42:19 +0800 [thread overview]
Message-ID: <57AAA29B.9060608@huawei.com> (raw)
In-Reply-To: <57AA8D9B.7010102@huawei.com>
On 2016/8/10 10:12, Hanjun Guo wrote:
> On 2016/8/8 17:18, Zhen Lei wrote:
>> Use the same tactic to cpu and numa-distance nodes.
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>> ---
>> arch/arm64/mm/numa.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/mm/numa.c b/arch/arm64/mm/numa.c
>> index c7fe3ec..2601660 100644
>> --- a/arch/arm64/mm/numa.c
>> +++ b/arch/arm64/mm/numa.c
>> @@ -141,6 +141,11 @@ int __init numa_add_memblk(int nid, u64 start, u64 end)
>> {
>> int ret;
>>
>> + if (nid >= MAX_NUMNODES) {
>> + pr_warn("NUMA: Node id %u exceeds maximum value\n", nid);
>> + return -EINVAL;
>> + }
>
> I think this check should be added to of_numa_parse_memory_nodes(), which before
> the numa_add_memblk() called, it's the same logic in of_numa_parse_cpu_nodes() and
> the node id is checked before calling numa_add_memblk() in ACPI.
Yes, you are right. This check is arch independent.
>
> Thanks
> Hanjun
>
>
>
> .
>
WARNING: multiple messages have this Message-ID (diff)
From: "Leizhen (ThunderTown)" <thunder.leizhen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: Hanjun Guo <guohanjun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
linux-arm-kernel
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
linux-kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Frank Rowand
<frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: Zefan Li <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
Xinwei Hu <huxinwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
Tianhong Ding
<dingtianhong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v5 03/14] arm64/numa: add nid check for memory block
Date: Wed, 10 Aug 2016 11:42:19 +0800 [thread overview]
Message-ID: <57AAA29B.9060608@huawei.com> (raw)
In-Reply-To: <57AA8D9B.7010102-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
On 2016/8/10 10:12, Hanjun Guo wrote:
> On 2016/8/8 17:18, Zhen Lei wrote:
>> Use the same tactic to cpu and numa-distance nodes.
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
>> ---
>> arch/arm64/mm/numa.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/mm/numa.c b/arch/arm64/mm/numa.c
>> index c7fe3ec..2601660 100644
>> --- a/arch/arm64/mm/numa.c
>> +++ b/arch/arm64/mm/numa.c
>> @@ -141,6 +141,11 @@ int __init numa_add_memblk(int nid, u64 start, u64 end)
>> {
>> int ret;
>>
>> + if (nid >= MAX_NUMNODES) {
>> + pr_warn("NUMA: Node id %u exceeds maximum value\n", nid);
>> + return -EINVAL;
>> + }
>
> I think this check should be added to of_numa_parse_memory_nodes(), which before
> the numa_add_memblk() called, it's the same logic in of_numa_parse_cpu_nodes() and
> the node id is checked before calling numa_add_memblk() in ACPI.
Yes, you are right. This check is arch independent.
>
> Thanks
> Hanjun
>
>
>
> .
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Hanjun Guo <guohanjun@huawei.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
"Frank Rowand" <frowand.list@gmail.com>,
devicetree <devicetree@vger.kernel.org>
Cc: Zefan Li <lizefan@huawei.com>, Xinwei Hu <huxinwei@huawei.com>,
"Tianhong Ding" <dingtianhong@huawei.com>
Subject: Re: [PATCH v5 03/14] arm64/numa: add nid check for memory block
Date: Wed, 10 Aug 2016 11:42:19 +0800 [thread overview]
Message-ID: <57AAA29B.9060608@huawei.com> (raw)
In-Reply-To: <57AA8D9B.7010102@huawei.com>
On 2016/8/10 10:12, Hanjun Guo wrote:
> On 2016/8/8 17:18, Zhen Lei wrote:
>> Use the same tactic to cpu and numa-distance nodes.
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>> ---
>> arch/arm64/mm/numa.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/mm/numa.c b/arch/arm64/mm/numa.c
>> index c7fe3ec..2601660 100644
>> --- a/arch/arm64/mm/numa.c
>> +++ b/arch/arm64/mm/numa.c
>> @@ -141,6 +141,11 @@ int __init numa_add_memblk(int nid, u64 start, u64 end)
>> {
>> int ret;
>>
>> + if (nid >= MAX_NUMNODES) {
>> + pr_warn("NUMA: Node id %u exceeds maximum value\n", nid);
>> + return -EINVAL;
>> + }
>
> I think this check should be added to of_numa_parse_memory_nodes(), which before
> the numa_add_memblk() called, it's the same logic in of_numa_parse_cpu_nodes() and
> the node id is checked before calling numa_add_memblk() in ACPI.
Yes, you are right. This check is arch independent.
>
> Thanks
> Hanjun
>
>
>
> .
>
next prev parent reply other threads:[~2016-08-10 3:42 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 9:18 [PATCH v5 00/14] fix some type infos and bugs for arm64/of numa Zhen Lei
2016-08-08 9:18 ` Zhen Lei
2016-08-08 9:18 ` Zhen Lei
2016-08-08 9:18 ` [PATCH v5 01/14] of/numa: remove a duplicated pr_debug information Zhen Lei
2016-08-08 9:18 ` Zhen Lei
2016-08-08 9:18 ` Zhen Lei
2016-08-08 9:18 ` [PATCH v5 02/14] of/numa: fix a memory@ node can only contains one memory block Zhen Lei
2016-08-08 9:18 ` Zhen Lei
2016-08-08 9:18 ` [PATCH v5 03/14] arm64/numa: add nid check for " Zhen Lei
2016-08-08 9:18 ` Zhen Lei
2016-08-10 2:12 ` Hanjun Guo
2016-08-10 2:12 ` Hanjun Guo
2016-08-10 2:12 ` Hanjun Guo
2016-08-10 3:42 ` Leizhen (ThunderTown) [this message]
2016-08-10 3:42 ` Leizhen (ThunderTown)
2016-08-10 3:42 ` Leizhen (ThunderTown)
2016-08-08 9:18 ` [PATCH v5 04/14] of/numa: remove a duplicated warning Zhen Lei
2016-08-08 9:18 ` Zhen Lei
2016-08-08 9:18 ` [PATCH v5 05/14] arm64/numa: avoid inconsistent information to be printed Zhen Lei
2016-08-08 9:18 ` Zhen Lei
2016-08-08 9:18 ` [PATCH v5 06/14] of_numa: Use of_get_next_parent to simplify code Zhen Lei
2016-08-08 9:18 ` Zhen Lei
2016-08-08 9:18 ` [PATCH v5 07/14] of_numa: Use pr_fmt() Zhen Lei
2016-08-08 9:18 ` Zhen Lei
2016-08-08 9:18 ` [PATCH v5 08/14] arm64: numa: " Zhen Lei
2016-08-08 9:18 ` Zhen Lei
2016-08-08 9:18 ` [PATCH v5 09/14] arm64/numa: support HAVE_SETUP_PER_CPU_AREA Zhen Lei
2016-08-08 9:18 ` Zhen Lei
2016-08-08 9:18 ` [PATCH v5 10/14] arm64/numa: define numa_distance as array to simplify code Zhen Lei
2016-08-08 9:18 ` Zhen Lei
2016-08-08 9:18 ` [PATCH v5 11/14] arm64/numa: support HAVE_MEMORYLESS_NODES Zhen Lei
2016-08-08 9:18 ` Zhen Lei
2016-08-08 9:18 ` Zhen Lei
2016-08-08 9:18 ` [PATCH v5 12/14] arm64/numa: remove some useless code Zhen Lei
2016-08-08 9:18 ` Zhen Lei
2016-08-08 9:18 ` [PATCH v5 13/14] of/numa: remove the constraint on the distances of node pairs Zhen Lei
2016-08-08 9:18 ` Zhen Lei
2016-08-08 9:18 ` [PATCH v5 14/14] Documentation: " Zhen Lei
2016-08-08 9:18 ` Zhen Lei
2016-08-10 1:56 ` [PATCH v5 00/14] fix some type infos and bugs for arm64/of numa Hanjun Guo
2016-08-10 1:56 ` Hanjun Guo
2016-08-10 1:56 ` Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57AAA29B.9060608@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.