Re: bash: remove the format string "%q" in the unicode3.sub

Re: bash: remove the format string "%q" in the unicode3.sub

[dengke.du]

[-- Attachment #1: Type: text/plain, Size: 1744 bytes --]

Hi ross

After querying for the current maintainer of bash Chet Ramey, he said 
the devel
branch of bash have fixed it. So I will import those patchs later for 
the bash tests
suite.

We can check the patchs at:

http://git.savannah.gnu.org/cgit/bash.git/commit/tests/intl.right?h=devel&id=85ec0778f9d778e1820fb8c0e3e996f2d1103b45
http://git.savannah.gnu.org/cgit/bash.git/diff/tests/intl.right?h=devel&id=74b8cbb41398b4453d8ba04d0cdd1b25f9dcb9e3

//dengke


-------- Forwarded Message --------
Subject: 	Re: bash: remove the format string "%q" in the unicode3.sub
Date: 	Tue, 9 Aug 2016 10:39:13 -0400
From: 	Chet Ramey <chet.ramey@case.edu>
Reply-To: 	chet.ramey@case.edu
To: 	dengke.du@windriver.com <dengke.du@windriver.com>, bug-bash@gnu.org
CC: 	chet.ramey@case.edu



On 8/9/16 3:18 AM, dengke.du@windriver.com wrote:
> Hi all
>
> When I run the tests for the bash, the sub-test unicode3.sub of intl.tests
> failed.
>
> The sub-test unicode3.sub contain the following:
>
>     payload=$'\065\247\100\063\231\053\306\123\070\237\242\352\263'
>     "$payload"
>     printf %q "$payload"
>
> In this situation, the format string "%q" in command printf means that when the
> character in the payload is not in {alpha & digit & punctuation & ISO
> 646(7-bit)}, it
> would print the string with ANSI-C style quoted string: $'...' , we can
> check the source code

This has already been changed in the devel branch (back in May, 2015), and
the test case and tets output was changed at the same time.

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
		 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU    chet@case.edu    http://cnswww.cns.cwru.edu/~chet/




[-- Attachment #2: Type: text/html, Size: 4189 bytes --]

Re: bash: remove the format string "%q" in the unicode3.sub

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 2018 bytes --]

Great, thanks Dengke!

Ross

On 11 August 2016 at 09:53, dengke.du@windriver.com <dengke.du@windriver.com
> wrote:

> Hi ross
>
> After querying for the current maintainer of bash Chet Ramey, he said the
> devel
> branch of bash have fixed it. So I will import those patchs later for the
> bash tests
> suite.
>
> We can check the patchs at:
>
>      http://git.savannah.gnu.org/cgit/bash.git/commit/tests/
> intl.right?h=devel&id=85ec0778f9d778e1820fb8c0e3e996f2d1103b45
>      http://git.savannah.gnu.org/cgit/bash.git/diff/tests/intl.
> right?h=devel&id=74b8cbb41398b4453d8ba04d0cdd1b25f9dcb9e3
>
> //dengke
>
>
> -------- Forwarded Message --------
> Subject: Re: bash: remove the format string "%q" in the unicode3.sub
> Date: Tue, 9 Aug 2016 10:39:13 -0400
> From: Chet Ramey <chet.ramey@case.edu> <chet.ramey@case.edu>
> Reply-To: chet.ramey@case.edu
> To: dengke.du@windriver.com <dengke.du@windriver.com>
> <dengke.du@windriver.com>, bug-bash@gnu.org
> CC: chet.ramey@case.edu
>
> On 8/9/16 3:18 AM, dengke.du@windriver.com wrote:
> > Hi all
> >
> > When I run the tests for the bash, the sub-test unicode3.sub of intl.tests
> > failed.
> >
> > The sub-test unicode3.sub contain the following:
> >
> >     payload=$'\065\247\100\063\231\053\306\123\070\237\242\352\263'
> >     "$payload"
> >     printf %q "$payload"
> >
> > In this situation, the format string "%q" in command printf means that when the
> > character in the payload is not in {alpha & digit & punctuation & ISO
> > 646(7-bit)}, it
> > would print the string with ANSI-C style quoted string: $'...' , we can
> > check the source code
>
> This has already been changed in the devel branch (back in May, 2015), and
> the test case and tets output was changed at the same time.
>
> --
> ``The lyf so short, the craft so long to lerne.'' - Chaucer
> 		 ``Ars longa, vita brevis'' - Hippocrates
> Chet Ramey, UTech, CWRU    chet@case.edu    http://cnswww.cns.cwru.edu/~chet/
>
>
>
>

[-- Attachment #2: Type: text/html, Size: 4406 bytes --]