All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jose Abreu <Jose.Abreu@synopsys.com>
To: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
Subject: drm/bridge: dw_hdmi: Colorspace registers
Date: Wed, 17 Aug 2016 10:33:10 +0100	[thread overview]
Message-ID: <57B42F56.5050709@synopsys.com> (raw)

Hi Russell,

When using driver dw-hdmi in any other colorspace than RGB the
Y1, Y0 and YCC values are not correct. I confirmed in databook
that these registers are being written to the wrong offset (per
my databook they should be written in bits 0:1 and 7 instead of
bits 4:5). The piece of code in question is this:

    val = (frame.colorspace & 3) << 4 | (frame.scan_mode & 0x3);

So colorspace is being written to bits 4 and 5 instead of bits 0,
1 and 7.

Can you confirm if this is specific to Synopsys Phy?

Please notice that by default the colorspace is fixed to RGB
(where Y1, Y0 and YCC are zero) so this is only reproducible when
trying to use a different colorspace.

Best regards,
Jose Miguel Abreu
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

             reply	other threads:[~2016-08-17  9:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-17  9:33 Jose Abreu [this message]
2016-08-17 11:21 ` drm/bridge: dw_hdmi: Colorspace registers Russell King - ARM Linux
2016-08-17 11:37   ` Jose Abreu
2016-08-17 12:06     ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57B42F56.5050709@synopsys.com \
    --to=jose.abreu@synopsys.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=rmk+kernel@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.