All of lore.kernel.org
 help / color / mirror / Atom feed
From: "\"Zhou, Wenjian/周文剑\"" <zhouwj-fnst@cn.fujitsu.com>
To: Dave Young <dyoung@redhat.com>, Joe Perches <joe@perches.com>
Cc: bhe@redhat.com, corbet@lwn.net, xlpang@redhat.com,
	linux-doc@vger.kernel.org, kexec@lists.infradead.org,
	linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	vgoyal@redhat.com
Subject: Re: [PATCH v8 1/2] Documentation: kdump: remind user of nr_cpus
Date: Thu, 18 Aug 2016 15:12:03 +0800	[thread overview]
Message-ID: <57B55FC3.8050302@cn.fujitsu.com> (raw)
In-Reply-To: <20160818064715.GC26001@dhcp-128-65.nay.redhat.com>

On 08/18/2016 02:47 PM, Dave Young wrote:
> On 08/17/16 at 07:36pm, Joe Perches wrote:
>> On Thu, 2016-08-18 at 10:31 +0800, Zhou Wenjian wrote:
>>> nr_cpus can help to save memory. So we should remind user of it.
>>
>> trivia:
>>> diff --git a/Documentation/kdump/kdump.txt b/Documentation/kdump/kdump.txt
>> []
>>> @@ -390,9 +390,11 @@ Notes on loading the dump-capture kernel:
>>>   * Boot parameter "1" boots the dump-capture kernel into single-user
>>>     mode without networking. If you want networking, use "3".
>>>
>>> -* We generally don' have to bring up a SMP kernel just to capture the
>>> +* We generally don' have to bring up an SMP kernel just to capture the
>>
>> don't or do not
>>
>
> Use do not is better, also need replace 'We' with 'You' to be
> consistent with other part.
>
>

I think it's better to fix it in another patch,
for it doesn't have much relevance to the patch set.
I'll post it alone later.

-- 
Thanks
Zhou



_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: "\"Zhou, Wenjian/周文剑\"" <zhouwj-fnst@cn.fujitsu.com>
To: Dave Young <dyoung@redhat.com>, Joe Perches <joe@perches.com>
Cc: <linux-kernel@vger.kernel.org>, <akpm@linux-foundation.org>,
	<bhe@redhat.com>, <vgoyal@redhat.com>, <corbet@lwn.net>,
	<kexec@lists.infradead.org>, <linux-doc@vger.kernel.org>,
	<xlpang@redhat.com>
Subject: Re: [PATCH v8 1/2] Documentation: kdump: remind user of nr_cpus
Date: Thu, 18 Aug 2016 15:12:03 +0800	[thread overview]
Message-ID: <57B55FC3.8050302@cn.fujitsu.com> (raw)
In-Reply-To: <20160818064715.GC26001@dhcp-128-65.nay.redhat.com>

On 08/18/2016 02:47 PM, Dave Young wrote:
> On 08/17/16 at 07:36pm, Joe Perches wrote:
>> On Thu, 2016-08-18 at 10:31 +0800, Zhou Wenjian wrote:
>>> nr_cpus can help to save memory. So we should remind user of it.
>>
>> trivia:
>>> diff --git a/Documentation/kdump/kdump.txt b/Documentation/kdump/kdump.txt
>> []
>>> @@ -390,9 +390,11 @@ Notes on loading the dump-capture kernel:
>>>   * Boot parameter "1" boots the dump-capture kernel into single-user
>>>     mode without networking. If you want networking, use "3".
>>>
>>> -* We generally don' have to bring up a SMP kernel just to capture the
>>> +* We generally don' have to bring up an SMP kernel just to capture the
>>
>> don't or do not
>>
>
> Use do not is better, also need replace 'We' with 'You' to be
> consistent with other part.
>
>

I think it's better to fix it in another patch,
for it doesn't have much relevance to the patch set.
I'll post it alone later.

-- 
Thanks
Zhou

  reply	other threads:[~2016-08-18  7:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-18  2:31 [PATCH v8 0/2] update the doc of kdump Zhou Wenjian
2016-08-18  2:31 ` Zhou Wenjian
2016-08-18  2:31 ` [PATCH v8 1/2] Documentation: kdump: remind user of nr_cpus Zhou Wenjian
2016-08-18  2:31   ` Zhou Wenjian
2016-08-18  2:36   ` Joe Perches
2016-08-18  2:36     ` Joe Perches
2016-08-18  6:47     ` Dave Young
2016-08-18  6:47       ` Dave Young
2016-08-18  7:12       ` "Zhou, Wenjian/周文剑" [this message]
2016-08-18  7:12         ` "Zhou, Wenjian/周文剑"
2016-08-18  2:31 ` [PATCH v8 2/2] Documentation: kdump: add description of enable multi-cpus support Zhou Wenjian
2016-08-18  2:31   ` Zhou Wenjian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57B55FC3.8050302@cn.fujitsu.com \
    --to=zhouwj-fnst@cn.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=bhe@redhat.com \
    --cc=corbet@lwn.net \
    --cc=dyoung@redhat.com \
    --cc=joe@perches.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vgoyal@redhat.com \
    --cc=xlpang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.