diff for duplicates of <57BBB66E.2060807@samsung.com> diff --git a/a/1.txt b/N1/1.txt index b51707f..d55766a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,6 +1,6 @@ Hi Stephen, -On 2016=EB=85=84 08=EC=9B=94 23=EC=9D=BC 09:55, Stephen Boyd wrote: +On 2016년 08월 23일 09:55, Stephen Boyd wrote: > On 08/22, Chanwoo Choi wrote: >> This patch moves the all samsung_cmu_info struct to initconst section >> because they are used only in initconst section. @@ -14,32 +14,32 @@ On 2016=EB=85=84 08=EC=9B=94 23=EC=9D=BC 09:55, Stephen Boyd wrote: >> index a43642c36039..fd1d9bfc151b 100644 >> --- a/drivers/clk/samsung/clk-exynos5260.c >> +++ b/drivers/clk/samsung/clk-exynos5260.c ->> @@ -131,21 +131,21 @@ static const struct samsung_gate_clock aud_gate_clks[] __initconst =3D { +>> @@ -131,21 +131,21 @@ static const struct samsung_gate_clock aud_gate_clks[] __initconst = { >> EN_IP_AUD, 4, 0, 0), >> }; >> ->> +static const struct samsung_cmu_info aud_cmu __initconst =3D { ->> + .mux_clks =3D aud_mux_clks, ->> + .nr_mux_clks =3D ARRAY_SIZE(aud_mux_clks), ->> + .div_clks =3D aud_div_clks, ->> + .nr_div_clks =3D ARRAY_SIZE(aud_div_clks), ->> + .gate_clks =3D aud_gate_clks, ->> + .nr_gate_clks =3D ARRAY_SIZE(aud_gate_clks), ->> + .nr_clk_ids =3D AUD_NR_CLK, ->> + .clk_regs =3D aud_clk_regs, ->> + .nr_clk_regs =3D ARRAY_SIZE(aud_clk_regs), +>> +static const struct samsung_cmu_info aud_cmu __initconst = { +>> + .mux_clks = aud_mux_clks, +>> + .nr_mux_clks = ARRAY_SIZE(aud_mux_clks), +>> + .div_clks = aud_div_clks, +>> + .nr_div_clks = ARRAY_SIZE(aud_div_clks), +>> + .gate_clks = aud_gate_clks, +>> + .nr_gate_clks = ARRAY_SIZE(aud_gate_clks), +>> + .nr_clk_ids = AUD_NR_CLK, +>> + .clk_regs = aud_clk_regs, +>> + .nr_clk_regs = ARRAY_SIZE(aud_clk_regs), >> +}; >> + >> static void __init exynos5260_clk_aud_init(struct device_node *np) >> { ->> - struct samsung_cmu_info cmu =3D { NULL }; +>> - struct samsung_cmu_info cmu = { NULL }; >> - > > I presume this was done this way to save some initdata space by -> only allocating the array that's needed at runtime=3F I would +> only allocating the array that's needed at runtime? I would > expect to see some more kernel image bloat from this change but > runtime memory usage would stay the same. Is there any real -> benefit from this patch though=3F +> benefit from this patch though? > After this patch, 'struct samsung_cmu_info' size should be added diff --git a/a/content_digest b/N1/content_digest index e332b2e..b15b1dc 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -20,7 +20,7 @@ "b\0" "Hi Stephen,\n" "\n" - "On 2016=EB=85=84 08=EC=9B=94 23=EC=9D=BC 09:55, Stephen Boyd wrote:\n" + "On 2016\353\205\204 08\354\233\224 23\354\235\274 09:55, Stephen Boyd wrote:\n" "> On 08/22, Chanwoo Choi wrote:\n" ">> This patch moves the all samsung_cmu_info struct to initconst section\n" ">> because they are used only in initconst section.\n" @@ -34,32 +34,32 @@ ">> index a43642c36039..fd1d9bfc151b 100644\n" ">> --- a/drivers/clk/samsung/clk-exynos5260.c\n" ">> +++ b/drivers/clk/samsung/clk-exynos5260.c\n" - ">> @@ -131,21 +131,21 @@ static const struct samsung_gate_clock aud_gate_clks[] __initconst =3D {\n" + ">> @@ -131,21 +131,21 @@ static const struct samsung_gate_clock aud_gate_clks[] __initconst = {\n" ">> \t\t\tEN_IP_AUD, 4, 0, 0),\n" ">> };\n" ">> \n" - ">> +static const struct samsung_cmu_info aud_cmu __initconst =3D {\n" - ">> +\t.mux_clks\t=3D aud_mux_clks,\n" - ">> +\t.nr_mux_clks\t=3D ARRAY_SIZE(aud_mux_clks),\n" - ">> +\t.div_clks\t=3D aud_div_clks,\n" - ">> +\t.nr_div_clks\t=3D ARRAY_SIZE(aud_div_clks),\n" - ">> +\t.gate_clks\t=3D aud_gate_clks,\n" - ">> +\t.nr_gate_clks\t=3D ARRAY_SIZE(aud_gate_clks),\n" - ">> +\t.nr_clk_ids\t=3D AUD_NR_CLK,\n" - ">> +\t.clk_regs\t=3D aud_clk_regs,\n" - ">> +\t.nr_clk_regs\t=3D ARRAY_SIZE(aud_clk_regs),\n" + ">> +static const struct samsung_cmu_info aud_cmu __initconst = {\n" + ">> +\t.mux_clks\t= aud_mux_clks,\n" + ">> +\t.nr_mux_clks\t= ARRAY_SIZE(aud_mux_clks),\n" + ">> +\t.div_clks\t= aud_div_clks,\n" + ">> +\t.nr_div_clks\t= ARRAY_SIZE(aud_div_clks),\n" + ">> +\t.gate_clks\t= aud_gate_clks,\n" + ">> +\t.nr_gate_clks\t= ARRAY_SIZE(aud_gate_clks),\n" + ">> +\t.nr_clk_ids\t= AUD_NR_CLK,\n" + ">> +\t.clk_regs\t= aud_clk_regs,\n" + ">> +\t.nr_clk_regs\t= ARRAY_SIZE(aud_clk_regs),\n" ">> +};\n" ">> +\n" ">> static void __init exynos5260_clk_aud_init(struct device_node *np)\n" ">> {\n" - ">> -\tstruct samsung_cmu_info cmu =3D { NULL };\n" + ">> -\tstruct samsung_cmu_info cmu = { NULL };\n" ">> -\n" "> \n" "> I presume this was done this way to save some initdata space by\n" - "> only allocating the array that's needed at runtime=3F I would\n" + "> only allocating the array that's needed at runtime? I would\n" "> expect to see some more kernel image bloat from this change but\n" "> runtime memory usage would stay the same. Is there any real\n" - "> benefit from this patch though=3F\n" + "> benefit from this patch though?\n" "> \n" "\n" "After this patch, 'struct samsung_cmu_info' size should be added\n" @@ -74,4 +74,4 @@ "Regards,\n" Chanwoo Choi -ff058e8428978f7386f4a8f0cc42d451400b69dcd4b04b73b3d77419aa298e57 +5b27052d18b32d08d504970316c1a4db34c9e9ffe4bc67a05c253b8833fa373b
diff --git a/a/1.txt b/N2/1.txt index b51707f..6524b3e 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,6 +1,6 @@ Hi Stephen, -On 2016=EB=85=84 08=EC=9B=94 23=EC=9D=BC 09:55, Stephen Boyd wrote: +On 2016? 08? 23? 09:55, Stephen Boyd wrote: > On 08/22, Chanwoo Choi wrote: >> This patch moves the all samsung_cmu_info struct to initconst section >> because they are used only in initconst section. @@ -14,32 +14,32 @@ On 2016=EB=85=84 08=EC=9B=94 23=EC=9D=BC 09:55, Stephen Boyd wrote: >> index a43642c36039..fd1d9bfc151b 100644 >> --- a/drivers/clk/samsung/clk-exynos5260.c >> +++ b/drivers/clk/samsung/clk-exynos5260.c ->> @@ -131,21 +131,21 @@ static const struct samsung_gate_clock aud_gate_clks[] __initconst =3D { +>> @@ -131,21 +131,21 @@ static const struct samsung_gate_clock aud_gate_clks[] __initconst = { >> EN_IP_AUD, 4, 0, 0), >> }; >> ->> +static const struct samsung_cmu_info aud_cmu __initconst =3D { ->> + .mux_clks =3D aud_mux_clks, ->> + .nr_mux_clks =3D ARRAY_SIZE(aud_mux_clks), ->> + .div_clks =3D aud_div_clks, ->> + .nr_div_clks =3D ARRAY_SIZE(aud_div_clks), ->> + .gate_clks =3D aud_gate_clks, ->> + .nr_gate_clks =3D ARRAY_SIZE(aud_gate_clks), ->> + .nr_clk_ids =3D AUD_NR_CLK, ->> + .clk_regs =3D aud_clk_regs, ->> + .nr_clk_regs =3D ARRAY_SIZE(aud_clk_regs), +>> +static const struct samsung_cmu_info aud_cmu __initconst = { +>> + .mux_clks = aud_mux_clks, +>> + .nr_mux_clks = ARRAY_SIZE(aud_mux_clks), +>> + .div_clks = aud_div_clks, +>> + .nr_div_clks = ARRAY_SIZE(aud_div_clks), +>> + .gate_clks = aud_gate_clks, +>> + .nr_gate_clks = ARRAY_SIZE(aud_gate_clks), +>> + .nr_clk_ids = AUD_NR_CLK, +>> + .clk_regs = aud_clk_regs, +>> + .nr_clk_regs = ARRAY_SIZE(aud_clk_regs), >> +}; >> + >> static void __init exynos5260_clk_aud_init(struct device_node *np) >> { ->> - struct samsung_cmu_info cmu =3D { NULL }; +>> - struct samsung_cmu_info cmu = { NULL }; >> - > > I presume this was done this way to save some initdata space by -> only allocating the array that's needed at runtime=3F I would +> only allocating the array that's needed at runtime? I would > expect to see some more kernel image bloat from this change but > runtime memory usage would stay the same. Is there any real -> benefit from this patch though=3F +> benefit from this patch though? > After this patch, 'struct samsung_cmu_info' size should be added diff --git a/a/content_digest b/N2/content_digest index e332b2e..8df315d 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,25 +2,15 @@ "ref\01471834185-20249-2-git-send-email-cw00.choi@samsung.com\0" "ref\0CGME20160823005523epcas1p3993794ba487bb055cbf8a0b247fcb280@epcas1p3.samsung.com\0" "ref\020160823005512.GP6502@codeaurora.org\0" - "From\0Chanwoo Choi <cw00.choi@samsung.com>\0" - "Subject\0Re: [PATCH 1/2] clk: samsung: exynos5260: Move struct samsung_cmu_info to init section\0" + "From\0cw00.choi@samsung.com (Chanwoo Choi)\0" + "Subject\0[PATCH 1/2] clk: samsung: exynos5260: Move struct samsung_cmu_info to init section\0" "Date\0Tue, 23 Aug 2016 11:35:26 +0900\0" - "To\0Stephen Boyd <sboyd@codeaurora.org>\0" - "Cc\0s.nawrocki@samsung.com" - tomasz.figa@gmail.com - mturquette@baylibre.com - kgene@kernel.org - k.kozlowski@samsung.com - chanwoo@kernel.org - linux-samsung-soc@vger.kernel.org - linux-clk@vger.kernel.org - linux-arm-kernel@lists.infradead.org - " linux-kernel@vger.kernel.org\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "Hi Stephen,\n" "\n" - "On 2016=EB=85=84 08=EC=9B=94 23=EC=9D=BC 09:55, Stephen Boyd wrote:\n" + "On 2016? 08? 23? 09:55, Stephen Boyd wrote:\n" "> On 08/22, Chanwoo Choi wrote:\n" ">> This patch moves the all samsung_cmu_info struct to initconst section\n" ">> because they are used only in initconst section.\n" @@ -34,32 +24,32 @@ ">> index a43642c36039..fd1d9bfc151b 100644\n" ">> --- a/drivers/clk/samsung/clk-exynos5260.c\n" ">> +++ b/drivers/clk/samsung/clk-exynos5260.c\n" - ">> @@ -131,21 +131,21 @@ static const struct samsung_gate_clock aud_gate_clks[] __initconst =3D {\n" + ">> @@ -131,21 +131,21 @@ static const struct samsung_gate_clock aud_gate_clks[] __initconst = {\n" ">> \t\t\tEN_IP_AUD, 4, 0, 0),\n" ">> };\n" ">> \n" - ">> +static const struct samsung_cmu_info aud_cmu __initconst =3D {\n" - ">> +\t.mux_clks\t=3D aud_mux_clks,\n" - ">> +\t.nr_mux_clks\t=3D ARRAY_SIZE(aud_mux_clks),\n" - ">> +\t.div_clks\t=3D aud_div_clks,\n" - ">> +\t.nr_div_clks\t=3D ARRAY_SIZE(aud_div_clks),\n" - ">> +\t.gate_clks\t=3D aud_gate_clks,\n" - ">> +\t.nr_gate_clks\t=3D ARRAY_SIZE(aud_gate_clks),\n" - ">> +\t.nr_clk_ids\t=3D AUD_NR_CLK,\n" - ">> +\t.clk_regs\t=3D aud_clk_regs,\n" - ">> +\t.nr_clk_regs\t=3D ARRAY_SIZE(aud_clk_regs),\n" + ">> +static const struct samsung_cmu_info aud_cmu __initconst = {\n" + ">> +\t.mux_clks\t= aud_mux_clks,\n" + ">> +\t.nr_mux_clks\t= ARRAY_SIZE(aud_mux_clks),\n" + ">> +\t.div_clks\t= aud_div_clks,\n" + ">> +\t.nr_div_clks\t= ARRAY_SIZE(aud_div_clks),\n" + ">> +\t.gate_clks\t= aud_gate_clks,\n" + ">> +\t.nr_gate_clks\t= ARRAY_SIZE(aud_gate_clks),\n" + ">> +\t.nr_clk_ids\t= AUD_NR_CLK,\n" + ">> +\t.clk_regs\t= aud_clk_regs,\n" + ">> +\t.nr_clk_regs\t= ARRAY_SIZE(aud_clk_regs),\n" ">> +};\n" ">> +\n" ">> static void __init exynos5260_clk_aud_init(struct device_node *np)\n" ">> {\n" - ">> -\tstruct samsung_cmu_info cmu =3D { NULL };\n" + ">> -\tstruct samsung_cmu_info cmu = { NULL };\n" ">> -\n" "> \n" "> I presume this was done this way to save some initdata space by\n" - "> only allocating the array that's needed at runtime=3F I would\n" + "> only allocating the array that's needed at runtime? I would\n" "> expect to see some more kernel image bloat from this change but\n" "> runtime memory usage would stay the same. Is there any real\n" - "> benefit from this patch though=3F\n" + "> benefit from this patch though?\n" "> \n" "\n" "After this patch, 'struct samsung_cmu_info' size should be added\n" @@ -74,4 +64,4 @@ "Regards,\n" Chanwoo Choi -ff058e8428978f7386f4a8f0cc42d451400b69dcd4b04b73b3d77419aa298e57 +00951062961019d7a50658ed9ef4cad74f87aa7c9a442b96bc5a95dde0aa5115
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.