* [PATCH v2] MIPS: Octeon: mark GPIO controller node not populated after IRQ init.
@ 2016-08-26 19:02 ` Steven J. Hill
0 siblings, 0 replies; 7+ messages in thread
From: Steven J. Hill @ 2016-08-26 19:02 UTC (permalink / raw)
To: linux-mips, ralf; +Cc: David Daney, Rob Herring, devicetree, Aaro Koskinen
We clear the OF_POPULATED flag for the GPIO controller node on Octeon
processors. Otherwise, none of the devices hanging on the GPIO lines
are probed. The 'gpio-leds' driver on OCTEON failed to probe in addition
to other devices on Cavium 71xx and 78xx development boards.
Fixes: 15cc2ed6dcf9 ("of/irq: Mark initialised interrupt controllers as populated")
Signed-off-by: Steven J. Hill <steven.hill@cavium.com>
Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi>
---
arch/mips/cavium-octeon/octeon-irq.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/mips/cavium-octeon/octeon-irq.c b/arch/mips/cavium-octeon/octeon-irq.c
index 5a9b87b..c1eb1ff 100644
--- a/arch/mips/cavium-octeon/octeon-irq.c
+++ b/arch/mips/cavium-octeon/octeon-irq.c
@@ -1619,6 +1619,12 @@ static int __init octeon_irq_init_gpio(
return -ENOMEM;
}
+ /*
+ * Clear the OF_POPULATED flag that was set by of_irq_init()
+ * so that all GPIO devices will be probed.
+ */
+ of_node_clear_flag(gpio_node, OF_POPULATED);
+
return 0;
}
/*
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH v2] MIPS: Octeon: mark GPIO controller node not populated after IRQ init.
@ 2016-08-26 19:02 ` Steven J. Hill
0 siblings, 0 replies; 7+ messages in thread
From: Steven J. Hill @ 2016-08-26 19:02 UTC (permalink / raw)
To: linux-mips, ralf; +Cc: David Daney, Rob Herring, devicetree, Aaro Koskinen
We clear the OF_POPULATED flag for the GPIO controller node on Octeon
processors. Otherwise, none of the devices hanging on the GPIO lines
are probed. The 'gpio-leds' driver on OCTEON failed to probe in addition
to other devices on Cavium 71xx and 78xx development boards.
Fixes: 15cc2ed6dcf9 ("of/irq: Mark initialised interrupt controllers as populated")
Signed-off-by: Steven J. Hill <steven.hill@cavium.com>
Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi>
---
arch/mips/cavium-octeon/octeon-irq.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/mips/cavium-octeon/octeon-irq.c b/arch/mips/cavium-octeon/octeon-irq.c
index 5a9b87b..c1eb1ff 100644
--- a/arch/mips/cavium-octeon/octeon-irq.c
+++ b/arch/mips/cavium-octeon/octeon-irq.c
@@ -1619,6 +1619,12 @@ static int __init octeon_irq_init_gpio(
return -ENOMEM;
}
+ /*
+ * Clear the OF_POPULATED flag that was set by of_irq_init()
+ * so that all GPIO devices will be probed.
+ */
+ of_node_clear_flag(gpio_node, OF_POPULATED);
+
return 0;
}
/*
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v2] MIPS: Octeon: mark GPIO controller node not populated after IRQ init.
@ 2016-09-26 20:41 ` Aaro Koskinen
0 siblings, 0 replies; 7+ messages in thread
From: Aaro Koskinen @ 2016-09-26 20:41 UTC (permalink / raw)
To: Ralf Baechle
Cc: linux-mips, ralf, David Daney, Rob Herring, devicetree,
Steven J. Hill
Hi,
On Fri, Aug 26, 2016 at 02:02:04PM -0500, Steven J. Hill wrote:
> We clear the OF_POPULATED flag for the GPIO controller node on Octeon
> processors. Otherwise, none of the devices hanging on the GPIO lines
> are probed. The 'gpio-leds' driver on OCTEON failed to probe in addition
> to other devices on Cavium 71xx and 78xx development boards.
>
> Fixes: 15cc2ed6dcf9 ("of/irq: Mark initialised interrupt controllers as populated")
> Signed-off-by: Steven J. Hill <steven.hill@cavium.com>
> Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Ralf, I think this patch should be still included in v4.8 final.
Thanks,
A.
> ---
> arch/mips/cavium-octeon/octeon-irq.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/mips/cavium-octeon/octeon-irq.c b/arch/mips/cavium-octeon/octeon-irq.c
> index 5a9b87b..c1eb1ff 100644
> --- a/arch/mips/cavium-octeon/octeon-irq.c
> +++ b/arch/mips/cavium-octeon/octeon-irq.c
> @@ -1619,6 +1619,12 @@ static int __init octeon_irq_init_gpio(
> return -ENOMEM;
> }
>
> + /*
> + * Clear the OF_POPULATED flag that was set by of_irq_init()
> + * so that all GPIO devices will be probed.
> + */
> + of_node_clear_flag(gpio_node, OF_POPULATED);
> +
> return 0;
> }
> /*
> --
> 1.9.1
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2] MIPS: Octeon: mark GPIO controller node not populated after IRQ init.
@ 2016-09-26 20:41 ` Aaro Koskinen
0 siblings, 0 replies; 7+ messages in thread
From: Aaro Koskinen @ 2016-09-26 20:41 UTC (permalink / raw)
Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA, ralf-6z/3iImG2C8G8FEW9MqTrA,
David Daney, Rob Herring, devicetree-u79uwXL29TY76Z2rM5mHXA,
Steven J. Hill
Hi,
On Fri, Aug 26, 2016 at 02:02:04PM -0500, Steven J. Hill wrote:
> We clear the OF_POPULATED flag for the GPIO controller node on Octeon
> processors. Otherwise, none of the devices hanging on the GPIO lines
> are probed. The 'gpio-leds' driver on OCTEON failed to probe in addition
> to other devices on Cavium 71xx and 78xx development boards.
>
> Fixes: 15cc2ed6dcf9 ("of/irq: Mark initialised interrupt controllers as populated")
> Signed-off-by: Steven J. Hill <steven.hill-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
> Tested-by: Aaro Koskinen <aaro.koskinen-X3B1VOXEql0@public.gmane.org>
Ralf, I think this patch should be still included in v4.8 final.
Thanks,
A.
> ---
> arch/mips/cavium-octeon/octeon-irq.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/mips/cavium-octeon/octeon-irq.c b/arch/mips/cavium-octeon/octeon-irq.c
> index 5a9b87b..c1eb1ff 100644
> --- a/arch/mips/cavium-octeon/octeon-irq.c
> +++ b/arch/mips/cavium-octeon/octeon-irq.c
> @@ -1619,6 +1619,12 @@ static int __init octeon_irq_init_gpio(
> return -ENOMEM;
> }
>
> + /*
> + * Clear the OF_POPULATED flag that was set by of_irq_init()
> + * so that all GPIO devices will be probed.
> + */
> + of_node_clear_flag(gpio_node, OF_POPULATED);
> +
> return 0;
> }
> /*
> --
> 1.9.1
>
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2] MIPS: Octeon: mark GPIO controller node not populated after IRQ init.
@ 2016-09-26 20:41 ` Aaro Koskinen
0 siblings, 0 replies; 7+ messages in thread
From: Aaro Koskinen @ 2016-09-26 20:41 UTC (permalink / raw)
To: Ralf Baechle
Cc: linux-mips, David Daney, Rob Herring, devicetree, Steven J. Hill
Hi,
On Fri, Aug 26, 2016 at 02:02:04PM -0500, Steven J. Hill wrote:
> We clear the OF_POPULATED flag for the GPIO controller node on Octeon
> processors. Otherwise, none of the devices hanging on the GPIO lines
> are probed. The 'gpio-leds' driver on OCTEON failed to probe in addition
> to other devices on Cavium 71xx and 78xx development boards.
>
> Fixes: 15cc2ed6dcf9 ("of/irq: Mark initialised interrupt controllers as populated")
> Signed-off-by: Steven J. Hill <steven.hill@cavium.com>
> Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Ralf, I think this patch should be still included in v4.8 final.
Thanks,
A.
> ---
> arch/mips/cavium-octeon/octeon-irq.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/mips/cavium-octeon/octeon-irq.c b/arch/mips/cavium-octeon/octeon-irq.c
> index 5a9b87b..c1eb1ff 100644
> --- a/arch/mips/cavium-octeon/octeon-irq.c
> +++ b/arch/mips/cavium-octeon/octeon-irq.c
> @@ -1619,6 +1619,12 @@ static int __init octeon_irq_init_gpio(
> return -ENOMEM;
> }
>
> + /*
> + * Clear the OF_POPULATED flag that was set by of_irq_init()
> + * so that all GPIO devices will be probed.
> + */
> + of_node_clear_flag(gpio_node, OF_POPULATED);
> +
> return 0;
> }
> /*
> --
> 1.9.1
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2] MIPS: Octeon: mark GPIO controller node not populated after IRQ init.
@ 2016-09-26 22:21 ` Steven J. Hill
0 siblings, 0 replies; 7+ messages in thread
From: Steven J. Hill @ 2016-09-26 22:21 UTC (permalink / raw)
To: Aaro Koskinen, Ralf Baechle
Cc: linux-mips, David Daney, Rob Herring, devicetree
On 09/26/2016 03:41 PM, Aaro Koskinen wrote:
>
> Ralf, I think this patch should be still included in v4.8 final.
>
> Thanks,
>
> A.
>
Yes, please put it in 4.8 final. Thanks!
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-09-26 22:22 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-26 19:02 [PATCH v2] MIPS: Octeon: mark GPIO controller node not populated after IRQ init Steven J. Hill
2016-08-26 19:02 ` Steven J. Hill
2016-09-26 20:41 ` Aaro Koskinen
2016-09-26 20:41 ` Aaro Koskinen
2016-09-26 20:41 ` Aaro Koskinen
2016-09-26 22:21 ` Steven J. Hill
2016-09-26 22:21 ` Steven J. Hill
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.