From: thunder.leizhen@huawei.com (Leizhen (ThunderTown))
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 10/14] arm64/numa: define numa_distance as array to simplify code
Date: Sat, 27 Aug 2016 18:29:28 +0800 [thread overview]
Message-ID: <57C16B88.7080500@huawei.com> (raw)
In-Reply-To: <20160826152915.GH30302@arm.com>
On 2016/8/26 23:29, Will Deacon wrote:
> On Wed, Aug 24, 2016 at 03:44:49PM +0800, Zhen Lei wrote:
>> 1. MAX_NUMNODES is base on CONFIG_NODES_SHIFT, the default value of the
>> latter is very small now.
>> 2. Suppose the default value of MAX_NUMNODES is enlarged to 64, so the
>> size of numa_distance is 4K, it's still acceptable if run the Image
>> on other processors.
>> 3. It will make function __node_distance quicker than before.
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>> ---
>> arch/arm64/include/asm/numa.h | 1 -
>> arch/arm64/mm/numa.c | 74 +++----------------------------------------
>> 2 files changed, 5 insertions(+), 70 deletions(-)
>
> I fail to see the advantages of this patch. Do you have some compelling
> performance figures or something?
We can only put numa_distance_cnt on one node, so for the cpus of other nodes to access it should
spend more time. I have not tested how many can be improved yet.
I will try to get some data next week.
>
> Will
>
> .
>
WARNING: multiple messages have this Message-ID (diff)
From: "Leizhen (ThunderTown)" <thunder.leizhen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
Cc: Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
linux-arm-kernel
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
linux-kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Frank Rowand
<frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Zefan Li <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
Xinwei Hu <huxinwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
Tianhong Ding
<dingtianhong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
Hanjun Guo <guohanjun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v7 10/14] arm64/numa: define numa_distance as array to simplify code
Date: Sat, 27 Aug 2016 18:29:28 +0800 [thread overview]
Message-ID: <57C16B88.7080500@huawei.com> (raw)
In-Reply-To: <20160826152915.GH30302-5wv7dgnIgG8@public.gmane.org>
On 2016/8/26 23:29, Will Deacon wrote:
> On Wed, Aug 24, 2016 at 03:44:49PM +0800, Zhen Lei wrote:
>> 1. MAX_NUMNODES is base on CONFIG_NODES_SHIFT, the default value of the
>> latter is very small now.
>> 2. Suppose the default value of MAX_NUMNODES is enlarged to 64, so the
>> size of numa_distance is 4K, it's still acceptable if run the Image
>> on other processors.
>> 3. It will make function __node_distance quicker than before.
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
>> ---
>> arch/arm64/include/asm/numa.h | 1 -
>> arch/arm64/mm/numa.c | 74 +++----------------------------------------
>> 2 files changed, 5 insertions(+), 70 deletions(-)
>
> I fail to see the advantages of this patch. Do you have some compelling
> performance figures or something?
We can only put numa_distance_cnt on one node, so for the cpus of other nodes to access it should
spend more time. I have not tested how many can be improved yet.
I will try to get some data next week.
>
> Will
>
> .
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Will Deacon <will.deacon@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
"Frank Rowand" <frowand.list@gmail.com>,
devicetree <devicetree@vger.kernel.org>,
Zefan Li <lizefan@huawei.com>, Xinwei Hu <huxinwei@huawei.com>,
Tianhong Ding <dingtianhong@huawei.com>,
Hanjun Guo <guohanjun@huawei.com>
Subject: Re: [PATCH v7 10/14] arm64/numa: define numa_distance as array to simplify code
Date: Sat, 27 Aug 2016 18:29:28 +0800 [thread overview]
Message-ID: <57C16B88.7080500@huawei.com> (raw)
In-Reply-To: <20160826152915.GH30302@arm.com>
On 2016/8/26 23:29, Will Deacon wrote:
> On Wed, Aug 24, 2016 at 03:44:49PM +0800, Zhen Lei wrote:
>> 1. MAX_NUMNODES is base on CONFIG_NODES_SHIFT, the default value of the
>> latter is very small now.
>> 2. Suppose the default value of MAX_NUMNODES is enlarged to 64, so the
>> size of numa_distance is 4K, it's still acceptable if run the Image
>> on other processors.
>> 3. It will make function __node_distance quicker than before.
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>> ---
>> arch/arm64/include/asm/numa.h | 1 -
>> arch/arm64/mm/numa.c | 74 +++----------------------------------------
>> 2 files changed, 5 insertions(+), 70 deletions(-)
>
> I fail to see the advantages of this patch. Do you have some compelling
> performance figures or something?
We can only put numa_distance_cnt on one node, so for the cpus of other nodes to access it should
spend more time. I have not tested how many can be improved yet.
I will try to get some data next week.
>
> Will
>
> .
>
next prev parent reply other threads:[~2016-08-27 10:29 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 7:44 [PATCH v7 00/14] fix some type infos and bugs for arm64/of numa Zhen Lei
2016-08-24 7:44 ` Zhen Lei
2016-08-24 7:44 ` Zhen Lei
2016-08-24 7:44 ` [PATCH v7 01/14] of/numa: remove a duplicated pr_debug information Zhen Lei
2016-08-24 7:44 ` Zhen Lei
2016-08-24 7:44 ` [PATCH v7 02/14] of/numa: fix a memory@ node can only contains one memory block Zhen Lei
2016-08-24 7:44 ` Zhen Lei
2016-08-24 7:44 ` Zhen Lei
2016-08-24 7:44 ` [PATCH v7 03/14] arm64/numa: add nid check for " Zhen Lei
2016-08-24 7:44 ` Zhen Lei
2016-08-24 7:44 ` Zhen Lei
2016-08-26 12:39 ` Will Deacon
2016-08-26 12:39 ` Will Deacon
2016-08-26 12:39 ` Will Deacon
2016-08-27 8:02 ` Leizhen (ThunderTown)
2016-08-27 8:02 ` Leizhen (ThunderTown)
2016-08-24 7:44 ` [PATCH v7 04/14] of/numa: remove a duplicated warning Zhen Lei
2016-08-24 7:44 ` Zhen Lei
2016-08-24 7:44 ` Zhen Lei
2016-08-24 7:44 ` [PATCH v7 05/14] arm64/numa: avoid inconsistent information to be printed Zhen Lei
2016-08-24 7:44 ` Zhen Lei
2016-08-26 12:47 ` Will Deacon
2016-08-26 12:47 ` Will Deacon
2016-08-26 12:47 ` Will Deacon
2016-08-27 8:54 ` Leizhen (ThunderTown)
2016-08-27 8:54 ` Leizhen (ThunderTown)
2016-08-27 8:54 ` Leizhen (ThunderTown)
2016-08-30 17:51 ` Will Deacon
2016-08-30 17:51 ` Will Deacon
2016-08-30 17:51 ` Will Deacon
2016-08-31 2:29 ` Leizhen (ThunderTown)
2016-08-31 2:29 ` Leizhen (ThunderTown)
2016-08-31 2:29 ` Leizhen (ThunderTown)
2016-08-24 7:44 ` [PATCH v7 06/14] of_numa: Use of_get_next_parent to simplify code Zhen Lei
2016-08-24 7:44 ` Zhen Lei
2016-08-24 7:44 ` [PATCH v7 07/14] of_numa: Use pr_fmt() Zhen Lei
2016-08-24 7:44 ` Zhen Lei
2016-08-24 7:44 ` [PATCH v7 08/14] arm64: numa: " Zhen Lei
2016-08-24 7:44 ` Zhen Lei
2016-08-26 12:54 ` Will Deacon
2016-08-26 12:54 ` Will Deacon
2016-08-26 12:54 ` Will Deacon
2016-08-27 9:14 ` Leizhen (ThunderTown)
2016-08-27 9:14 ` Leizhen (ThunderTown)
2016-08-27 9:14 ` Leizhen (ThunderTown)
2016-08-24 7:44 ` [PATCH v7 09/14] arm64/numa: support HAVE_SETUP_PER_CPU_AREA Zhen Lei
2016-08-24 7:44 ` Zhen Lei
2016-08-26 13:28 ` Will Deacon
2016-08-26 13:28 ` Will Deacon
2016-08-26 13:28 ` Will Deacon
2016-08-27 10:06 ` Leizhen (ThunderTown)
2016-08-27 10:06 ` Leizhen (ThunderTown)
2016-08-27 10:06 ` Leizhen (ThunderTown)
2016-08-24 7:44 ` [PATCH v7 10/14] arm64/numa: define numa_distance as array to simplify code Zhen Lei
2016-08-24 7:44 ` Zhen Lei
2016-08-26 15:29 ` Will Deacon
2016-08-26 15:29 ` Will Deacon
2016-08-27 10:29 ` Leizhen (ThunderTown) [this message]
2016-08-27 10:29 ` Leizhen (ThunderTown)
2016-08-27 10:29 ` Leizhen (ThunderTown)
2016-08-24 7:44 ` [PATCH v7 11/14] arm64/numa: support HAVE_MEMORYLESS_NODES Zhen Lei
2016-08-24 7:44 ` Zhen Lei
2016-08-26 15:43 ` Will Deacon
2016-08-26 15:43 ` Will Deacon
2016-08-27 11:05 ` Leizhen (ThunderTown)
2016-08-27 11:05 ` Leizhen (ThunderTown)
2016-08-29 3:15 ` Leizhen (ThunderTown)
2016-08-29 3:15 ` Leizhen (ThunderTown)
2016-08-29 3:15 ` Leizhen (ThunderTown)
2016-08-24 7:44 ` [PATCH v7 12/14] arm64/numa: remove the limitation that cpu0 must bind to node0 Zhen Lei
2016-08-24 7:44 ` Zhen Lei
2016-08-26 15:49 ` Will Deacon
2016-08-26 15:49 ` Will Deacon
2016-08-26 15:49 ` Will Deacon
2016-08-29 6:55 ` Leizhen (ThunderTown)
2016-08-29 6:55 ` Leizhen (ThunderTown)
2016-08-29 6:55 ` Leizhen (ThunderTown)
2016-08-24 7:44 ` [PATCH v7 13/14] of/numa: remove the constraint on the distances of node pairs Zhen Lei
2016-08-24 7:44 ` Zhen Lei
2016-08-24 7:44 ` [PATCH v7 14/14] Documentation: " Zhen Lei
2016-08-24 7:44 ` Zhen Lei
2016-08-26 15:35 ` Will Deacon
2016-08-26 15:35 ` Will Deacon
2016-08-27 10:44 ` Leizhen (ThunderTown)
2016-08-27 10:44 ` Leizhen (ThunderTown)
2016-08-27 10:44 ` Leizhen (ThunderTown)
2016-08-30 17:55 ` Will Deacon
2016-08-30 17:55 ` Will Deacon
2016-08-30 17:55 ` Will Deacon
2016-08-31 2:46 ` Leizhen (ThunderTown)
2016-08-31 2:46 ` Leizhen (ThunderTown)
2016-08-31 2:46 ` Leizhen (ThunderTown)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57C16B88.7080500@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.