* [PATCH -next] ibmvscsis: Use list_move_tail instead of list_del/list_add_tail
@ 2016-07-22 14:03 Wei Yongjun
2016-08-26 15:50 ` Bryant G. Ly
2016-08-29 19:16 ` Tyrel Datwyler
0 siblings, 2 replies; 4+ messages in thread
From: Wei Yongjun @ 2016-07-22 14:03 UTC (permalink / raw)
To: Bryant G . Ly, Michael Cyr, James E.J. Bottomley,
Martin K. Petersen
Cc: Wei Yongjun, linux-scsi, target-devel
Using list_move_tail() instead of list_del() + list_add_tail().
Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
---
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
index b29fef9..7e873a7 100644
--- a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
+++ b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
@@ -3697,8 +3697,7 @@ static void ibmvscsis_release_cmd(struct se_cmd *se_cmd)
spin_lock_bh(&vscsi->intr_lock);
/* Remove from active_q */
- list_del(&cmd->list);
- list_add_tail(&cmd->list, &vscsi->waiting_rsp);
+ list_move_tail(&cmd->list, &vscsi->waiting_rsp);
ibmvscsis_send_messages(vscsi);
spin_unlock_bh(&vscsi->intr_lock);
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] ibmvscsis: Use list_move_tail instead of list_del/list_add_tail
2016-07-22 14:03 [PATCH -next] ibmvscsis: Use list_move_tail instead of list_del/list_add_tail Wei Yongjun
@ 2016-08-26 15:50 ` Bryant G. Ly
2016-08-29 19:16 ` Tyrel Datwyler
1 sibling, 0 replies; 4+ messages in thread
From: Bryant G. Ly @ 2016-08-26 15:50 UTC (permalink / raw)
To: Wei Yongjun, Michael Cyr, James E.J. Bottomley,
Martin K. Petersen
Cc: linux-scsi, target-devel
On 7/22/16, 9:03 AM, "Wei Yongjun" <target-devel-owner@vger.kernel.org on behalf of weiyj.lk@gmail.com> wrote:
Using list_move_tail() instead of list_del() + list_add_tail().
Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
---
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Looks good to me.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] ibmvscsis: Use list_move_tail instead of list_del/list_add_tail
2016-07-22 14:03 [PATCH -next] ibmvscsis: Use list_move_tail instead of list_del/list_add_tail Wei Yongjun
2016-08-26 15:50 ` Bryant G. Ly
@ 2016-08-29 19:16 ` Tyrel Datwyler
2016-08-31 4:19 ` Martin K. Petersen
1 sibling, 1 reply; 4+ messages in thread
From: Tyrel Datwyler @ 2016-08-29 19:16 UTC (permalink / raw)
To: Wei Yongjun, Bryant G . Ly, Michael Cyr, James E.J. Bottomley,
Martin K. Petersen
Cc: linux-scsi, target-devel
On 07/22/2016 07:03 AM, Wei Yongjun wrote:
> Using list_move_tail() instead of list_del() + list_add_tail().
>
> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
Reviewed-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] ibmvscsis: Use list_move_tail instead of list_del/list_add_tail
2016-08-29 19:16 ` Tyrel Datwyler
@ 2016-08-31 4:19 ` Martin K. Petersen
0 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2016-08-31 4:19 UTC (permalink / raw)
To: Tyrel Datwyler
Cc: Wei Yongjun, Bryant G . Ly, Michael Cyr, James E.J. Bottomley,
Martin K. Petersen, linux-scsi, target-devel
>>>>> "Tyrel" == Tyrel Datwyler <tyreld@linux.vnet.ibm.com> writes:
Tyrel> On 07/22/2016 07:03 AM, Wei Yongjun wrote:
>> Using list_move_tail() instead of list_del() + list_add_tail().
>>
>> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
Tyrel> Reviewed-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
Applied to 4.9/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-31 4:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-22 14:03 [PATCH -next] ibmvscsis: Use list_move_tail instead of list_del/list_add_tail Wei Yongjun
2016-08-26 15:50 ` Bryant G. Ly
2016-08-29 19:16 ` Tyrel Datwyler
2016-08-31 4:19 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.