From: Marc Zyngier <marc.zyngier@arm.com>
To: Christoffer Dall <christoffer.dall@linaro.org>
Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH 1/5] arm/arm64: KVM: Don't BUG_ON if IT bits are set in ARM mode
Date: Thu, 1 Sep 2016 13:21:23 +0100 [thread overview]
Message-ID: <57C81D43.4020606@arm.com> (raw)
In-Reply-To: <20160901115616.GD10162@cbox>
On 01/09/16 12:56, Christoffer Dall wrote:
> On Fri, Aug 19, 2016 at 01:38:11PM +0100, Marc Zyngier wrote:
>> The ARM ARM asserts that having the IT bits set in ARM mode is
>> unpredictable. But should a CPU do that (and still be able to
>> run correctly), we shouldn't kill the system.
>>
>> So let's drop the BUG_ON that checks for this, as it is not
>> very helpful.
>>
>> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
>
> not sure how this relates to the series, but looks fine otherwise:
In the following patch, I'm moving the whole function to be an inline
that will be used in HYP as well. A BUG_ON in HYP is a pretty tasteless
thing to do, so I opted for removing it here.
But your remark on the following patch makes more sense over all. I'll
follow up there.
> Reviewed-by: Christoffer Dall <christoffer.dall@linaro.org>
Thanks,
M.
--
Jazz is not dead. It just smells funny...
WARNING: multiple messages have this Message-ID (diff)
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] arm/arm64: KVM: Don't BUG_ON if IT bits are set in ARM mode
Date: Thu, 1 Sep 2016 13:21:23 +0100 [thread overview]
Message-ID: <57C81D43.4020606@arm.com> (raw)
In-Reply-To: <20160901115616.GD10162@cbox>
On 01/09/16 12:56, Christoffer Dall wrote:
> On Fri, Aug 19, 2016 at 01:38:11PM +0100, Marc Zyngier wrote:
>> The ARM ARM asserts that having the IT bits set in ARM mode is
>> unpredictable. But should a CPU do that (and still be able to
>> run correctly), we shouldn't kill the system.
>>
>> So let's drop the BUG_ON that checks for this, as it is not
>> very helpful.
>>
>> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
>
> not sure how this relates to the series, but looks fine otherwise:
In the following patch, I'm moving the whole function to be an inline
that will be used in HYP as well. A BUG_ON in HYP is a pretty tasteless
thing to do, so I opted for removing it here.
But your remark on the following patch makes more sense over all. I'll
follow up there.
> Reviewed-by: Christoffer Dall <christoffer.dall@linaro.org>
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2016-09-01 12:13 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-19 12:38 [PATCH 0/5] arm64: KVM: vgic-v2: Allow unsafe GICV accesses Marc Zyngier
2016-08-19 12:38 ` Marc Zyngier
2016-08-19 12:38 ` [PATCH 1/5] arm/arm64: KVM: Don't BUG_ON if IT bits are set in ARM mode Marc Zyngier
2016-08-19 12:38 ` Marc Zyngier
2016-09-01 11:56 ` Christoffer Dall
2016-09-01 11:56 ` Christoffer Dall
2016-09-01 12:21 ` Marc Zyngier [this message]
2016-09-01 12:21 ` Marc Zyngier
2016-08-19 12:38 ` [PATCH 2/5] arm64: KVM: Allow kvm_skip_instr32 to be shared between kernel and HYP code Marc Zyngier
2016-08-19 12:38 ` Marc Zyngier
2016-09-01 12:09 ` Christoffer Dall
2016-09-01 12:09 ` Christoffer Dall
2016-09-01 12:23 ` Marc Zyngier
2016-09-01 12:23 ` Marc Zyngier
2016-09-01 12:45 ` Peter Maydell
2016-09-01 12:45 ` Peter Maydell
2016-08-19 12:38 ` [PATCH 3/5] arm64: KVM: vgic-v2: Add the GICV emulation infrastructure Marc Zyngier
2016-08-19 12:38 ` Marc Zyngier
2016-09-01 12:46 ` Christoffer Dall
2016-09-01 12:46 ` Christoffer Dall
2016-09-01 14:28 ` Marc Zyngier
2016-09-01 14:28 ` Marc Zyngier
2016-09-01 14:39 ` Peter Maydell
2016-09-01 14:39 ` Peter Maydell
2016-09-01 14:55 ` Christoffer Dall
2016-09-01 14:55 ` Christoffer Dall
2016-08-19 12:38 ` [PATCH 4/5] arm64: KVM: vgic-v2: Add GICV access from HYP Marc Zyngier
2016-08-19 12:38 ` Marc Zyngier
2016-09-01 13:28 ` Christoffer Dall
2016-09-01 13:28 ` Christoffer Dall
2016-08-19 12:38 ` [PATCH 5/5] arm64: KVM: vgic-v2: Enable GICV access from HYP if access from guest is unsafe Marc Zyngier
2016-08-19 12:38 ` Marc Zyngier
2016-08-19 12:53 ` Peter Maydell
2016-08-19 12:53 ` Peter Maydell
2016-08-19 13:05 ` Marc Zyngier
2016-08-19 13:05 ` Marc Zyngier
2016-08-19 13:31 ` Peter Maydell
2016-08-19 13:31 ` Peter Maydell
2016-08-19 14:54 ` Marc Zyngier
2016-08-19 14:54 ` Marc Zyngier
2016-09-01 13:30 ` Christoffer Dall
2016-09-01 13:30 ` Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57C81D43.4020606@arm.com \
--to=marc.zyngier@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.