From: David Daney <ddaney@caviumnetworks.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Ralf Baechle <ralf@linux-mips.org>, <linux-mips@linux-mips.org>
Subject: Re: [PATCH 5/6] MIPS: OCTEON: delete legacy code for PHY access
Date: Thu, 1 Sep 2016 16:00:35 -0700 [thread overview]
Message-ID: <57C8B313.6030206@caviumnetworks.com> (raw)
In-Reply-To: <20160901204400.16562-6-aaro.koskinen@iki.fi>
On 09/01/2016 01:43 PM, Aaro Koskinen wrote:
> PHY access through the board helper should be impossible with the
> current drivers, so delete this code and add BUG_ON().
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> ---
> .../cavium-octeon/executive/cvmx-helper-board.c | 110 +--------------------
> 1 file changed, 5 insertions(+), 105 deletions(-)
>
> diff --git a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
> index 5572e39..8d75242 100644
> --- a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
> +++ b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
[...]
> + BUG_ON(cvmx_helper_board_get_mii_address(ipd_port) != -1);
>
Can we do WARN_ON instead?
No need to crash the kernel for this I think.
David Daney
WARNING: multiple messages have this Message-ID (diff)
From: David Daney <ddaney@caviumnetworks.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Subject: Re: [PATCH 5/6] MIPS: OCTEON: delete legacy code for PHY access
Date: Thu, 1 Sep 2016 16:00:35 -0700 [thread overview]
Message-ID: <57C8B313.6030206@caviumnetworks.com> (raw)
Message-ID: <20160901230035.fAhosjl-M2HrCL5ahV5Y6ftzjAJBsHxRDeoFLj0Imqs@z> (raw)
In-Reply-To: <20160901204400.16562-6-aaro.koskinen@iki.fi>
On 09/01/2016 01:43 PM, Aaro Koskinen wrote:
> PHY access through the board helper should be impossible with the
> current drivers, so delete this code and add BUG_ON().
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> ---
> .../cavium-octeon/executive/cvmx-helper-board.c | 110 +--------------------
> 1 file changed, 5 insertions(+), 105 deletions(-)
>
> diff --git a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
> index 5572e39..8d75242 100644
> --- a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
> +++ b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
[...]
> + BUG_ON(cvmx_helper_board_get_mii_address(ipd_port) != -1);
>
Can we do WARN_ON instead?
No need to crash the kernel for this I think.
David Daney
next prev parent reply other threads:[~2016-09-01 23:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 20:43 [PATCH 0/6] MIPS: OCTEON: clean up platform phy code Aaro Koskinen
2016-09-01 20:43 ` [PATCH 1/6] MIPS: OCTEON: delete legacy hack for broken bootloaders Aaro Koskinen
2016-09-01 20:43 ` [PATCH 2/6] MIPS: OCTEON: don't try to maintain link state in early init Aaro Koskinen
2016-09-01 20:43 ` [PATCH 3/6] MIPS: OCTEON: delete cvmx_override_board_link_get Aaro Koskinen
2016-09-01 20:43 ` [PATCH 4/6] MIPS: OCTEON: delete cvmx_helper_board_link_set_phy Aaro Koskinen
2016-09-01 20:43 ` [PATCH 5/6] MIPS: OCTEON: delete legacy code for PHY access Aaro Koskinen
2016-09-01 23:00 ` David Daney [this message]
2016-09-01 23:00 ` David Daney
2016-09-01 23:45 ` Aaro Koskinen
2016-09-02 17:59 ` Aaro Koskinen
2016-09-01 20:44 ` [PATCH 6/6] MIPS: OCTEON: delete unused cvmx-mdio.h Aaro Koskinen
2016-09-01 23:02 ` David Daney
2016-09-01 23:02 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57C8B313.6030206@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=aaro.koskinen@iki.fi \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.