From: Kishon Vijay Abraham I <kishon@ti.com>
To: Arnd Bergmann <arnd@arndb.de>, Baoyou Xie <baoyou.xie@linaro.org>
Cc: swarren@wwwdotorg.org, thierry.reding@gmail.com,
gnurou@gmail.com, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org, xie.baoyou@zte.com.cn
Subject: Re: [PATCH] phy: mark tegra_xusb_lane_lookup_function() static
Date: Fri, 2 Sep 2016 17:45:32 +0530 [thread overview]
Message-ID: <57C96D64.9050600@ti.com> (raw)
In-Reply-To: <7060924.RuInUXIHDe@wuerfel>
Hi,
On Wednesday 31 August 2016 03:31 PM, Arnd Bergmann wrote:
> On Wednesday, August 31, 2016 5:05:19 PM CEST Baoyou Xie wrote:
>> We get 1 warning when building kernel with W=1:
>> drivers/phy/tegra/xusb.c:104:5: warning: no previous prototype for 'tegra_xusb_lane_lookup_function' [-Wmissing-prototypes]
>>
>> In fact, this function is only used in the file in which it is
>> declared and don't need a declaration, but can be made static.
>> So this patch marks it 'static'.
>>
>> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
>>
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> Same comment as for the other patch, it's better to use "phy: tegra: ..."
> in the subject for clarity.
Fixed it myself and merged this and the other patch.
Thanks
Kishon
WARNING: multiple messages have this Message-ID (diff)
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Arnd Bergmann <arnd@arndb.de>, Baoyou Xie <baoyou.xie@linaro.org>
Cc: <swarren@wwwdotorg.org>, <thierry.reding@gmail.com>,
<gnurou@gmail.com>, <linux-kernel@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, <xie.baoyou@zte.com.cn>
Subject: Re: [PATCH] phy: mark tegra_xusb_lane_lookup_function() static
Date: Fri, 2 Sep 2016 17:45:32 +0530 [thread overview]
Message-ID: <57C96D64.9050600@ti.com> (raw)
In-Reply-To: <7060924.RuInUXIHDe@wuerfel>
Hi,
On Wednesday 31 August 2016 03:31 PM, Arnd Bergmann wrote:
> On Wednesday, August 31, 2016 5:05:19 PM CEST Baoyou Xie wrote:
>> We get 1 warning when building kernel with W=1:
>> drivers/phy/tegra/xusb.c:104:5: warning: no previous prototype for 'tegra_xusb_lane_lookup_function' [-Wmissing-prototypes]
>>
>> In fact, this function is only used in the file in which it is
>> declared and don't need a declaration, but can be made static.
>> So this patch marks it 'static'.
>>
>> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
>>
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> Same comment as for the other patch, it's better to use "phy: tegra: ..."
> in the subject for clarity.
Fixed it myself and merged this and the other patch.
Thanks
Kishon
next prev parent reply other threads:[~2016-09-02 12:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 9:05 [PATCH] phy: mark tegra_xusb_lane_lookup_function() static Baoyou Xie
[not found] ` <1472634319-11886-1-git-send-email-baoyou.xie-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-08-31 10:01 ` Arnd Bergmann
2016-08-31 10:01 ` Arnd Bergmann
2016-09-02 12:15 ` Kishon Vijay Abraham I [this message]
2016-09-02 12:15 ` Kishon Vijay Abraham I
2016-09-01 11:34 ` Thierry Reding
2016-09-01 11:34 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57C96D64.9050600@ti.com \
--to=kishon@ti.com \
--cc=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=gnurou@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.