* [PATCH] Fix no. of gpio cells in the pxa gpio binding doucmentation
@ 2016-09-05 6:15 Vijay Kumar
0 siblings, 0 replies; 3+ messages in thread
From: Vijay Kumar @ 2016-09-05 6:15 UTC (permalink / raw)
To: linux-arm-kernel
Fix no. of gpio cells in pxa gpio binding documentation.
The no. of gpio cells for the pxa gpio is actually 2. But is
incorrectly specified as 1, in the binding documentation. From the
driver code, the second cell specifies the standard flags as described
in gpio.txt.
Signed-off-by: Vijay Kumar B. <vijaykumar@zilogic.com>
Index: linux-4.7.1/Documentation/devicetree/bindings/gpio/mrvl-gpio.txt
===================================================================
--- linux-4.7.1.orig/Documentation/devicetree/bindings/gpio/mrvl-gpio.txt
+++ linux-4.7.1/Documentation/devicetree/bindings/gpio/mrvl-gpio.txt
@@ -17,7 +17,9 @@ Required properties:
- #interrupt-cells: Specifies the number of cells needed to encode an
interrupt source.
- gpio-controller : Marks the device node as a gpio controller.
-- #gpio-cells : Should be one. It is the pin number.
+- #gpio-cells : Should be two. The first cell is the pin number and
+ the second cell is used to specify flags. See gpio.txt for possible
+ values.
Example for a MMP platform:
@@ -27,7 +29,7 @@ Example for a MMP platform:
interrupts = <49>;
interrupt-names = "gpio_mux";
gpio-controller;
- #gpio-cells = <1>;
+ #gpio-cells = <2>;
interrupt-controller;
#interrupt-cells = <1>;
};
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] Fix no. of gpio cells in the pxa gpio binding doucmentation
@ 2016-09-05 6:20 Vijay Kumar
2016-09-18 17:23 ` Robert Jarzmik
0 siblings, 1 reply; 3+ messages in thread
From: Vijay Kumar @ 2016-09-05 6:20 UTC (permalink / raw)
To: Robert Jarzmik; +Cc: linux-gpio
Fix the no. of gpio cells in pxa gpio binding documentation.
The no. of gpio cells for the pxa gpio is actually 2. But is
incorrectly specified as 1, in the binding documentation. From the
driver code, the second cell specifies the standard flags as described
in gpio.txt.
Signed-off-by: Vijay Kumar B. <vijaykumar@zilogic.com>
Index: linux-4.7.1/Documentation/devicetree/bindings/gpio/mrvl-gpio.txt
===================================================================
--- linux-4.7.1.orig/Documentation/devicetree/bindings/gpio/mrvl-gpio.txt
+++ linux-4.7.1/Documentation/devicetree/bindings/gpio/mrvl-gpio.txt
@@ -17,7 +17,9 @@ Required properties:
- #interrupt-cells: Specifies the number of cells needed to encode an
interrupt source.
- gpio-controller : Marks the device node as a gpio controller.
-- #gpio-cells : Should be one. It is the pin number.
+- #gpio-cells : Should be two. The first cell is the pin number and
+ the second cell is used to specify flags. See gpio.txt for possible
+ values.
Example for a MMP platform:
@@ -27,7 +29,7 @@ Example for a MMP platform:
interrupts = <49>;
interrupt-names = "gpio_mux";
gpio-controller;
- #gpio-cells = <1>;
+ #gpio-cells = <2>;
interrupt-controller;
#interrupt-cells = <1>;
};
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix no. of gpio cells in the pxa gpio binding doucmentation
2016-09-05 6:20 Vijay Kumar
@ 2016-09-18 17:23 ` Robert Jarzmik
0 siblings, 0 replies; 3+ messages in thread
From: Robert Jarzmik @ 2016-09-18 17:23 UTC (permalink / raw)
To: Vijay Kumar; +Cc: linux-gpio
Vijay Kumar <vijaykumar@zilogic.com> writes:
> Fix the no. of gpio cells in pxa gpio binding documentation.
>
> The no. of gpio cells for the pxa gpio is actually 2. But is
> incorrectly specified as 1, in the binding documentation. From the
> driver code, the second cell specifies the standard flags as described
> in gpio.txt.
>
> Signed-off-by: Vijay Kumar B. <vijaykumar@zilogic.com>
Yes, that's correct. I'll add this to pxa/dt tree, thanks.
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-18 17:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-05 6:15 [PATCH] Fix no. of gpio cells in the pxa gpio binding doucmentation Vijay Kumar
-- strict thread matches above, loose matches on Subject: below --
2016-09-05 6:20 Vijay Kumar
2016-09-18 17:23 ` Robert Jarzmik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.