From: Neil Armstrong <narmstrong@baylibre.com>
To: Axel Lin <axel.lin@ingics.com>,
Thierry Reding <thierry.reding@gmail.com>
Cc: linux-pwm@vger.kernel.org
Subject: Re: [PATCH] pwm: meson: Fix missing spin_lock_init
Date: Sat, 10 Sep 2016 15:49:31 +0200 [thread overview]
Message-ID: <57D40F6B.1030708@baylibre.com> (raw)
In-Reply-To: <1473472549-20140-1-git-send-email-axel.lin@ingics.com>
Le 10/09/2016 03:55, Axel Lin a écrit :
> The driver uses the spin_lock but not initialize it, fix it.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/pwm/pwm-meson.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c
> index 381871b..9d5bd7d 100644
> --- a/drivers/pwm/pwm-meson.c
> +++ b/drivers/pwm/pwm-meson.c
> @@ -474,6 +474,7 @@ static int meson_pwm_probe(struct platform_device *pdev)
> if (IS_ERR(meson->base))
> return PTR_ERR(meson->base);
>
> + spin_lock_init(&meson->lock);
> meson->chip.dev = &pdev->dev;
> meson->chip.ops = &meson_pwm_ops;
> meson->chip.base = -1;
>
Silly error !
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
next prev parent reply other threads:[~2016-09-10 13:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-10 1:55 [PATCH] pwm: meson: Fix missing spin_lock_init Axel Lin
2016-09-10 13:49 ` Neil Armstrong [this message]
2016-10-21 7:12 ` Thierry Reding
2016-11-28 2:28 ` Axel Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57D40F6B.1030708@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=axel.lin@ingics.com \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.