* [PATCH] pwm: meson: Fix missing spin_lock_init
@ 2016-09-10 1:55 Axel Lin
2016-09-10 13:49 ` Neil Armstrong
2016-10-21 7:12 ` Thierry Reding
0 siblings, 2 replies; 4+ messages in thread
From: Axel Lin @ 2016-09-10 1:55 UTC (permalink / raw)
To: Thierry Reding; +Cc: Neil Armstrong, linux-pwm, Axel Lin
The driver uses the spin_lock but not initialize it, fix it.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/pwm/pwm-meson.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c
index 381871b..9d5bd7d 100644
--- a/drivers/pwm/pwm-meson.c
+++ b/drivers/pwm/pwm-meson.c
@@ -474,6 +474,7 @@ static int meson_pwm_probe(struct platform_device *pdev)
if (IS_ERR(meson->base))
return PTR_ERR(meson->base);
+ spin_lock_init(&meson->lock);
meson->chip.dev = &pdev->dev;
meson->chip.ops = &meson_pwm_ops;
meson->chip.base = -1;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] pwm: meson: Fix missing spin_lock_init
2016-09-10 1:55 [PATCH] pwm: meson: Fix missing spin_lock_init Axel Lin
@ 2016-09-10 13:49 ` Neil Armstrong
2016-10-21 7:12 ` Thierry Reding
1 sibling, 0 replies; 4+ messages in thread
From: Neil Armstrong @ 2016-09-10 13:49 UTC (permalink / raw)
To: Axel Lin, Thierry Reding; +Cc: linux-pwm
Le 10/09/2016 03:55, Axel Lin a écrit :
> The driver uses the spin_lock but not initialize it, fix it.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/pwm/pwm-meson.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c
> index 381871b..9d5bd7d 100644
> --- a/drivers/pwm/pwm-meson.c
> +++ b/drivers/pwm/pwm-meson.c
> @@ -474,6 +474,7 @@ static int meson_pwm_probe(struct platform_device *pdev)
> if (IS_ERR(meson->base))
> return PTR_ERR(meson->base);
>
> + spin_lock_init(&meson->lock);
> meson->chip.dev = &pdev->dev;
> meson->chip.ops = &meson_pwm_ops;
> meson->chip.base = -1;
>
Silly error !
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pwm: meson: Fix missing spin_lock_init
2016-09-10 1:55 [PATCH] pwm: meson: Fix missing spin_lock_init Axel Lin
2016-09-10 13:49 ` Neil Armstrong
@ 2016-10-21 7:12 ` Thierry Reding
2016-11-28 2:28 ` Axel Lin
1 sibling, 1 reply; 4+ messages in thread
From: Thierry Reding @ 2016-10-21 7:12 UTC (permalink / raw)
To: Axel Lin; +Cc: Neil Armstrong, linux-pwm
[-- Attachment #1: Type: text/plain, Size: 301 bytes --]
On Sat, Sep 10, 2016 at 09:55:49AM +0800, Axel Lin wrote:
> The driver uses the spin_lock but not initialize it, fix it.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/pwm/pwm-meson.c | 1 +
> 1 file changed, 1 insertion(+)
Applied to for-4.9/fixes.
Thanks,
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pwm: meson: Fix missing spin_lock_init
2016-10-21 7:12 ` Thierry Reding
@ 2016-11-28 2:28 ` Axel Lin
0 siblings, 0 replies; 4+ messages in thread
From: Axel Lin @ 2016-11-28 2:28 UTC (permalink / raw)
To: Thierry Reding; +Cc: Neil Armstrong, linux-pwm
2016-10-21 15:12 GMT+08:00 Thierry Reding <thierry.reding@gmail.com>:
> On Sat, Sep 10, 2016 at 09:55:49AM +0800, Axel Lin wrote:
>> The driver uses the spin_lock but not initialize it, fix it.
>>
>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>> ---
>> drivers/pwm/pwm-meson.c | 1 +
>> 1 file changed, 1 insertion(+)
>
> Applied to for-4.9/fixes.
Hi Thierry,
I still don't find this fix in linux-next?
Regards,
Axel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-28 2:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-10 1:55 [PATCH] pwm: meson: Fix missing spin_lock_init Axel Lin
2016-09-10 13:49 ` Neil Armstrong
2016-10-21 7:12 ` Thierry Reding
2016-11-28 2:28 ` Axel Lin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.