From: Marc Zyngier <marc.zyngier@arm.com>
To: Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: linux-gpio@vger.kernel.org
Subject: Re: [PATCH] pinctrl: nomadik: don't default-flag IRQs as falling
Date: Mon, 19 Sep 2016 09:50:00 +0100 [thread overview]
Message-ID: <57DFA6B8.5070306@arm.com> (raw)
In-Reply-To: <1474273330-15789-1-git-send-email-linus.walleij@linaro.org>
On 19/09/16 09:22, Linus Walleij wrote:
> There is no point in adding any default trigger for these
> GPIO interrupts: the device tree should contain all trigger
> information and the platforms using the driver boots
> exclusively from device tree.
>
> Also the boot log is nagging me to fix this:
>
> [ 0.771057] ------------[ cut here ]------------
> [ 0.775695] WARNING: CPU: 0 PID: 1 at
> ../drivers/gpio/gpiolib.c:1622 _gpiochip_irqchip_add+0x138/0x160
> [ 0.785034] /soc/gpio@8012e000: Ignoring 2 default trigger
> (...)
> [ 0.942962] gpio 8012e000.gpio: at address e08f8000
> (etc ad nauseam)
>
> Suggested-by: Marc Zyngier <marc.zyngier@arm.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/pinctrl/nomadik/pinctrl-nomadik.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
> index 205fb399268a..d318ca055489 100644
> --- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c
> +++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
> @@ -1177,7 +1177,7 @@ static int nmk_gpio_probe(struct platform_device *dev)
> irqchip,
> 0,
> handle_edge_irq,
> - IRQ_TYPE_EDGE_FALLING);
> + IRQ_TYPE_NONE);
> if (ret) {
> dev_err(&dev->dev, "could not add irqchip\n");
> gpiochip_remove(&nmk_chip->chip);
>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
M.
--
Jazz is not dead. It just smells funny...
WARNING: multiple messages have this Message-ID (diff)
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: nomadik: don't default-flag IRQs as falling
Date: Mon, 19 Sep 2016 09:50:00 +0100 [thread overview]
Message-ID: <57DFA6B8.5070306@arm.com> (raw)
In-Reply-To: <1474273330-15789-1-git-send-email-linus.walleij@linaro.org>
On 19/09/16 09:22, Linus Walleij wrote:
> There is no point in adding any default trigger for these
> GPIO interrupts: the device tree should contain all trigger
> information and the platforms using the driver boots
> exclusively from device tree.
>
> Also the boot log is nagging me to fix this:
>
> [ 0.771057] ------------[ cut here ]------------
> [ 0.775695] WARNING: CPU: 0 PID: 1 at
> ../drivers/gpio/gpiolib.c:1622 _gpiochip_irqchip_add+0x138/0x160
> [ 0.785034] /soc/gpio at 8012e000: Ignoring 2 default trigger
> (...)
> [ 0.942962] gpio 8012e000.gpio: at address e08f8000
> (etc ad nauseam)
>
> Suggested-by: Marc Zyngier <marc.zyngier@arm.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/pinctrl/nomadik/pinctrl-nomadik.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
> index 205fb399268a..d318ca055489 100644
> --- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c
> +++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
> @@ -1177,7 +1177,7 @@ static int nmk_gpio_probe(struct platform_device *dev)
> irqchip,
> 0,
> handle_edge_irq,
> - IRQ_TYPE_EDGE_FALLING);
> + IRQ_TYPE_NONE);
> if (ret) {
> dev_err(&dev->dev, "could not add irqchip\n");
> gpiochip_remove(&nmk_chip->chip);
>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2016-09-19 8:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 8:22 [PATCH] pinctrl: nomadik: don't default-flag IRQs as falling Linus Walleij
2016-09-19 8:22 ` Linus Walleij
2016-09-19 8:50 ` Marc Zyngier [this message]
2016-09-19 8:50 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57DFA6B8.5070306@arm.com \
--to=marc.zyngier@arm.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.