* [PATCH] PM / devfreq: exynos-ppmu: Remove unused mutex from struct exynos_ppmu @ 2016-09-20 6:48 ` Axel Lin 2016-09-20 8:07 ` Chanwoo Choi 0 siblings, 1 reply; 3+ messages in thread From: Axel Lin @ 2016-09-20 6:48 UTC (permalink / raw) To: Rafael J . Wysocki Cc: Chanwoo Choi, MyungJoo Ham, Kyungmin Park, linux-pm, linux-samsung-soc, Axel Lin The mutex is not used at all, remove it. Signed-off-by: Axel Lin <axel.lin@ingics.com> --- drivers/devfreq/event/exynos-ppmu.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c index f55cf0e..251692b 100644 --- a/drivers/devfreq/event/exynos-ppmu.c +++ b/drivers/devfreq/event/exynos-ppmu.c @@ -15,7 +15,6 @@ #include <linux/io.h> #include <linux/kernel.h> #include <linux/module.h> -#include <linux/mutex.h> #include <linux/of_address.h> #include <linux/platform_device.h> #include <linux/suspend.h> @@ -34,7 +33,6 @@ struct exynos_ppmu { unsigned int num_events; struct device *dev; - struct mutex lock; struct exynos_ppmu_data ppmu; }; @@ -463,7 +461,6 @@ static int exynos_ppmu_probe(struct platform_device *pdev) if (!info) return -ENOMEM; - mutex_init(&info->lock); info->dev = &pdev->dev; /* Parse dt data to get resource */ -- 2.7.4 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] PM / devfreq: exynos-ppmu: Remove unused mutex from struct exynos_ppmu 2016-09-20 6:48 ` [PATCH] PM / devfreq: exynos-ppmu: Remove unused mutex from struct exynos_ppmu Axel Lin @ 2016-09-20 8:07 ` Chanwoo Choi 2016-09-20 8:09 ` Axel Lin 0 siblings, 1 reply; 3+ messages in thread From: Chanwoo Choi @ 2016-09-20 8:07 UTC (permalink / raw) To: Axel Lin, Rafael J . Wysocki Cc: MyungJoo Ham, Kyungmin Park, linux-pm, linux-samsung-soc Hi, If you remove the mutex, you better to remove the header "#include <linux/mutex.h>" from exynos-ppmu.c. If you remove the header file, looks good to me and feel free to add my tag. Acked-by: Chanwoo Choi <cw00.choi@samsung.com> Best Regards, Chanwoo Choi On 2016년 09월 20일 15:48, Axel Lin wrote: > The mutex is not used at all, remove it. > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > --- > drivers/devfreq/event/exynos-ppmu.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c > index f55cf0e..251692b 100644 > --- a/drivers/devfreq/event/exynos-ppmu.c > +++ b/drivers/devfreq/event/exynos-ppmu.c > @@ -15,7 +15,6 @@ > #include <linux/io.h> > #include <linux/kernel.h> > #include <linux/module.h> > -#include <linux/mutex.h> > #include <linux/of_address.h> > #include <linux/platform_device.h> > #include <linux/suspend.h> > @@ -34,7 +33,6 @@ struct exynos_ppmu { > unsigned int num_events; > > struct device *dev; > - struct mutex lock; > > struct exynos_ppmu_data ppmu; > }; > @@ -463,7 +461,6 @@ static int exynos_ppmu_probe(struct platform_device *pdev) > if (!info) > return -ENOMEM; > > - mutex_init(&info->lock); > info->dev = &pdev->dev; > > /* Parse dt data to get resource */ > ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PM / devfreq: exynos-ppmu: Remove unused mutex from struct exynos_ppmu 2016-09-20 8:07 ` Chanwoo Choi @ 2016-09-20 8:09 ` Axel Lin 0 siblings, 0 replies; 3+ messages in thread From: Axel Lin @ 2016-09-20 8:09 UTC (permalink / raw) To: Chanwoo Choi Cc: Rafael J . Wysocki, MyungJoo Ham, Kyungmin Park, linux-pm, linux-samsung-soc@vger.kernel.org 2016-09-20 16:07 GMT+08:00 Chanwoo Choi <cw00.choi@samsung.com>: > Hi, > > If you remove the mutex, you better to remove > the header "#include <linux/mutex.h>" from exynos-ppmu.c. Yes, I did remove it in this path. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-20 8:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20160920064920epcas1p20cac67f7f048c80fdcbe489e235e0cdb@epcas1p2.samsung.com>
2016-09-20 6:48 ` [PATCH] PM / devfreq: exynos-ppmu: Remove unused mutex from struct exynos_ppmu Axel Lin
2016-09-20 8:07 ` Chanwoo Choi
2016-09-20 8:09 ` Axel Lin
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.