All of lore.kernel.org
 help / color / mirror / Atom feed
From: zijun_hu <zijun_hu@zoho.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	zijun_hu@htc.com, tj@kernel.org, mingo@kernel.org,
	rientjes@google.com, iamjoonsoo.kim@lge.com,
	mgorman@techsingularity.net
Subject: [PATCH 3/5] mm/vmalloc.c: correct lazy_max_pages() return value
Date: Wed, 21 Sep 2016 12:27:53 +0800	[thread overview]
Message-ID: <57E20C49.8010304@zoho.com> (raw)

From: zijun_hu <zijun_hu@htc.com>

correct lazy_max_pages() return value if the number of online
CPUs is power of 2

Signed-off-by: zijun_hu <zijun_hu@htc.com>
---
 mm/vmalloc.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index a125ae8..2804224 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -594,7 +594,9 @@ static unsigned long lazy_max_pages(void)
 {
 	unsigned int log;
 
-	log = fls(num_online_cpus());
+	log = num_online_cpus();
+	if (log > 1)
+		log = (unsigned int)get_count_order(log);
 
 	return log * (32UL * 1024 * 1024 / PAGE_SIZE);
 }
-- 
1.9.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: zijun_hu <zijun_hu@zoho.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	zijun_hu@htc.com, tj@kernel.org, mingo@kernel.org,
	rientjes@google.com, iamjoonsoo.kim@lge.com,
	mgorman@techsingularity.net
Subject: [PATCH 3/5] mm/vmalloc.c: correct lazy_max_pages() return value
Date: Wed, 21 Sep 2016 12:27:53 +0800	[thread overview]
Message-ID: <57E20C49.8010304@zoho.com> (raw)

From: zijun_hu <zijun_hu@htc.com>

correct lazy_max_pages() return value if the number of online
CPUs is power of 2

Signed-off-by: zijun_hu <zijun_hu@htc.com>
---
 mm/vmalloc.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index a125ae8..2804224 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -594,7 +594,9 @@ static unsigned long lazy_max_pages(void)
 {
 	unsigned int log;
 
-	log = fls(num_online_cpus());
+	log = num_online_cpus();
+	if (log > 1)
+		log = (unsigned int)get_count_order(log);
 
 	return log * (32UL * 1024 * 1024 / PAGE_SIZE);
 }
-- 
1.9.1

             reply	other threads:[~2016-09-21  4:28 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-21  4:27 zijun_hu [this message]
2016-09-21  4:27 ` [PATCH 3/5] mm/vmalloc.c: correct lazy_max_pages() return value zijun_hu
2016-09-21 21:21 ` David Rientjes
2016-09-21 21:21   ` David Rientjes
2016-09-21 23:30   ` zijun_hu
2016-09-21 23:30     ` zijun_hu
2016-09-22  0:35     ` David Rientjes
2016-09-22  0:35       ` David Rientjes
2016-09-22  1:13       ` zijun_hu
2016-09-22  1:13         ` zijun_hu
2016-09-22 12:37         ` Michal Hocko
2016-09-22 12:37           ` Michal Hocko
2016-09-22 16:30           ` zijun_hu
2016-09-22 16:30             ` zijun_hu
2016-09-23  3:30             ` Nicholas Piggin
2016-09-23  3:30               ` Nicholas Piggin
2016-09-23  5:00               ` zijun_hu
2016-09-23  5:00                 ` zijun_hu
2016-09-23  7:27                 ` Nicholas Piggin
2016-09-23  7:27                   ` Nicholas Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57E20C49.8010304@zoho.com \
    --to=zijun_hu@zoho.com \
    --cc=akpm@linux-foundation.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=mingo@kernel.org \
    --cc=rientjes@google.com \
    --cc=tj@kernel.org \
    --cc=zijun_hu@htc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.