From: zijun_hu <zijun_hu@zoho.com>
To: David Rientjes <rientjes@google.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
zijun_hu@htc.com, Andrew Morton <akpm@linux-foundation.org>,
tj@kernel.org, mingo@kernel.org, iamjoonsoo.kim@lge.com,
mgorman@techsingularity.net
Subject: Re: [PATCH 1/5] mm/vmalloc.c: correct a few logic error for __insert_vmap_area()
Date: Tue, 27 Sep 2016 14:07:02 +0800 [thread overview]
Message-ID: <57EA0C86.3010303@zoho.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1609211612280.42217@chino.kir.corp.google.com>
On 09/22/2016 07:15 AM, David Rientjes wrote:
> On Thu, 22 Sep 2016, zijun_hu wrote:
>
>>> We don't support inserting when va->va_start == tmp_va->va_end, plain and
>>> simple. There's no reason to do so. NACK to the patch.
>>>
>> i am sorry i disagree with you because
>> 1) in almost all context of vmalloc, original logic treat the special case as normal
>> for example, __find_vmap_area() or alloc_vmap_area()
>
> The ranges are [start, end) like everywhere else. __find_vmap_area() is
> implemented as such for the passed address. The address is aligned in
> alloc_vmap_area(), there's no surprise here. The logic is correct in
> __insert_vmap_area().
>
i am sorry to disagree with you
i will resend this patch with more detailed illustration
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: zijun_hu <zijun_hu@zoho.com>
To: David Rientjes <rientjes@google.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
zijun_hu@htc.com, Andrew Morton <akpm@linux-foundation.org>,
tj@kernel.org, mingo@kernel.org, iamjoonsoo.kim@lge.com,
mgorman@techsingularity.net
Subject: Re: [PATCH 1/5] mm/vmalloc.c: correct a few logic error for __insert_vmap_area()
Date: Tue, 27 Sep 2016 14:07:02 +0800 [thread overview]
Message-ID: <57EA0C86.3010303@zoho.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1609211612280.42217@chino.kir.corp.google.com>
On 09/22/2016 07:15 AM, David Rientjes wrote:
> On Thu, 22 Sep 2016, zijun_hu wrote:
>
>>> We don't support inserting when va->va_start == tmp_va->va_end, plain and
>>> simple. There's no reason to do so. NACK to the patch.
>>>
>> i am sorry i disagree with you because
>> 1) in almost all context of vmalloc, original logic treat the special case as normal
>> for example, __find_vmap_area() or alloc_vmap_area()
>
> The ranges are [start, end) like everywhere else. __find_vmap_area() is
> implemented as such for the passed address. The address is aligned in
> alloc_vmap_area(), there's no surprise here. The logic is correct in
> __insert_vmap_area().
>
i am sorry to disagree with you
i will resend this patch with more detailed illustration
next prev parent reply other threads:[~2016-09-27 6:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 4:23 [PATCH 1/5] mm/vmalloc.c: correct a few logic error for __insert_vmap_area() zijun_hu
2016-09-21 4:23 ` zijun_hu
2016-09-21 21:10 ` David Rientjes
2016-09-21 21:10 ` David Rientjes
2016-09-21 22:35 ` zijun_hu
2016-09-21 22:35 ` zijun_hu
2016-09-21 22:45 ` David Rientjes
2016-09-21 22:45 ` David Rientjes
2016-09-21 23:10 ` zijun_hu
2016-09-21 23:10 ` zijun_hu
2016-09-21 23:15 ` David Rientjes
2016-09-21 23:15 ` David Rientjes
2016-09-21 23:55 ` zijun_hu
2016-09-21 23:55 ` zijun_hu
2016-09-27 6:07 ` zijun_hu [this message]
2016-09-27 6:07 ` zijun_hu
2016-09-22 1:36 ` [RFC PATCH " zijun_hu
2016-09-22 1:36 ` zijun_hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57EA0C86.3010303@zoho.com \
--to=zijun_hu@zoho.com \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mingo@kernel.org \
--cc=rientjes@google.com \
--cc=tj@kernel.org \
--cc=zijun_hu@htc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.