* [meta-networking][PATCH] phytool: Add recipe @ 2016-09-23 12:33 Mike Looijmans 2016-09-23 18:33 ` Khem Raj 2016-09-28 7:53 ` [PATCH " Mike Looijmans 0 siblings, 2 replies; 12+ messages in thread From: Mike Looijmans @ 2016-09-23 12:33 UTC (permalink / raw) To: openembedded-devel A nice tool to directly read, write and interpret ethernet PHY data. Very useful when debugging PHY or MDIO problems, which ethtool does not do. Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> --- meta-networking/recipes-support/phytool/phytool.bb | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 meta-networking/recipes-support/phytool/phytool.bb diff --git a/meta-networking/recipes-support/phytool/phytool.bb b/meta-networking/recipes-support/phytool/phytool.bb new file mode 100644 index 0000000..9d541b7 --- /dev/null +++ b/meta-networking/recipes-support/phytool/phytool.bb @@ -0,0 +1,14 @@ +SUMMARY = "PHY interface tool for Linux" +LICENSE = "GPLv2" +LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f" + +PV = "1.0.1" +SRCREV = "1a3ea62a218206e9faf3b27fb5d01c85692024c8" +SRC_URI = "git://github.com/wkz/phytool.git" + +S = "${WORKDIR}/git" + +do_install() { + install -d ${D}${prefix}/bin + oe_runmake 'DESTDIR=${D}' 'PREFIX=${prefix}' install +} -- 1.9.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [meta-networking][PATCH] phytool: Add recipe 2016-09-23 12:33 [meta-networking][PATCH] phytool: Add recipe Mike Looijmans @ 2016-09-23 18:33 ` Khem Raj 2016-09-24 15:01 ` Mike Looijmans 2016-09-28 7:53 ` [PATCH " Mike Looijmans 1 sibling, 1 reply; 12+ messages in thread From: Khem Raj @ 2016-09-23 18:33 UTC (permalink / raw) To: openembeded-devel On Fri, Sep 23, 2016 at 5:33 AM, Mike Looijmans <mike.looijmans@topic.nl> wrote: > A nice tool to directly read, write and interpret ethernet PHY data. > Very useful when debugging PHY or MDIO problems, which ethtool does > not do. > > Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> > --- > meta-networking/recipes-support/phytool/phytool.bb | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > create mode 100644 meta-networking/recipes-support/phytool/phytool.bb > > diff --git a/meta-networking/recipes-support/phytool/phytool.bb b/meta-networking/recipes-support/phytool/phytool.bb > new file mode 100644 > index 0000000..9d541b7 > --- /dev/null > +++ b/meta-networking/recipes-support/phytool/phytool.bb > @@ -0,0 +1,14 @@ > +SUMMARY = "PHY interface tool for Linux" > +LICENSE = "GPLv2" > +LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f" > + > +PV = "1.0.1" > +SRCREV = "1a3ea62a218206e9faf3b27fb5d01c85692024c8" > +SRC_URI = "git://github.com/wkz/phytool.git" > + > +S = "${WORKDIR}/git" > + > +do_install() { > + install -d ${D}${prefix}/bin perhaps use base_bindir here > + oe_runmake 'DESTDIR=${D}' 'PREFIX=${prefix}' install > +} > -- > 1.9.1 > > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [meta-networking][PATCH] phytool: Add recipe 2016-09-23 18:33 ` Khem Raj @ 2016-09-24 15:01 ` Mike Looijmans 2016-09-26 7:31 ` Khem Raj 0 siblings, 1 reply; 12+ messages in thread From: Mike Looijmans @ 2016-09-24 15:01 UTC (permalink / raw) To: openembedded-devel On 23-09-16 20:33, Khem Raj wrote: > On Fri, Sep 23, 2016 at 5:33 AM, Mike Looijmans <mike.looijmans@topic.nl> wrote: >> A nice tool to directly read, write and interpret ethernet PHY data. >> Very useful when debugging PHY or MDIO problems, which ethtool does >> not do. >> >> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> >> --- >> meta-networking/recipes-support/phytool/phytool.bb | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >> create mode 100644 meta-networking/recipes-support/phytool/phytool.bb >> >> diff --git a/meta-networking/recipes-support/phytool/phytool.bb b/meta-networking/recipes-support/phytool/phytool.bb >> new file mode 100644 >> index 0000000..9d541b7 >> --- /dev/null >> +++ b/meta-networking/recipes-support/phytool/phytool.bb >> @@ -0,0 +1,14 @@ >> +SUMMARY = "PHY interface tool for Linux" >> +LICENSE = "GPLv2" >> +LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f" >> + >> +PV = "1.0.1" >> +SRCREV = "1a3ea62a218206e9faf3b27fb5d01c85692024c8" >> +SRC_URI = "git://github.com/wkz/phytool.git" >> + >> +S = "${WORKDIR}/git" >> + >> +do_install() { >> + install -d ${D}${prefix}/bin > > perhaps use base_bindir here The makefile installs to $PREFIX/bin so I deliberately put the same folder in the recipe (the makefile doesn't create the directory). If anyone changes $bindir the install will fail. > >> + oe_runmake 'DESTDIR=${D}' 'PREFIX=${prefix}' install >> +} >> -- >> 1.9.1 >> >> -- >> _______________________________________________ >> Openembedded-devel mailing list >> Openembedded-devel@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel -- Mike Looijmans ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [meta-networking][PATCH] phytool: Add recipe 2016-09-24 15:01 ` Mike Looijmans @ 2016-09-26 7:31 ` Khem Raj 2016-09-26 20:34 ` Martin Jansa 0 siblings, 1 reply; 12+ messages in thread From: Khem Raj @ 2016-09-26 7:31 UTC (permalink / raw) To: openembeded-devel On Sat, Sep 24, 2016 at 8:01 AM, Mike Looijmans <mike.looijmans@topic.nl> wrote: > On 23-09-16 20:33, Khem Raj wrote: >> >> On Fri, Sep 23, 2016 at 5:33 AM, Mike Looijmans <mike.looijmans@topic.nl> >> wrote: >>> >>> A nice tool to directly read, write and interpret ethernet PHY data. >>> Very useful when debugging PHY or MDIO problems, which ethtool does >>> not do. >>> >>> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> >>> --- >>> meta-networking/recipes-support/phytool/phytool.bb | 14 ++++++++++++++ >>> 1 file changed, 14 insertions(+) >>> create mode 100644 meta-networking/recipes-support/phytool/phytool.bb >>> >>> diff --git a/meta-networking/recipes-support/phytool/phytool.bb >>> b/meta-networking/recipes-support/phytool/phytool.bb >>> new file mode 100644 >>> index 0000000..9d541b7 >>> --- /dev/null >>> +++ b/meta-networking/recipes-support/phytool/phytool.bb >>> @@ -0,0 +1,14 @@ >>> +SUMMARY = "PHY interface tool for Linux" >>> +LICENSE = "GPLv2" >>> +LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f" >>> + >>> +PV = "1.0.1" >>> +SRCREV = "1a3ea62a218206e9faf3b27fb5d01c85692024c8" >>> +SRC_URI = "git://github.com/wkz/phytool.git" >>> + >>> +S = "${WORKDIR}/git" >>> + >>> +do_install() { >>> + install -d ${D}${prefix}/bin >> >> >> perhaps use base_bindir here > > > The makefile installs to $PREFIX/bin so I deliberately put the same folder > in the recipe (the makefile doesn't create the directory). If anyone changes > $bindir the install will fail. I see the logic, if you dont want to use bitbake variables then perhaps its good to add a comment to explain why it was not done > >> >>> + oe_runmake 'DESTDIR=${D}' 'PREFIX=${prefix}' install >>> +} >>> -- >>> 1.9.1 >>> >>> -- >>> _______________________________________________ >>> Openembedded-devel mailing list >>> Openembedded-devel@lists.openembedded.org >>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel > > > > -- > Mike Looijmans > > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [meta-networking][PATCH] phytool: Add recipe 2016-09-26 7:31 ` Khem Raj @ 2016-09-26 20:34 ` Martin Jansa 2016-09-28 7:30 ` Mike Looijmans 2016-10-05 9:34 ` [meta-networking][PATCH v2] " Mike Looijmans 0 siblings, 2 replies; 12+ messages in thread From: Martin Jansa @ 2016-09-26 20:34 UTC (permalink / raw) To: openembedded-devel 2 more issues: WARNING: phytool-1.0.1-r0 do_populate_lic: Could not copy license file phytool/1.0.1-r0/git/COPYING to phytool/1.0.1-r0/license-destdir/phytool/COPYING: [Errno 2] No such file or directory: 'phytool/1.0.1-r0/git/COPYING' ERROR: phytool-1.0.1-r0 do_populate_lic: QA Issue: phytool: LIC_FILES_CHKSUM points to an invalid file: phytool/1.0.1-r0/git/COPYING [license-checksum] NOTE: recipe phytool-1.0.1-r0: task do_populate_lic: Succeeded ... NOTE: recipe phytool-1.0.1-r0: task do_package_qa: Started ERROR: phytool-1.0.1-r0 do_package_qa: QA Issue: No GNU_HASH in the elf binary: 'phytool/1.0.1-r0/packages-split/phytool/usr/bin/phytool' [ldflags] ERROR: phytool-1.0.1-r0 do_package_qa: QA Issue: No GNU_HASH in the elf binary: 'phytool/1.0.1-r0/packages-split/phytool/usr/bin/phytool' [ldflags] ERROR: phytool-1.0.1-r0 do_package_qa: QA run found fatal errors. Please consider fixing them. ERROR: phytool-1.0.1-r0 do_package_qa: Function failed: do_package_qa On Mon, Sep 26, 2016 at 9:31 AM, Khem Raj <raj.khem@gmail.com> wrote: > On Sat, Sep 24, 2016 at 8:01 AM, Mike Looijmans <mike.looijmans@topic.nl> > wrote: > > On 23-09-16 20:33, Khem Raj wrote: > >> > >> On Fri, Sep 23, 2016 at 5:33 AM, Mike Looijmans < > mike.looijmans@topic.nl> > >> wrote: > >>> > >>> A nice tool to directly read, write and interpret ethernet PHY data. > >>> Very useful when debugging PHY or MDIO problems, which ethtool does > >>> not do. > >>> > >>> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> > >>> --- > >>> meta-networking/recipes-support/phytool/phytool.bb | 14 > ++++++++++++++ > >>> 1 file changed, 14 insertions(+) > >>> create mode 100644 meta-networking/recipes-support/phytool/ > phytool.bb > >>> > >>> diff --git a/meta-networking/recipes-support/phytool/phytool.bb > >>> b/meta-networking/recipes-support/phytool/phytool.bb > >>> new file mode 100644 > >>> index 0000000..9d541b7 > >>> --- /dev/null > >>> +++ b/meta-networking/recipes-support/phytool/phytool.bb > >>> @@ -0,0 +1,14 @@ > >>> +SUMMARY = "PHY interface tool for Linux" > >>> +LICENSE = "GPLv2" > >>> +LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae1 > 9f" > >>> + > >>> +PV = "1.0.1" > >>> +SRCREV = "1a3ea62a218206e9faf3b27fb5d01c85692024c8" > >>> +SRC_URI = "git://github.com/wkz/phytool.git" > >>> + > >>> +S = "${WORKDIR}/git" > >>> + > >>> +do_install() { > >>> + install -d ${D}${prefix}/bin > >> > >> > >> perhaps use base_bindir here > > > > > > The makefile installs to $PREFIX/bin so I deliberately put the same > folder > > in the recipe (the makefile doesn't create the directory). If anyone > changes > > $bindir the install will fail. > > I see the logic, if you dont want to use bitbake variables then perhaps > its > good to add a comment to explain why it was not done > > > > >> > >>> + oe_runmake 'DESTDIR=${D}' 'PREFIX=${prefix}' install > >>> +} > >>> -- > >>> 1.9.1 > >>> > >>> -- > >>> _______________________________________________ > >>> Openembedded-devel mailing list > >>> Openembedded-devel@lists.openembedded.org > >>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel > > > > > > > > -- > > Mike Looijmans > > > > -- > > _______________________________________________ > > Openembedded-devel mailing list > > Openembedded-devel@lists.openembedded.org > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [meta-networking][PATCH] phytool: Add recipe 2016-09-26 20:34 ` Martin Jansa @ 2016-09-28 7:30 ` Mike Looijmans 2016-09-28 7:55 ` Mike Looijmans 2016-10-05 9:34 ` [meta-networking][PATCH v2] " Mike Looijmans 1 sibling, 1 reply; 12+ messages in thread From: Mike Looijmans @ 2016-09-28 7:30 UTC (permalink / raw) To: openembedded-devel On 26-09-16 22:34, Martin Jansa wrote: > 2 more issues: > > WARNING: phytool-1.0.1-r0 do_populate_lic: Could not copy license file > phytool/1.0.1-r0/git/COPYING to > phytool/1.0.1-r0/license-destdir/phytool/COPYING: [Errno 2] No such > file or directory: 'phytool/1.0.1-r0/git/COPYING' > ERROR: phytool-1.0.1-r0 do_populate_lic: QA Issue: phytool: > LIC_FILES_CHKSUM points to an invalid file: > phytool/1.0.1-r0/git/COPYING [license-checksum] > NOTE: recipe phytool-1.0.1-r0: task do_populate_lic: Succeeded > ... Weird, it didn't barf on that on my system until I cleaned it and started over. Ah well, I;ll send a v2 which fixes it. > NOTE: recipe phytool-1.0.1-r0: task do_package_qa: Started > ERROR: phytool-1.0.1-r0 do_package_qa: QA Issue: No GNU_HASH in the > elf binary: 'phytool/1.0.1-r0/packages-split/phytool/usr/bin/phytool' > [ldflags] > ERROR: phytool-1.0.1-r0 do_package_qa: QA Issue: No GNU_HASH in the > elf binary: 'phytool/1.0.1-r0/packages-split/phytool/usr/bin/phytool' > [ldflags] > ERROR: phytool-1.0.1-r0 do_package_qa: QA run found fatal errors. > Please consider fixing them. > ERROR: phytool-1.0.1-r0 do_package_qa: Function failed: do_package_qa I have no clue what that means. I also have no clue what I'm supposed to do about it. And on my build it was only a warning. > > > On Mon, Sep 26, 2016 at 9:31 AM, Khem Raj <raj.khem@gmail.com> wrote: > >> On Sat, Sep 24, 2016 at 8:01 AM, Mike Looijmans <mike.looijmans@topic.nl> >> wrote: >>> On 23-09-16 20:33, Khem Raj wrote: >>>> >>>> On Fri, Sep 23, 2016 at 5:33 AM, Mike Looijmans < >> mike.looijmans@topic.nl> >>>> wrote: >>>>> >>>>> A nice tool to directly read, write and interpret ethernet PHY data. >>>>> Very useful when debugging PHY or MDIO problems, which ethtool does >>>>> not do. >>>>> >>>>> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> >>>>> --- >>>>> meta-networking/recipes-support/phytool/phytool.bb | 14 >> ++++++++++++++ >>>>> 1 file changed, 14 insertions(+) >>>>> create mode 100644 meta-networking/recipes-support/phytool/ >> phytool.bb >>>>> >>>>> diff --git a/meta-networking/recipes-support/phytool/phytool.bb >>>>> b/meta-networking/recipes-support/phytool/phytool.bb >>>>> new file mode 100644 >>>>> index 0000000..9d541b7 >>>>> --- /dev/null >>>>> +++ b/meta-networking/recipes-support/phytool/phytool.bb >>>>> @@ -0,0 +1,14 @@ >>>>> +SUMMARY = "PHY interface tool for Linux" >>>>> +LICENSE = "GPLv2" >>>>> +LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae1 >> 9f" >>>>> + >>>>> +PV = "1.0.1" >>>>> +SRCREV = "1a3ea62a218206e9faf3b27fb5d01c85692024c8" >>>>> +SRC_URI = "git://github.com/wkz/phytool.git" >>>>> + >>>>> +S = "${WORKDIR}/git" >>>>> + >>>>> +do_install() { >>>>> + install -d ${D}${prefix}/bin >>>> >>>> >>>> perhaps use base_bindir here >>> >>> >>> The makefile installs to $PREFIX/bin so I deliberately put the same >> folder >>> in the recipe (the makefile doesn't create the directory). If anyone >> changes >>> $bindir the install will fail. >> >> I see the logic, if you dont want to use bitbake variables then perhaps >> its >> good to add a comment to explain why it was not done >> >>> >>>> >>>>> + oe_runmake 'DESTDIR=${D}' 'PREFIX=${prefix}' install >>>>> +} >>>>> -- >>>>> 1.9.1 >>>>> >>>>> -- >>>>> Kind regards, Mike Looijmans System Expert TOPIC Products Materiaalweg 4, NL-5681 RJ Best Postbus 440, NL-5680 AK Best Telefoon: +31 (0) 499 33 69 79 E-mail: mike.looijmans@topicproducts.com Website: www.topicproducts.com Please consider the environment before printing this e-mail _______________________________________________ >>>>> Openembedded-devel mailing list >>>>> Openembedded-devel@lists.openembedded.org >>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel >>> >>> >>> >>> -- >>> Mike Looijmans >>> >>> -- >>> _______________________________________________ >>> Openembedded-devel mailing list >>> Openembedded-devel@lists.openembedded.org >>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel >> -- >> _______________________________________________ >> Openembedded-devel mailing list >> Openembedded-devel@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel >> ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [meta-networking][PATCH] phytool: Add recipe 2016-09-28 7:30 ` Mike Looijmans @ 2016-09-28 7:55 ` Mike Looijmans 0 siblings, 0 replies; 12+ messages in thread From: Mike Looijmans @ 2016-09-28 7:55 UTC (permalink / raw) To: openembedded-devel On 28-09-16 09:30, Mike Looijmans wrote: > On 26-09-16 22:34, Martin Jansa wrote: >> 2 more issues: >> >> WARNING: phytool-1.0.1-r0 do_populate_lic: Could not copy license file >> phytool/1.0.1-r0/git/COPYING to >> phytool/1.0.1-r0/license-destdir/phytool/COPYING: [Errno 2] No such >> file or directory: 'phytool/1.0.1-r0/git/COPYING' >> ERROR: phytool-1.0.1-r0 do_populate_lic: QA Issue: phytool: >> LIC_FILES_CHKSUM points to an invalid file: >> phytool/1.0.1-r0/git/COPYING [license-checksum] >> NOTE: recipe phytool-1.0.1-r0: task do_populate_lic: Succeeded >> ... > > Weird, it didn't barf on that on my system until I cleaned it and started > over. Ah well, I;ll send a v2 which fixes it. > >> NOTE: recipe phytool-1.0.1-r0: task do_package_qa: Started >> ERROR: phytool-1.0.1-r0 do_package_qa: QA Issue: No GNU_HASH in the >> elf binary: 'phytool/1.0.1-r0/packages-split/phytool/usr/bin/phytool' >> [ldflags] >> ERROR: phytool-1.0.1-r0 do_package_qa: QA Issue: No GNU_HASH in the >> elf binary: 'phytool/1.0.1-r0/packages-split/phytool/usr/bin/phytool' >> [ldflags] >> ERROR: phytool-1.0.1-r0 do_package_qa: QA run found fatal errors. >> Please consider fixing them. >> ERROR: phytool-1.0.1-r0 do_package_qa: Function failed: do_package_qa > > I have no clue what that means. I also have no clue what I'm supposed to do > about it. And on my build it was only a warning. A bit of experimentation revealed that apparently this is OE complaining that $LDFLAGS didn't get passed to the linker. Created a patch to solve that and upstream it. It would be helpful if the message wasn't so cryptic. Kind regards, Mike Looijmans System Expert TOPIC Products Materiaalweg 4, NL-5681 RJ Best Postbus 440, NL-5680 AK Best Telefoon: +31 (0) 499 33 69 79 E-mail: mike.looijmans@topicproducts.com Website: www.topicproducts.com Please consider the environment before printing this e-mail ^ permalink raw reply [flat|nested] 12+ messages in thread
* [meta-networking][PATCH v2] phytool: Add recipe 2016-09-26 20:34 ` Martin Jansa 2016-09-28 7:30 ` Mike Looijmans @ 2016-10-05 9:34 ` Mike Looijmans 2016-10-05 15:38 ` Khem Raj 1 sibling, 1 reply; 12+ messages in thread From: Mike Looijmans @ 2016-10-05 9:34 UTC (permalink / raw) To: openembedded-devel A nice tool to directly read, write and interpret ethernet PHY data. Very useful when debugging PHY or MDIO problems, which ethtool does not do. Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> --- v2: Fix LICENSE filename and checksum Honor LDFLAGS value (patch accepted upstream) meta-networking/recipes-support/phytool/phytool.bb | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 meta-networking/recipes-support/phytool/phytool.bb diff --git a/meta-networking/recipes-support/phytool/phytool.bb b/meta-networking/recipes-support/phytool/phytool.bb new file mode 100644 index 0000000..d451aa9 --- /dev/null +++ b/meta-networking/recipes-support/phytool/phytool.bb @@ -0,0 +1,14 @@ +SUMMARY = "PHY interface tool for Linux" +LICENSE = "GPLv2" +LIC_FILES_CHKSUM = "file://LICENSE;md5=39bba7d2cf0ba1036f2a6e2be52fe3f0" + +PV = "1.0.1" +SRCREV = "3149bfdb4f513e2f0da0a7d0bc5d0873578696f2" +SRC_URI = "git://github.com/wkz/phytool.git" + +S = "${WORKDIR}/git" + +do_install() { + install -d ${D}${prefix}/bin + oe_runmake 'DESTDIR=${D}' 'PREFIX=${prefix}' install +} -- 1.9.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [meta-networking][PATCH v2] phytool: Add recipe 2016-10-05 9:34 ` [meta-networking][PATCH v2] " Mike Looijmans @ 2016-10-05 15:38 ` Khem Raj 2016-10-05 16:32 ` Martin Jansa 0 siblings, 1 reply; 12+ messages in thread From: Khem Raj @ 2016-10-05 15:38 UTC (permalink / raw) To: openembeded-devel On Wed, Oct 5, 2016 at 2:34 AM, Mike Looijmans <mike.looijmans@topic.nl> wrote: > A nice tool to directly read, write and interpret ethernet PHY data. > Very useful when debugging PHY or MDIO problems, which ethtool does > not do. > > Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> > --- > v2: Fix LICENSE filename and checksum > Honor LDFLAGS value (patch accepted upstream) > > meta-networking/recipes-support/phytool/phytool.bb | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > create mode 100644 meta-networking/recipes-support/phytool/phytool.bb > > diff --git a/meta-networking/recipes-support/phytool/phytool.bb b/meta-networking/recipes-support/phytool/phytool.bb > new file mode 100644 > index 0000000..d451aa9 > --- /dev/null > +++ b/meta-networking/recipes-support/phytool/phytool.bb > @@ -0,0 +1,14 @@ > +SUMMARY = "PHY interface tool for Linux" > +LICENSE = "GPLv2" > +LIC_FILES_CHKSUM = "file://LICENSE;md5=39bba7d2cf0ba1036f2a6e2be52fe3f0" > + > +PV = "1.0.1" perhaps its better to include SRCPV in PV above since the SRCREV below is really 1.0.1+some more commits. moreover we get srcrev accounted for task hashes > +SRCREV = "3149bfdb4f513e2f0da0a7d0bc5d0873578696f2" > +SRC_URI = "git://github.com/wkz/phytool.git" > + > +S = "${WORKDIR}/git" > + > +do_install() { > + install -d ${D}${prefix}/bin > + oe_runmake 'DESTDIR=${D}' 'PREFIX=${prefix}' install > +} > -- > 1.9.1 > > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [meta-networking][PATCH v2] phytool: Add recipe 2016-10-05 15:38 ` Khem Raj @ 2016-10-05 16:32 ` Martin Jansa 2016-10-06 5:54 ` Mike Looijmans 0 siblings, 1 reply; 12+ messages in thread From: Martin Jansa @ 2016-10-05 16:32 UTC (permalink / raw) To: openembedded-devel [-- Attachment #1: Type: text/plain, Size: 2193 bytes --] On Wed, Oct 05, 2016 at 08:38:07AM -0700, Khem Raj wrote: > On Wed, Oct 5, 2016 at 2:34 AM, Mike Looijmans <mike.looijmans@topic.nl> wrote: > > A nice tool to directly read, write and interpret ethernet PHY data. > > Very useful when debugging PHY or MDIO problems, which ethtool does > > not do. > > > > Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> > > --- > > v2: Fix LICENSE filename and checksum > > Honor LDFLAGS value (patch accepted upstream) > > > > meta-networking/recipes-support/phytool/phytool.bb | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > create mode 100644 meta-networking/recipes-support/phytool/phytool.bb > > > > diff --git a/meta-networking/recipes-support/phytool/phytool.bb b/meta-networking/recipes-support/phytool/phytool.bb > > new file mode 100644 > > index 0000000..d451aa9 > > --- /dev/null > > +++ b/meta-networking/recipes-support/phytool/phytool.bb > > @@ -0,0 +1,14 @@ > > +SUMMARY = "PHY interface tool for Linux" > > +LICENSE = "GPLv2" > > +LIC_FILES_CHKSUM = "file://LICENSE;md5=39bba7d2cf0ba1036f2a6e2be52fe3f0" > > + > > +PV = "1.0.1" > > perhaps its better to include SRCPV in PV above since the SRCREV > below is really 1.0.1+some more commits. moreover we get srcrev > accounted for task hashes > > > +SRCREV = "3149bfdb4f513e2f0da0a7d0bc5d0873578696f2" > > +SRC_URI = "git://github.com/wkz/phytool.git" > > + > > +S = "${WORKDIR}/git" > > + > > +do_install() { > > + install -d ${D}${prefix}/bin > > + oe_runmake 'DESTDIR=${D}' 'PREFIX=${prefix}' install We're not using tabs for indentation. see http://www.openembedded.org/wiki/Styleguide > > +} > > -- > > 1.9.1 > > > > -- > > _______________________________________________ > > Openembedded-devel mailing list > > Openembedded-devel@lists.openembedded.org > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel -- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 169 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [meta-networking][PATCH v2] phytool: Add recipe 2016-10-05 16:32 ` Martin Jansa @ 2016-10-06 5:54 ` Mike Looijmans 0 siblings, 0 replies; 12+ messages in thread From: Mike Looijmans @ 2016-10-06 5:54 UTC (permalink / raw) To: openembedded-devel On 05-10-16 18:32, Martin Jansa wrote: > On Wed, Oct 05, 2016 at 08:38:07AM -0700, Khem Raj wrote: >> On Wed, Oct 5, 2016 at 2:34 AM, Mike Looijmans <mike.looijmans@topic.nl> wrote: >>> A nice tool to directly read, write and interpret ethernet PHY data. >>> Very useful when debugging PHY or MDIO problems, which ethtool does >>> not do. >>> >>> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> >>> --- >>> v2: Fix LICENSE filename and checksum >>> Honor LDFLAGS value (patch accepted upstream) >>> >>> meta-networking/recipes-support/phytool/phytool.bb | 14 ++++++++++++++ >>> 1 file changed, 14 insertions(+) >>> create mode 100644 meta-networking/recipes-support/phytool/phytool.bb >>> >>> diff --git a/meta-networking/recipes-support/phytool/phytool.bb b/meta-networking/recipes-support/phytool/phytool.bb >>> new file mode 100644 >>> index 0000000..d451aa9 >>> --- /dev/null >>> +++ b/meta-networking/recipes-support/phytool/phytool.bb >>> @@ -0,0 +1,14 @@ >>> +SUMMARY = "PHY interface tool for Linux" >>> +LICENSE = "GPLv2" >>> +LIC_FILES_CHKSUM = "file://LICENSE;md5=39bba7d2cf0ba1036f2a6e2be52fe3f0" >>> + >>> +PV = "1.0.1" >> >> perhaps its better to include SRCPV in PV above since the SRCREV >> below is really 1.0.1+some more commits. moreover we get srcrev >> accounted for task hashes Will do. >> >>> +SRCREV = "3149bfdb4f513e2f0da0a7d0bc5d0873578696f2" >>> +SRC_URI = "git://github.com/wkz/phytool.git" >>> + >>> +S = "${WORKDIR}/git" >>> + >>> +do_install() { >>> + install -d ${D}${prefix}/bin >>> + oe_runmake 'DESTDIR=${D}' 'PREFIX=${prefix}' install > > We're not using tabs for indentation. > see http://www.openembedded.org/wiki/Styleguide Will fix in v3. I also want to move it to another location in meta-oe, because meta-networking depends on meta-python and it's really weird to have to add meta-python to your layers just to get a simple C binary tool. Mike. Kind regards, Mike Looijmans System Expert TOPIC Products Materiaalweg 4, NL-5681 RJ Best Postbus 440, NL-5680 AK Best Telefoon: +31 (0) 499 33 69 79 E-mail: mike.looijmans@topicproducts.com Website: www.topicproducts.com Please consider the environment before printing this e-mail ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v2] phytool: Add recipe 2016-09-23 12:33 [meta-networking][PATCH] phytool: Add recipe Mike Looijmans 2016-09-23 18:33 ` Khem Raj @ 2016-09-28 7:53 ` Mike Looijmans 1 sibling, 0 replies; 12+ messages in thread From: Mike Looijmans @ 2016-09-28 7:53 UTC (permalink / raw) To: openembedded-devel A nice tool to directly read, write and interpret ethernet PHY data. Very useful when debugging PHY or MDIO problems, which ethtool does not do. Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> --- v2: Add $bindir comment Add patch (pending upstream) to fix LDFLAGS warning Fix license filename meta-networking/recipes-support/phytool/phytool.bb | 17 ++++++++++++ .../0001-Makefile-Honor-LDFLAGS-variable.patch | 31 ++++++++++++++++++++++ 2 files changed, 48 insertions(+) create mode 100644 meta-networking/recipes-support/phytool/phytool.bb create mode 100644 meta-networking/recipes-support/phytool/phytool/0001-Makefile-Honor-LDFLAGS-variable.patch diff --git a/meta-networking/recipes-support/phytool/phytool.bb b/meta-networking/recipes-support/phytool/phytool.bb new file mode 100644 index 0000000..e95b035 --- /dev/null +++ b/meta-networking/recipes-support/phytool/phytool.bb @@ -0,0 +1,17 @@ +SUMMARY = "PHY interface tool for Linux" +LICENSE = "GPLv2" +LIC_FILES_CHKSUM = "file://LICENSE;md5=39bba7d2cf0ba1036f2a6e2be52fe3f0" + +PV = "1.0.1" +SRCREV = "1a3ea62a218206e9faf3b27fb5d01c85692024c8" +SRC_URI = "git://github.com/wkz/phytool.git \ + file://0001-Makefile-Honor-LDFLAGS-variable.patch" + +S = "${WORKDIR}/git" + +# Intentionally not using $bindir here because the Makefile is hard-coded to +# install into $PREFIX/bin +do_install() { + install -d ${D}${prefix}/bin + oe_runmake 'DESTDIR=${D}' 'PREFIX=${prefix}' install +} diff --git a/meta-networking/recipes-support/phytool/phytool/0001-Makefile-Honor-LDFLAGS-variable.patch b/meta-networking/recipes-support/phytool/phytool/0001-Makefile-Honor-LDFLAGS-variable.patch new file mode 100644 index 0000000..8b99d09 --- /dev/null +++ b/meta-networking/recipes-support/phytool/phytool/0001-Makefile-Honor-LDFLAGS-variable.patch @@ -0,0 +1,31 @@ +From 8b75a5e6238fe30661b672743560fe4d357237fd Mon Sep 17 00:00:00 2001 +From: Mike Looijmans <mike.looijmans@topic.nl> +Date: Wed, 28 Sep 2016 09:42:45 +0200 +Subject: [PATCH] Makefile: Honor LDFLAGS variable + +Passing $(LDFLAGS) to the linker is important for cross-compile environments. +OpenEmbedded builds will display QA errors like this: +... QA Issue: No GNU_HASH in the elf binary ... [ldflags] + +Upstream-Status: Pending +Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> +--- + Makefile | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/Makefile b/Makefile +index b52843b..70bb414 100644 +--- a/Makefile ++++ b/Makefile +@@ -22,7 +22,7 @@ hdrs = $(wildcard *.h) + + phytool: $(objs) + @printf " CC $(subst $(ROOTDIR)/,,$(shell pwd)/$@)\n" +- @$(CC) $(LDLIBS) -o $@ $^ ++ @$(CC) $(LDFLAGS) $(LDLIBS) -o $@ $^ + + all: phytool + +-- +1.9.1 + -- 1.9.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
end of thread, other threads:[~2016-10-06 5:54 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-09-23 12:33 [meta-networking][PATCH] phytool: Add recipe Mike Looijmans 2016-09-23 18:33 ` Khem Raj 2016-09-24 15:01 ` Mike Looijmans 2016-09-26 7:31 ` Khem Raj 2016-09-26 20:34 ` Martin Jansa 2016-09-28 7:30 ` Mike Looijmans 2016-09-28 7:55 ` Mike Looijmans 2016-10-05 9:34 ` [meta-networking][PATCH v2] " Mike Looijmans 2016-10-05 15:38 ` Khem Raj 2016-10-05 16:32 ` Martin Jansa 2016-10-06 5:54 ` Mike Looijmans 2016-09-28 7:53 ` [PATCH " Mike Looijmans
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.