Re: [Qemu-devel] [PATCH v3 3/8] pci: Convert msix_init() to Error and fix callers to check it

[Cao jin <caoj.fnst@cn.fujitsu.com>]

On 09/29/2016 10:17 PM, Markus Armbruster wrote:
> Cao jin <caoj.fnst@cn.fujitsu.com> writes:
>

>>
>> -/* Initialize the MSI-X structures */
>> +/* Make PCI device @dev MSI-X capable
>> + * @nentries is the max number of MSI-X vectors that the device support.
>> + * @table_bar is the MemoryRegion that MSI-X table structure resides.
>> + * @table_bar_nr is number of base address register corresponding to @table_bar.
>> + * @table_offset indicates the offset that the MSI-X table structure starts with
>> + * in @table_bar.
>> + * @pba_bar is the MemoryRegion that the Pending Bit Array structure resides.
>> + * @pba_bar_nr is number of base address register corresponding to @pba_bar.
>> + * @pba_offset indicates the offset that the Pending Bit Array structure
>> + * starts with in @pba_bar.
>> + * Non-zero @cap_pos puts capability MSI-X at that offset in PCI config space.
>> + *
>> + * Return 0 on success; return -errno on error:
>
> Previous version had:
>
>    + * @errp is for returning errors.
>    + *
>    + * Return 0 on success; set @errp and return -errno on error.
>
> Intentional change?  I like the old one better.
>

Oh...it was lost by me. I was planning move these comments into a 
separate patch, but later feel that it is not worth the trouble, so I 
undo the movement, it is lost during the process.

>
> Might conflict with Eric Auger's "Convert VFIO-PCI to realize" series,
> but resolving that shouldn't be hard.
>
> [...]
>
> The conversion looks good to me now.
>
>
> .
>

-- 
Yours Sincerely,

Cao jin