All of lore.kernel.org
 help / color / mirror / Atom feed
* [Cocci] [PATCH] Coccinelle: limit memdup_user transformation to GFP_KERNEL case
@ 2016-09-21 15:48 ` Julia Lawall
  0 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2016-09-21 15:48 UTC (permalink / raw)
  To: cocci

Memdup_user encapsulates a memory allocation with the flag GFP_KERNEL, so
only allow this flag in the original code.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 scripts/coccinelle/api/memdup_user.cocci |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/scripts/coccinelle/api/memdup_user.cocci b/scripts/coccinelle/api/memdup_user.cocci
index c606231..2a5aea8 100644
--- a/scripts/coccinelle/api/memdup_user.cocci
+++ b/scripts/coccinelle/api/memdup_user.cocci
@@ -15,11 +15,11 @@ virtual org
 virtual report
 
 @depends on patch@
-expression from,to,size,flag;
+expression from,to,size;
 identifier l1,l2;
 @@
 
--  to = \(kmalloc\|kzalloc\)(size,flag);
+-  to = \(kmalloc\|kzalloc\)(size,GFP_KERNEL);
 +  to = memdup_user(from,size);
    if (
 -      to==NULL
@@ -37,12 +37,12 @@ identifier l1,l2;
 -  }
 
 @r depends on !patch@
-expression from,to,size,flag;
+expression from,to,size;
 position p;
 statement S1,S2;
 @@
 
-*  to = \(kmalloc at p\|kzalloc at p\)(size,flag);
+*  to = \(kmalloc at p\|kzalloc at p\)(size,GFP_KERNEL);
    if (to==NULL || ...) S1
    if (copy_from_user(to, from, size) != 0)
    S2

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] Coccinelle: limit memdup_user transformation to GFP_KERNEL case
@ 2016-09-21 15:48 ` Julia Lawall
  0 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2016-09-21 15:48 UTC (permalink / raw)
  To: cocci

Memdup_user encapsulates a memory allocation with the flag GFP_KERNEL, so
only allow this flag in the original code.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 scripts/coccinelle/api/memdup_user.cocci |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/scripts/coccinelle/api/memdup_user.cocci b/scripts/coccinelle/api/memdup_user.cocci
index c606231..2a5aea8 100644
--- a/scripts/coccinelle/api/memdup_user.cocci
+++ b/scripts/coccinelle/api/memdup_user.cocci
@@ -15,11 +15,11 @@ virtual org
 virtual report
 
 @depends on patch@
-expression from,to,size,flag;
+expression from,to,size;
 identifier l1,l2;
 @@
 
--  to = \(kmalloc\|kzalloc\)(size,flag);
+-  to = \(kmalloc\|kzalloc\)(size,GFP_KERNEL);
 +  to = memdup_user(from,size);
    if (
 -      to=NULL
@@ -37,12 +37,12 @@ identifier l1,l2;
 -  }
 
 @r depends on !patch@
-expression from,to,size,flag;
+expression from,to,size;
 position p;
 statement S1,S2;
 @@
 
-*  to = \(kmalloc@p\|kzalloc@p\)(size,flag);
+*  to = \(kmalloc@p\|kzalloc@p\)(size,GFP_KERNEL);
    if (to=NULL || ...) S1
    if (copy_from_user(to, from, size) != 0)
    S2


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] Coccinelle: limit memdup_user transformation to GFP_KERNEL case
@ 2016-09-21 15:48 ` Julia Lawall
  0 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2016-09-21 15:48 UTC (permalink / raw)
  To: Michal Marek
  Cc: kernel-janitors, Gilles Muller, Nicolas Palix, cocci,
	linux-kernel

Memdup_user encapsulates a memory allocation with the flag GFP_KERNEL, so
only allow this flag in the original code.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 scripts/coccinelle/api/memdup_user.cocci |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/scripts/coccinelle/api/memdup_user.cocci b/scripts/coccinelle/api/memdup_user.cocci
index c606231..2a5aea8 100644
--- a/scripts/coccinelle/api/memdup_user.cocci
+++ b/scripts/coccinelle/api/memdup_user.cocci
@@ -15,11 +15,11 @@ virtual org
 virtual report
 
 @depends on patch@
-expression from,to,size,flag;
+expression from,to,size;
 identifier l1,l2;
 @@
 
--  to = \(kmalloc\|kzalloc\)(size,flag);
+-  to = \(kmalloc\|kzalloc\)(size,GFP_KERNEL);
 +  to = memdup_user(from,size);
    if (
 -      to==NULL
@@ -37,12 +37,12 @@ identifier l1,l2;
 -  }
 
 @r depends on !patch@
-expression from,to,size,flag;
+expression from,to,size;
 position p;
 statement S1,S2;
 @@
 
-*  to = \(kmalloc@p\|kzalloc@p\)(size,flag);
+*  to = \(kmalloc@p\|kzalloc@p\)(size,GFP_KERNEL);
    if (to==NULL || ...) S1
    if (copy_from_user(to, from, size) != 0)
    S2

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [Cocci] [PATCH] Coccinelle: limit memdup_user transformation to GFP_KERNEL case
  2016-09-21 15:48 ` Julia Lawall
  (?)
@ 2016-10-01 21:03   ` Michal Marek
  -1 siblings, 0 replies; 6+ messages in thread
From: Michal Marek @ 2016-10-01 21:03 UTC (permalink / raw)
  To: cocci

Dne 21.9.2016 v 17:48 Julia Lawall napsal(a):
> Memdup_user encapsulates a memory allocation with the flag GFP_KERNEL, so
> only allow this flag in the original code.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Applied to kbuild.git#misc.

Thanks,
Michal

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] Coccinelle: limit memdup_user transformation to GFP_KERNEL case
@ 2016-10-01 21:03   ` Michal Marek
  0 siblings, 0 replies; 6+ messages in thread
From: Michal Marek @ 2016-10-01 21:03 UTC (permalink / raw)
  To: cocci

Dne 21.9.2016 v 17:48 Julia Lawall napsal(a):
> Memdup_user encapsulates a memory allocation with the flag GFP_KERNEL, so
> only allow this flag in the original code.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Applied to kbuild.git#misc.

Thanks,
Michal


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] Coccinelle: limit memdup_user transformation to GFP_KERNEL case
@ 2016-10-01 21:03   ` Michal Marek
  0 siblings, 0 replies; 6+ messages in thread
From: Michal Marek @ 2016-10-01 21:03 UTC (permalink / raw)
  To: Julia Lawall
  Cc: kernel-janitors, Gilles Muller, Nicolas Palix, cocci,
	linux-kernel

Dne 21.9.2016 v 17:48 Julia Lawall napsal(a):
> Memdup_user encapsulates a memory allocation with the flag GFP_KERNEL, so
> only allow this flag in the original code.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Applied to kbuild.git#misc.

Thanks,
Michal

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-10-01 21:04 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-21 15:48 [Cocci] [PATCH] Coccinelle: limit memdup_user transformation to GFP_KERNEL case Julia Lawall
2016-09-21 15:48 ` Julia Lawall
2016-09-21 15:48 ` Julia Lawall
2016-10-01 21:03 ` [Cocci] " Michal Marek
2016-10-01 21:03   ` Michal Marek
2016-10-01 21:03   ` Michal Marek

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.