* [PATCH] reiser4: return -ENOTTY from unsupported ioctls.
@ 2016-09-30 6:49 Ivan Shapovalov
2016-10-03 14:30 ` Edward Shishkin
0 siblings, 1 reply; 3+ messages in thread
From: Ivan Shapovalov @ 2016-09-30 6:49 UTC (permalink / raw)
To: reiserfs-devel; +Cc: Edward Shishkin, Ivan Shapovalov
Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
---
plugin/file/cryptcompress.c | 2 +-
plugin/file/file.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/plugin/file/cryptcompress.c b/plugin/file/cryptcompress.c
index 59d8df8..67c48d7 100644
--- a/plugin/file/cryptcompress.c
+++ b/plugin/file/cryptcompress.c
@@ -3544,7 +3544,7 @@ int writepages_cryptcompress(struct address_space *mapping,
int ioctl_cryptcompress(struct file *filp, unsigned int cmd,
unsigned long arg)
{
- return RETERR(-ENOSYS);
+ return RETERR(-ENOTTY);
}
/* plugin->mmap */
diff --git a/plugin/file/file.c b/plugin/file/file.c
index 064f26e..9d08481 100644
--- a/plugin/file/file.c
+++ b/plugin/file/file.c
@@ -2446,7 +2446,7 @@ int ioctl_unix_file(struct file *filp, unsigned int cmd,
break;
default:
- result = RETERR(-ENOSYS);
+ result = RETERR(-ENOTTY);
break;
}
reiser4_exit_context(ctx);
--
2.10.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] reiser4: return -ENOTTY from unsupported ioctls.
2016-09-30 6:49 [PATCH] reiser4: return -ENOTTY from unsupported ioctls Ivan Shapovalov
@ 2016-10-03 14:30 ` Edward Shishkin
0 siblings, 0 replies; 3+ messages in thread
From: Edward Shishkin @ 2016-10-03 14:30 UTC (permalink / raw)
To: Ivan Shapovalov, reiserfs-devel
OK
On 09/30/2016 08:49 AM, Ivan Shapovalov wrote:
> Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
> ---
> plugin/file/cryptcompress.c | 2 +-
> plugin/file/file.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/plugin/file/cryptcompress.c b/plugin/file/cryptcompress.c
> index 59d8df8..67c48d7 100644
> --- a/plugin/file/cryptcompress.c
> +++ b/plugin/file/cryptcompress.c
> @@ -3544,7 +3544,7 @@ int writepages_cryptcompress(struct address_space *mapping,
> int ioctl_cryptcompress(struct file *filp, unsigned int cmd,
> unsigned long arg)
> {
> - return RETERR(-ENOSYS);
> + return RETERR(-ENOTTY);
> }
>
> /* plugin->mmap */
> diff --git a/plugin/file/file.c b/plugin/file/file.c
> index 064f26e..9d08481 100644
> --- a/plugin/file/file.c
> +++ b/plugin/file/file.c
> @@ -2446,7 +2446,7 @@ int ioctl_unix_file(struct file *filp, unsigned int cmd,
> break;
>
> default:
> - result = RETERR(-ENOSYS);
> + result = RETERR(-ENOTTY);
> break;
> }
> reiser4_exit_context(ctx);
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] reiser4: return -ENOTTY from unsupported ioctls.
@ 2015-02-13 0:37 Ivan Shapovalov
0 siblings, 0 replies; 3+ messages in thread
From: Ivan Shapovalov @ 2015-02-13 0:37 UTC (permalink / raw)
To: reiserfs-devel; +Cc: Ivan Shapovalov
Signed-off-by: Ivan Shapovalov <intelfx100@gmail.com>
---
Looks like -ENOTTY is the right thing to return here.
(also specified at http://man7.org/linux/man-pages/man2/ioctl.2.html#ERRORS)
fs/reiser4/plugin/file/cryptcompress.c | 2 +-
fs/reiser4/plugin/file/file.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/reiser4/plugin/file/cryptcompress.c b/fs/reiser4/plugin/file/cryptcompress.c
index c3e0948..73f6974 100644
--- a/fs/reiser4/plugin/file/cryptcompress.c
+++ b/fs/reiser4/plugin/file/cryptcompress.c
@@ -3682,7 +3682,7 @@ int writepages_cryptcompress(struct address_space *mapping,
int ioctl_cryptcompress(struct file *filp, unsigned int cmd,
unsigned long arg)
{
- return RETERR(-ENOSYS);
+ return RETERR(-ENOTTY);
}
/* plugin->mmap */
diff --git a/fs/reiser4/plugin/file/file.c b/fs/reiser4/plugin/file/file.c
index c33f789..1040c994 100644
--- a/fs/reiser4/plugin/file/file.c
+++ b/fs/reiser4/plugin/file/file.c
@@ -2453,7 +2453,7 @@ int ioctl_unix_file(struct file *filp, unsigned int cmd,
break;
default:
- result = RETERR(-ENOSYS);
+ result = RETERR(-ENOTTY);
break;
}
reiser4_exit_context(ctx);
--
2.3.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-03 14:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-30 6:49 [PATCH] reiser4: return -ENOTTY from unsupported ioctls Ivan Shapovalov
2016-10-03 14:30 ` Edward Shishkin
-- strict thread matches above, loose matches on Subject: below --
2015-02-13 0:37 Ivan Shapovalov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.