All of lore.kernel.org
 help / color / mirror / Atom feed
* [Cocci] Regression in Python Support
@ 2016-10-11 11:52 Michael Stefaniuc
  2016-10-18 16:54 ` Thierry Martinez
  0 siblings, 1 reply; 4+ messages in thread
From: Michael Stefaniuc @ 2016-10-11 11:52 UTC (permalink / raw)
  To: cocci

Hello Thierry,

I've run into a regression in coccinelle 1.0.6 for the python support:
I am getting this error on Fedora 24:
Python error: /usr/lib64/python2.7/lib-dynload/_collectionsmodule.so:
undefined symbol: PyObject_SetItem

On Fedora 23 I get a similar error but for a different symbol.

The error is strange as I expected it to use python3 as I use:
./configure --with-python=/usr/bin/python3

That works just fine in coccinelle-1.0.5. I've bisected it to:
# first bad commit: [62f2df8c7d35967a1eca4dcd487d59a9918dd5aa] Fixed:
Bundles compilation and pyml update
commit 62f2df8c7d35967a1eca4dcd487d59a9918dd5aa
Author: Thierry Martinez <martinez@nsup.org>
Date:   Sun Jun 26 20:22:59 2016 +0200

    Fixed: Bundles compilation and pyml update

    - %.cmx: %.cmo dependency (with .ml files that do not have .mli,
      compiling the .ml into .cmo or into .cmx both write to the same .cmi
      file, so that cannot be done concurrently)
    - untarred pyml distribution to ease updates
    - Python exception catched in pycocci interface


thanks
bye
	michael

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Cocci] Regression in Python Support
  2016-10-11 11:52 [Cocci] Regression in Python Support Michael Stefaniuc
@ 2016-10-18 16:54 ` Thierry Martinez
  2016-10-18 19:11   ` Michael Stefaniuc
  0 siblings, 1 reply; 4+ messages in thread
From: Thierry Martinez @ 2016-10-18 16:54 UTC (permalink / raw)
  To: cocci

Hello, Michael.

This should now be fixed in trunk. Thank you for the report.

The support of --with-python had been dropped since the Python version
was determined during run-time since 1.0.5 (even if it had not been
properly documented, sorry for that). The option --with-python is now
restored in trunk to specify the name of the default Python
interpreter. The interpreter can also be changed by passing the option
--python in the command line of spatch.

Note that it is still possible that Fedora 23 and 24 are shipped with
Python versions that have not been tested yet. If such a similar error
is still raised with trunk, would you give me the output of
"python3 --version"?

Thank you again for the report.
-- 
Thierry.

Michael Stefaniuc (2016/10/11, 13:52 CEST)?:
> Hello Thierry,
>
> I've run into a regression in coccinelle 1.0.6 for the python support:
> I am getting this error on Fedora 24:
> Python error: /usr/lib64/python2.7/lib-dynload/_collectionsmodule.so:
> undefined symbol: PyObject_SetItem
>
> On Fedora 23 I get a similar error but for a different symbol.
>
> The error is strange as I expected it to use python3 as I use:
> ./configure --with-python=/usr/bin/python3
>
> That works just fine in coccinelle-1.0.5. I've bisected it to:
> # first bad commit: [62f2df8c7d35967a1eca4dcd487d59a9918dd5aa] Fixed:
> Bundles compilation and pyml update
> commit 62f2df8c7d35967a1eca4dcd487d59a9918dd5aa
> Author: Thierry Martinez <martinez@nsup.org>
> Date:   Sun Jun 26 20:22:59 2016 +0200
>
>     Fixed: Bundles compilation and pyml update
>
>     - %.cmx: %.cmo dependency (with .ml files that do not have .mli,
>       compiling the .ml into .cmo or into .cmx both write to the same .cmi
>       file, so that cannot be done concurrently)
>     - untarred pyml distribution to ease updates
>     - Python exception catched in pycocci interface
>
>
> thanks
> bye
> 	michael
> _______________________________________________
> Cocci mailing list
> Cocci at systeme.lip6.fr
> https://systeme.lip6.fr/mailman/listinfo/cocci

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Cocci] Regression in Python Support
  2016-10-18 16:54 ` Thierry Martinez
@ 2016-10-18 19:11   ` Michael Stefaniuc
  2016-10-18 20:42     ` Julia Lawall
  0 siblings, 1 reply; 4+ messages in thread
From: Michael Stefaniuc @ 2016-10-18 19:11 UTC (permalink / raw)
  To: cocci

Thanks Thierry!

On 10/18/2016 06:54 PM, Thierry Martinez wrote:
> This should now be fixed in trunk. Thank you for the report.
> 
> The support of --with-python had been dropped since the Python version
> was determined during run-time since 1.0.5 (even if it had not been
> properly documented, sorry for that). The option --with-python is now
> restored in trunk to specify the name of the default Python
> interpreter. The interpreter can also be changed by passing the option
> --python in the command line of spatch.
> 
> Note that it is still possible that Fedora 23 and 24 are shipped with
> Python versions that have not been tested yet. If such a similar error
> is still raised with trunk, would you give me the output of
> "python3 --version"?
Coccinelle works now again with python3 on both F23 and F24.

bye
	michael

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Cocci] Regression in Python Support
  2016-10-18 19:11   ` Michael Stefaniuc
@ 2016-10-18 20:42     ` Julia Lawall
  0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2016-10-18 20:42 UTC (permalink / raw)
  To: cocci



On Tue, 18 Oct 2016, Michael Stefaniuc wrote:

> Thanks Thierry!
>
> On 10/18/2016 06:54 PM, Thierry Martinez wrote:
> > This should now be fixed in trunk. Thank you for the report.
> >
> > The support of --with-python had been dropped since the Python version
> > was determined during run-time since 1.0.5 (even if it had not been
> > properly documented, sorry for that). The option --with-python is now
> > restored in trunk to specify the name of the default Python
> > interpreter. The interpreter can also be changed by passing the option
> > --python in the command line of spatch.
> >
> > Note that it is still possible that Fedora 23 and 24 are shipped with
> > Python versions that have not been tested yet. If such a similar error
> > is still raised with trunk, would you give me the output of
> > "python3 --version"?
> Coccinelle works now again with python3 on both F23 and F24.

Great :)  Thanks for checking on it.

julia

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-10-18 20:42 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-11 11:52 [Cocci] Regression in Python Support Michael Stefaniuc
2016-10-18 16:54 ` Thierry Martinez
2016-10-18 19:11   ` Michael Stefaniuc
2016-10-18 20:42     ` Julia Lawall

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.