All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: Mykyta Poturai <Mykyta_Poturai@epam.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Anthony PERARD" <anthony.perard@vates.tech>,
	"Michal Orzel" <michal.orzel@amd.com>,
	"Jan Beulich" <jbeulich@suse.com>,
	"Julien Grall" <julien@xen.org>,
	"Roger Pau Monné" <roger@xenproject.org>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Bertrand Marquis" <bertrand.marquis@arm.com>,
	"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v1 1/2] pci/rcar: Rename PCI host rcar4 to rcar
Date: Tue, 17 Nov 2026 18:34:06 +0200	[thread overview]
Message-ID: <57aa4eef-5af7-4ae8-9be3-84671ded2d12@gmail.com> (raw)
In-Reply-To: <350d08bb0f494f96c02cedc4fa5e40673d512236.1794817300.git.mykyta_poturai@epam.com>



16.11.2026 10:40, Mykyta Poturai пишет:

Hello Mykyta

> Gen5 mostly reuses the same DesignWare integration and register layout
> as Gen4, so one driver covers both. Drop the generation number from the
> file and symbol names.

NIT: But rcar4_pcie_osid_*, rcar4_pcie_bdf_msk_set, struct 
rcar4_pcie_priv, etc keep the generation number. Yes, the reason (the 
registers exist only on Gen4) is mentioned in cover letter, but this 
will not be committed to git history. I would add a sentence in the 
patch description.


> 
> Signed-off-by: Mykyta Poturai <mykyta_poturai@epam.com>
> ---
>   MAINTAINERS                                   |  2 +-
>   xen/arch/arm/pci/Makefile                     |  2 +-
>   .../pci/{pci-host-rcar4.c => pci-host-rcar.c} | 32 +++++++++----------
>   .../pci/{pci-host-rcar4.h => pci-host-rcar.h} |  6 ++--
>   xen/drivers/passthrough/arm/ipmmu-vmsa.c      |  2 +-
>   5 files changed, 22 insertions(+), 22 deletions(-)
>   rename xen/arch/arm/pci/{pci-host-rcar4.c => pci-host-rcar.c} (88%)
>   rename xen/arch/arm/pci/{pci-host-rcar4.h => pci-host-rcar.h} (88%)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b804434d52..68b47adf81 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -504,7 +504,7 @@ T:	git https://xenbits.xenproject.org/git-http/qemu-xen.git
>   RCAR PCI
>   M:	Mykyta Poturai <mykyta_poturai@epam.com>
>   S:	Supported
> -F:	xen/arch/arm/pci/pci-host-rcar4.c
> +F:	xen/arch/arm/pci/pci-host-rcar.c

Remark: pci-host-rcar.h is not covered by the RCAR PCI entry. Yes, this 
is pre-existing and not caused by the rename, I thought the line was 
edited anyway, so it would be a cheap addition.

I did not find any issues with current patch.

Reviewed-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

>   
...

[snip]


  reply	other threads:[~2026-11-17 16:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  8:40 [PATCH v1 0/2] Add R-Car Gen5 PCI host support Mykyta Poturai
2026-11-16  8:40 ` [PATCH v1 1/2] pci/rcar: Rename PCI host rcar4 to rcar Mykyta Poturai
2026-11-17 16:34   ` Oleksandr Tyshchenko [this message]
2026-11-16  8:40 ` [PATCH v1 2/2] pci/rcar: Add support for Gen5 PCI host Mykyta Poturai
2026-11-16 12:04   ` Oleksandr Tyshchenko
2026-11-16  9:44 ` [PATCH v1 0/2] Add R-Car Gen5 PCI host support Oleksii Kurochko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57aa4eef-5af7-4ae8-9be3-84671ded2d12@gmail.com \
    --to=olekstysh@gmail.com \
    --cc=Mykyta_Poturai@epam.com \
    --cc=Volodymyr_Babchuk@epam.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=anthony.perard@vates.tech \
    --cc=bertrand.marquis@arm.com \
    --cc=jbeulich@suse.com \
    --cc=julien@xen.org \
    --cc=michal.orzel@amd.com \
    --cc=roger@xenproject.org \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.